From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 01/15] staging: vboxvideo: Cleanup vbox_set_up_input_mapping() Date: Fri, 28 Sep 2018 14:38:35 +0200 Message-ID: <20180928123835.GA13609@kroah.com> References: <20180926194206.23517-1-hdegoede@redhat.com> <20180926194206.23517-2-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180926194206.23517-2-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Hans de Goede Cc: devel@driverdev.osuosl.org, Michael Thayer , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Sep 26, 2018 at 09:41:52PM +0200, Hans de Goede wrote: > This cleanups 2 things: > > 1) The first time we loop over the crtc-s, to compare framebuffers, fb1 may > get set to NULL by the fb1 = CRTC_FB(crtci); statement and then we call > to_vbox_framebuffer() on it. The result of this call is only used for > an address comparison, so we don't end up dereferencing the bad pointer, > but still it is better to not do this. > > 2) Since we already figure out the first crtc with a fb in the first loop > and store that in fb1, there is no need to loop over the crtc-s again just > to find the first crtc with a fb again. > > Signed-off-by: Hans de Goede I have two patch 1/15 in this series, making it 16 patches? Something went odd on your end, can you please resend these properly? thanks, greg k-h