From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C9AC43382 for ; Fri, 28 Sep 2018 12:51:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59B2921758 for ; Fri, 28 Sep 2018 12:51:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59B2921758 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728453AbeI1TPP (ORCPT ); Fri, 28 Sep 2018 15:15:15 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:49152 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbeI1TPP (ORCPT ); Fri, 28 Sep 2018 15:15:15 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EB4FCED1; Fri, 28 Sep 2018 05:51:36 -0700 (PDT) Received: from brain-police (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 71C453F5D3; Fri, 28 Sep 2018 05:51:34 -0700 (PDT) Date: Fri, 28 Sep 2018 13:51:31 +0100 From: Will Deacon To: Robin Murphy Cc: joro@8bytes.org, thunder.leizhen@huawei.com, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, guohanjun@huawei.com, huawei.libin@huawei.com, john.garry@huawei.com Subject: Re: [PATCH v8 3/7] iommu: Add "iommu.strict" command line option Message-ID: <20180928125130.GD1577@brain-police> References: <799fad801970298385af3abc8ca82620ad62c000.1537458163.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <799fad801970298385af3abc8ca82620ad62c000.1537458163.git.robin.murphy@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 20, 2018 at 05:10:23PM +0100, Robin Murphy wrote: > From: Zhen Lei > > Add a generic command line option to enable lazy unmapping via IOVA > flush queues, which will initally be suuported by iommu-dma. This echoes > the semantics of "intel_iommu=strict" (albeit with the opposite default > value), but in the driver-agnostic fashion of "iommu.passthrough". > > Signed-off-by: Zhen Lei > [rm: move handling out of SMMUv3 driver, clean up documentation] > Signed-off-by: Robin Murphy > --- > > v8: > - Rename "non-strict" to "strict" to better match existing options > - Rewrite doc text/commit message > - Downgrade boot-time message from warn/taint to info > > .../admin-guide/kernel-parameters.txt | 12 ++++++++++ > drivers/iommu/iommu.c | 23 +++++++++++++++++++ > 2 files changed, 35 insertions(+) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 9871e649ffef..92ae12aeabf4 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -1749,6 +1749,18 @@ > nobypass [PPC/POWERNV] > Disable IOMMU bypass, using IOMMU for PCI devices. > > + iommu.strict= [ARM64] Configure TLB invalidation behaviour > + Format: { "0" | "1" } > + 0 - Lazy mode. > + Request that DMA unmap operations use deferred > + invalidation of hardware TLBs, for increased > + throughput at the cost of reduced device isolation. > + Will fall back to strict mode if not supported by > + the relevant IOMMU driver. > + 1 - Strict mode (default). > + DMA unmap operations invalidate IOMMU hardware TLBs > + synchronously. > + > iommu.passthrough= > [ARM64] Configure DMA to bypass the IOMMU by default. > Format: { "0" | "1" } > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 8c15c5980299..02b6603f0616 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -41,6 +41,7 @@ static unsigned int iommu_def_domain_type = IOMMU_DOMAIN_IDENTITY; > #else > static unsigned int iommu_def_domain_type = IOMMU_DOMAIN_DMA; > #endif > +static bool iommu_dma_strict __read_mostly = true; > > struct iommu_callback_data { > const struct iommu_ops *ops; > @@ -131,6 +132,21 @@ static int __init iommu_set_def_domain_type(char *str) > } > early_param("iommu.passthrough", iommu_set_def_domain_type); > > +static int __init iommu_dma_setup(char *str) > +{ > + int ret; > + > + ret = kstrtobool(str, &iommu_dma_strict); > + if (ret) > + return ret; > + > + if (!iommu_dma_strict) > + pr_info("Enabling deferred TLB invalidation for DMA; protection against malicious/malfunctioning devices may be reduced.\n"); Printing here isn't quite right, because if somebody boots with something like: "iommu.strict=1 iommu.strict=0 iommu.strict=0 iommu.strict=1" then we'll print the wrong thing twice :) I think we either need to drop the print, or move it to a the DMA domain initialisation. Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Fri, 28 Sep 2018 13:51:31 +0100 Subject: [PATCH v8 3/7] iommu: Add "iommu.strict" command line option In-Reply-To: <799fad801970298385af3abc8ca82620ad62c000.1537458163.git.robin.murphy@arm.com> References: <799fad801970298385af3abc8ca82620ad62c000.1537458163.git.robin.murphy@arm.com> Message-ID: <20180928125130.GD1577@brain-police> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Sep 20, 2018 at 05:10:23PM +0100, Robin Murphy wrote: > From: Zhen Lei > > Add a generic command line option to enable lazy unmapping via IOVA > flush queues, which will initally be suuported by iommu-dma. This echoes > the semantics of "intel_iommu=strict" (albeit with the opposite default > value), but in the driver-agnostic fashion of "iommu.passthrough". > > Signed-off-by: Zhen Lei > [rm: move handling out of SMMUv3 driver, clean up documentation] > Signed-off-by: Robin Murphy > --- > > v8: > - Rename "non-strict" to "strict" to better match existing options > - Rewrite doc text/commit message > - Downgrade boot-time message from warn/taint to info > > .../admin-guide/kernel-parameters.txt | 12 ++++++++++ > drivers/iommu/iommu.c | 23 +++++++++++++++++++ > 2 files changed, 35 insertions(+) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 9871e649ffef..92ae12aeabf4 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -1749,6 +1749,18 @@ > nobypass [PPC/POWERNV] > Disable IOMMU bypass, using IOMMU for PCI devices. > > + iommu.strict= [ARM64] Configure TLB invalidation behaviour > + Format: { "0" | "1" } > + 0 - Lazy mode. > + Request that DMA unmap operations use deferred > + invalidation of hardware TLBs, for increased > + throughput at the cost of reduced device isolation. > + Will fall back to strict mode if not supported by > + the relevant IOMMU driver. > + 1 - Strict mode (default). > + DMA unmap operations invalidate IOMMU hardware TLBs > + synchronously. > + > iommu.passthrough= > [ARM64] Configure DMA to bypass the IOMMU by default. > Format: { "0" | "1" } > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 8c15c5980299..02b6603f0616 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -41,6 +41,7 @@ static unsigned int iommu_def_domain_type = IOMMU_DOMAIN_IDENTITY; > #else > static unsigned int iommu_def_domain_type = IOMMU_DOMAIN_DMA; > #endif > +static bool iommu_dma_strict __read_mostly = true; > > struct iommu_callback_data { > const struct iommu_ops *ops; > @@ -131,6 +132,21 @@ static int __init iommu_set_def_domain_type(char *str) > } > early_param("iommu.passthrough", iommu_set_def_domain_type); > > +static int __init iommu_dma_setup(char *str) > +{ > + int ret; > + > + ret = kstrtobool(str, &iommu_dma_strict); > + if (ret) > + return ret; > + > + if (!iommu_dma_strict) > + pr_info("Enabling deferred TLB invalidation for DMA; protection against malicious/malfunctioning devices may be reduced.\n"); Printing here isn't quite right, because if somebody boots with something like: "iommu.strict=1 iommu.strict=0 iommu.strict=0 iommu.strict=1" then we'll print the wrong thing twice :) I think we either need to drop the print, or move it to a the DMA domain initialisation. Will