From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 790E6C43382 for ; Fri, 28 Sep 2018 12:56:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23A0B2168B for ; Fri, 28 Sep 2018 12:56:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23A0B2168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728869AbeI1TTr (ORCPT ); Fri, 28 Sep 2018 15:19:47 -0400 Received: from mga05.intel.com ([192.55.52.43]:45865 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726934AbeI1TTr (ORCPT ); Fri, 28 Sep 2018 15:19:47 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2018 05:56:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,315,1534834800"; d="scan'208";a="266755153" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga005.fm.intel.com with ESMTP; 28 Sep 2018 05:56:02 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 76446209CB; Fri, 28 Sep 2018 15:56:01 +0300 (EEST) Date: Fri, 28 Sep 2018 15:56:01 +0300 From: Sakari Ailus To: Chen-Yu Tsai Cc: Laurent Pinchart , Yong Deng , Maxime Ripard , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , David Miller , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Hans Verkuil , Geert Uytterhoeven , Jacob Chen , Neil Armstrong , Thierry Reding , Philipp Zabel , Todor Tomov , Linux Media Mailing List , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi Subject: Re: [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Message-ID: <20180928125601.6ye5tvrmh57amvh5@paasikivi.fi.intel.com> References: <1537951204-24672-1-git-send-email-yong.deng@magewell.com> <20180928093833.gwmskm2jvby6x4s6@paasikivi.fi.intel.com> <14114604.4rraf0qJLU@avalon> <20180928102345.r2g342tg5mgcwfw6@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen-Yu, On Fri, Sep 28, 2018 at 07:10:58PM +0800, Chen-Yu Tsai wrote: > On Fri, Sep 28, 2018 at 6:23 PM Sakari Ailus > wrote: > > > > Hi Laurent, > > > > On Fri, Sep 28, 2018 at 12:45:12PM +0300, Laurent Pinchart wrote: > > > Hi Sakari, > > > > > > On Friday, 28 September 2018 12:38:33 EEST Sakari Ailus wrote: > > > > On Wed, Sep 26, 2018 at 04:40:04PM +0800, Yong Deng wrote: > > > > > Add binding documentation for Allwinner V3s CSI. > > > > > > > > > > Acked-by: Maxime Ripard > > > > > Acked-by: Sakari Ailus > > > > > > > > I know... but I have a few more comments. > > > > > > > > > Reviewed-by: Rob Herring > > > > > Signed-off-by: Yong Deng > > > > > --- > > > > > > > > > > .../devicetree/bindings/media/sun6i-csi.txt | 59 +++++++++++++++++ > > > > > 1 file changed, 59 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > b/Documentation/devicetree/bindings/media/sun6i-csi.txt new file mode > > > > > 100644 > > > > > index 000000000000..2ff47a9507a6 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > @@ -0,0 +1,59 @@ > > > > > +Allwinner V3s Camera Sensor Interface > > > > > +------------------------------------- > > > > > + > > > > > +Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 > > > > > +interface and CSI1 is used for parallel interface. > > > > > + > > > > > +Required properties: > > > > > + - compatible: value must be "allwinner,sun8i-v3s-csi" > > > > > + - reg: base address and size of the memory-mapped region. > > > > > + - interrupts: interrupt associated to this IP > > > > > + - clocks: phandles to the clocks feeding the CSI > > > > > + * bus: the CSI interface clock > > > > > + * mod: the CSI module clock > > > > > + * ram: the CSI DRAM clock > > > > > + - clock-names: the clock names mentioned above > > > > > + - resets: phandles to the reset line driving the CSI > > > > > + > > > > > +Each CSI node should contain one 'port' child node with one child > > > > > 'endpoint' +node, according to the bindings defined in > > > > > +Documentation/devicetree/bindings/media/video-interfaces.txt. As > > > > > mentioned > > > > > +above, the endpoint's bus type should be MIPI CSI-2 for CSI0 and parallel > > > > > or +Bt656 for CSI1. > > > > > > > > Which port represents CSI0 and which one is CSI1? That needs to be > > > > documented. > > > > > > There are two CSI devices, named CSI0 and CSI1, with one port each. The CSI0 > > > device supports CSI-2 only, and the CSI1 device parallel (BT.601 or BT.656) > > > only. > > > > > > > > + > > > > > +Endpoint node properties for CSI1 > > > > > > > > How about CSI0? I'd expect at least data-lanes, and clock-lanes as well if > > > > the hardware supports lane mapping. > > > > > > I enquired about that too. As far as I understand, CSI0 isn't supported yet in > > > the driver due to lack of documentation and lack of open-source vendor- > > > provided source code. While DT bindings are not tied to driver > > > implementations, it's not the best idea to design DT bindings without at least > > > one working implementation to test them. I thus proposed just listing CSI0 as > > > being unsupported for now. > > > > Ack. > > > > We should still define which receiver corresponds to a given port. Probably > > 1 for CSI1 would make sense, in order to avoid changing the order the > > hardware already uses. 0 doesn't need to be documented no IMO. > > > > What do you think? > > AFAICT it would be a completely seperate node, since they have different address > spaces, clocks and reset controls. So there's no possibility of confusion. > > According to Yong, CSI0 is tied internally to some unknown MIPI CSI2-receiver, > which is the undocumented part. CSI1 has its parallel data pins exposed to the > outside. Thanks for clearing up the confusion. If these are truly different kinds of devices, then don't they also deserve different compatible strings? And possibly also different DT binding documentation in a separate file. -- Regards, Sakari Ailus sakari.ailus@linux.intel.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Date: Fri, 28 Sep 2018 15:56:01 +0300 Message-ID: <20180928125601.6ye5tvrmh57amvh5@paasikivi.fi.intel.com> References: <1537951204-24672-1-git-send-email-yong.deng@magewell.com> <20180928093833.gwmskm2jvby6x4s6@paasikivi.fi.intel.com> <14114604.4rraf0qJLU@avalon> <20180928102345.r2g342tg5mgcwfw6@paasikivi.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Chen-Yu Tsai Cc: Laurent Pinchart , Yong Deng , Maxime Ripard , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , David Miller , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Hans Verkuil , Geert Uytterhoeven , Jacob Chen , Neil Armstrong , Thierry Reding , Philipp Zabel , Todor Tomov , Linux Media Mailing List devicetree List-Id: devicetree@vger.kernel.org Hi Chen-Yu, On Fri, Sep 28, 2018 at 07:10:58PM +0800, Chen-Yu Tsai wrote: > On Fri, Sep 28, 2018 at 6:23 PM Sakari Ailus > wrote: > > > > Hi Laurent, > > > > On Fri, Sep 28, 2018 at 12:45:12PM +0300, Laurent Pinchart wrote: > > > Hi Sakari, > > > > > > On Friday, 28 September 2018 12:38:33 EEST Sakari Ailus wrote: > > > > On Wed, Sep 26, 2018 at 04:40:04PM +0800, Yong Deng wrote: > > > > > Add binding documentation for Allwinner V3s CSI. > > > > > > > > > > Acked-by: Maxime Ripard > > > > > Acked-by: Sakari Ailus > > > > > > > > I know... but I have a few more comments. > > > > > > > > > Reviewed-by: Rob Herring > > > > > Signed-off-by: Yong Deng > > > > > --- > > > > > > > > > > .../devicetree/bindings/media/sun6i-csi.txt | 59 +++++++++++++++++ > > > > > 1 file changed, 59 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > b/Documentation/devicetree/bindings/media/sun6i-csi.txt new file mode > > > > > 100644 > > > > > index 000000000000..2ff47a9507a6 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > @@ -0,0 +1,59 @@ > > > > > +Allwinner V3s Camera Sensor Interface > > > > > +------------------------------------- > > > > > + > > > > > +Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 > > > > > +interface and CSI1 is used for parallel interface. > > > > > + > > > > > +Required properties: > > > > > + - compatible: value must be "allwinner,sun8i-v3s-csi" > > > > > + - reg: base address and size of the memory-mapped region. > > > > > + - interrupts: interrupt associated to this IP > > > > > + - clocks: phandles to the clocks feeding the CSI > > > > > + * bus: the CSI interface clock > > > > > + * mod: the CSI module clock > > > > > + * ram: the CSI DRAM clock > > > > > + - clock-names: the clock names mentioned above > > > > > + - resets: phandles to the reset line driving the CSI > > > > > + > > > > > +Each CSI node should contain one 'port' child node with one child > > > > > 'endpoint' +node, according to the bindings defined in > > > > > +Documentation/devicetree/bindings/media/video-interfaces.txt. As > > > > > mentioned > > > > > +above, the endpoint's bus type should be MIPI CSI-2 for CSI0 and parallel > > > > > or +Bt656 for CSI1. > > > > > > > > Which port represents CSI0 and which one is CSI1? That needs to be > > > > documented. > > > > > > There are two CSI devices, named CSI0 and CSI1, with one port each. The CSI0 > > > device supports CSI-2 only, and the CSI1 device parallel (BT.601 or BT.656) > > > only. > > > > > > > > + > > > > > +Endpoint node properties for CSI1 > > > > > > > > How about CSI0? I'd expect at least data-lanes, and clock-lanes as well if > > > > the hardware supports lane mapping. > > > > > > I enquired about that too. As far as I understand, CSI0 isn't supported yet in > > > the driver due to lack of documentation and lack of open-source vendor- > > > provided source code. While DT bindings are not tied to driver > > > implementations, it's not the best idea to design DT bindings without at least > > > one working implementation to test them. I thus proposed just listing CSI0 as > > > being unsupported for now. > > > > Ack. > > > > We should still define which receiver corresponds to a given port. Probably > > 1 for CSI1 would make sense, in order to avoid changing the order the > > hardware already uses. 0 doesn't need to be documented no IMO. > > > > What do you think? > > AFAICT it would be a completely seperate node, since they have different address > spaces, clocks and reset controls. So there's no possibility of confusion. > > According to Yong, CSI0 is tied internally to some unknown MIPI CSI2-receiver, > which is the undocumented part. CSI1 has its parallel data pins exposed to the > outside. Thanks for clearing up the confusion. If these are truly different kinds of devices, then don't they also deserve different compatible strings? And possibly also different DT binding documentation in a separate file. -- Regards, Sakari Ailus sakari.ailus@linux.intel.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: sakari.ailus@linux.intel.com (Sakari Ailus) Date: Fri, 28 Sep 2018 15:56:01 +0300 Subject: [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) In-Reply-To: References: <1537951204-24672-1-git-send-email-yong.deng@magewell.com> <20180928093833.gwmskm2jvby6x4s6@paasikivi.fi.intel.com> <14114604.4rraf0qJLU@avalon> <20180928102345.r2g342tg5mgcwfw6@paasikivi.fi.intel.com> Message-ID: <20180928125601.6ye5tvrmh57amvh5@paasikivi.fi.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chen-Yu, On Fri, Sep 28, 2018 at 07:10:58PM +0800, Chen-Yu Tsai wrote: > On Fri, Sep 28, 2018 at 6:23 PM Sakari Ailus > wrote: > > > > Hi Laurent, > > > > On Fri, Sep 28, 2018 at 12:45:12PM +0300, Laurent Pinchart wrote: > > > Hi Sakari, > > > > > > On Friday, 28 September 2018 12:38:33 EEST Sakari Ailus wrote: > > > > On Wed, Sep 26, 2018 at 04:40:04PM +0800, Yong Deng wrote: > > > > > Add binding documentation for Allwinner V3s CSI. > > > > > > > > > > Acked-by: Maxime Ripard > > > > > Acked-by: Sakari Ailus > > > > > > > > I know... but I have a few more comments. > > > > > > > > > Reviewed-by: Rob Herring > > > > > Signed-off-by: Yong Deng > > > > > --- > > > > > > > > > > .../devicetree/bindings/media/sun6i-csi.txt | 59 +++++++++++++++++ > > > > > 1 file changed, 59 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > b/Documentation/devicetree/bindings/media/sun6i-csi.txt new file mode > > > > > 100644 > > > > > index 000000000000..2ff47a9507a6 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > @@ -0,0 +1,59 @@ > > > > > +Allwinner V3s Camera Sensor Interface > > > > > +------------------------------------- > > > > > + > > > > > +Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 > > > > > +interface and CSI1 is used for parallel interface. > > > > > + > > > > > +Required properties: > > > > > + - compatible: value must be "allwinner,sun8i-v3s-csi" > > > > > + - reg: base address and size of the memory-mapped region. > > > > > + - interrupts: interrupt associated to this IP > > > > > + - clocks: phandles to the clocks feeding the CSI > > > > > + * bus: the CSI interface clock > > > > > + * mod: the CSI module clock > > > > > + * ram: the CSI DRAM clock > > > > > + - clock-names: the clock names mentioned above > > > > > + - resets: phandles to the reset line driving the CSI > > > > > + > > > > > +Each CSI node should contain one 'port' child node with one child > > > > > 'endpoint' +node, according to the bindings defined in > > > > > +Documentation/devicetree/bindings/media/video-interfaces.txt. As > > > > > mentioned > > > > > +above, the endpoint's bus type should be MIPI CSI-2 for CSI0 and parallel > > > > > or +Bt656 for CSI1. > > > > > > > > Which port represents CSI0 and which one is CSI1? That needs to be > > > > documented. > > > > > > There are two CSI devices, named CSI0 and CSI1, with one port each. The CSI0 > > > device supports CSI-2 only, and the CSI1 device parallel (BT.601 or BT.656) > > > only. > > > > > > > > + > > > > > +Endpoint node properties for CSI1 > > > > > > > > How about CSI0? I'd expect at least data-lanes, and clock-lanes as well if > > > > the hardware supports lane mapping. > > > > > > I enquired about that too. As far as I understand, CSI0 isn't supported yet in > > > the driver due to lack of documentation and lack of open-source vendor- > > > provided source code. While DT bindings are not tied to driver > > > implementations, it's not the best idea to design DT bindings without at least > > > one working implementation to test them. I thus proposed just listing CSI0 as > > > being unsupported for now. > > > > Ack. > > > > We should still define which receiver corresponds to a given port. Probably > > 1 for CSI1 would make sense, in order to avoid changing the order the > > hardware already uses. 0 doesn't need to be documented no IMO. > > > > What do you think? > > AFAICT it would be a completely seperate node, since they have different address > spaces, clocks and reset controls. So there's no possibility of confusion. > > According to Yong, CSI0 is tied internally to some unknown MIPI CSI2-receiver, > which is the undocumented part. CSI1 has its parallel data pins exposed to the > outside. Thanks for clearing up the confusion. If these are truly different kinds of devices, then don't they also deserve different compatible strings? And possibly also different DT binding documentation in a separate file. -- Regards, Sakari Ailus sakari.ailus at linux.intel.com