All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: stop using _PTRS_PER_PGD
@ 2018-09-28  9:32 Alexandre Belloni
  2018-09-28 17:32 ` Paul Burton
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2018-09-28  9:32 UTC (permalink / raw)
  To: Paul Burton
  Cc: James Hogan, Ralf Baechle, Arnd Bergmann, linux-mips,
	linux-kernel, Alexandre Belloni

gcc 3.3 has been retired for a while, use PTRS_PER_PGD and remove the
asm-offsets.h inclusion.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 arch/mips/mm/init.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/arch/mips/mm/init.c b/arch/mips/mm/init.c
index 400676ce03f4..15cae0f11880 100644
--- a/arch/mips/mm/init.c
+++ b/arch/mips/mm/init.c
@@ -32,7 +32,6 @@
 #include <linux/kcore.h>
 #include <linux/initrd.h>
 
-#include <asm/asm-offsets.h>
 #include <asm/bootinfo.h>
 #include <asm/cachectl.h>
 #include <asm/cpu.h>
@@ -521,17 +520,13 @@ unsigned long pgd_current[NR_CPUS];
 #endif
 
 /*
- * gcc 3.3 and older have trouble determining that PTRS_PER_PGD and PGD_ORDER
- * are constants.  So we use the variants from asm-offset.h until that gcc
- * will officially be retired.
- *
  * Align swapper_pg_dir in to 64K, allows its address to be loaded
  * with a single LUI instruction in the TLB handlers.  If we used
  * __aligned(64K), its size would get rounded up to the alignment
  * size, and waste space.  So we place it in its own section and align
  * it in the linker script.
  */
-pgd_t swapper_pg_dir[_PTRS_PER_PGD] __section(.bss..swapper_pg_dir);
+pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);
 #ifndef __PAGETABLE_PUD_FOLDED
 pud_t invalid_pud_table[PTRS_PER_PUD] __page_aligned_bss;
 #endif
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] MIPS: stop using _PTRS_PER_PGD
  2018-09-28  9:32 [PATCH] MIPS: stop using _PTRS_PER_PGD Alexandre Belloni
@ 2018-09-28 17:32 ` Paul Burton
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2018-09-28 17:32 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: James Hogan, Ralf Baechle, Arnd Bergmann, linux-mips, linux-kernel

Hi Alexandre,

On Fri, Sep 28, 2018 at 11:32:02AM +0200, Alexandre Belloni wrote:
> gcc 3.3 has been retired for a while, use PTRS_PER_PGD and remove the
> asm-offsets.h inclusion.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
>  arch/mips/mm/init.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Thanks - applied to mips-next for 4.20.

Paul

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-28 17:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-28  9:32 [PATCH] MIPS: stop using _PTRS_PER_PGD Alexandre Belloni
2018-09-28 17:32 ` Paul Burton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.