All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, yongping <yongping.zhang@broadcom.com>,
	stable@dpdk.org, Yongping Zhang <yongping.zhang@broadcom.com>
Subject: [PATCH v3 10/15] net/bnxt: fix registration of VF async event completion ring
Date: Fri, 28 Sep 2018 19:00:01 -0700	[thread overview]
Message-ID: <20180929020006.71505-11-ajit.khaparde@broadcom.com> (raw)
In-Reply-To: <20180929020006.71505-1-ajit.khaparde@broadcom.com>

From: yongping <yongping@broadcom.com>

While registering vf's event completion ring to FW, use the wrong
macro, FW doesn't set up the event completion ring successfully,
VF can't receive any async event.

Fixes: 4535cad39515 ("net/bnxt: handle VF/PF initialization appropriately")
Cc: stable@dpdk.org

Signed-off-by: Yongping Zhang <yongping.zhang@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
--
v1->v2:
Shorten commit log and message as per review comment
---
 drivers/net/bnxt/bnxt_hwrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 62da254b9..51fe3a4c2 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -3001,7 +3001,7 @@ int bnxt_hwrm_vf_func_cfg_def_cp(struct bnxt *bp)
 	HWRM_PREP(req, FUNC_VF_CFG, BNXT_USE_CHIMP_MB);
 
 	req.enables = rte_cpu_to_le_32(
-			HWRM_FUNC_CFG_INPUT_ENABLES_ASYNC_EVENT_CR);
+			HWRM_FUNC_VF_CFG_INPUT_ENABLES_ASYNC_EVENT_CR);
 	req.async_event_cr = rte_cpu_to_le_16(
 			bp->def_cp_ring->cp_ring_struct->fw_ring_id);
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
-- 
2.17.1 (Apple Git-112)

  parent reply	other threads:[~2018-09-29  2:00 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-01  4:32 [PATCH 0/7] bnxt patchset Ajit Khaparde
2018-09-01  4:32 ` [PATCH 1/7] net/bnxt: get rid of ff pools array and use the vnic info array Ajit Khaparde
2018-09-19  9:05   ` Ferruh Yigit
2018-09-19  9:21     ` Ferruh Yigit
2018-09-22  4:55       ` [PATCH v2 00/12] bnxt patchset Ajit Khaparde
2018-09-22  4:55         ` [PATCH v2 01/12] net/bnxt: get rid of ff pools array and use the vnic info array instead Ajit Khaparde
2018-09-22  4:55         ` [PATCH v2 02/12] net/bnxt: fix uninitialized ptr access in transmit handler Ajit Khaparde
2018-09-22  4:55         ` [PATCH v2 03/12] net/bnxt: fix MTU setting Ajit Khaparde
2018-09-22  4:55         ` [PATCH v2 04/12] net/bnxt: update HWRM version Ajit Khaparde
2018-09-25 11:39           ` Ferruh Yigit
2018-09-22  4:55         ` [PATCH v2 05/12] net/bnxt: add support for extended port counters Ajit Khaparde
2018-09-22  4:55         ` [PATCH v2 06/12] net/bnxt: add support to enable new mailbox channel Ajit Khaparde
2018-09-22  4:55         ` [PATCH v2 07/12] net/bnxt: add support for trusted VF Ajit Khaparde
2018-09-22  4:55         ` [PATCH v2 08/12] net/bnxt: use correct macro to register VF async event completion ring Ajit Khaparde
2018-09-25 11:30           ` Ferruh Yigit
2018-09-22  4:55         ` [PATCH v2 09/12] net/bnxt: set MAC filtering as outer for non tunnel frames Ajit Khaparde
2018-09-25 11:33           ` Ferruh Yigit
2018-09-22  4:55         ` [PATCH v2 10/12] net/bnxt: set a VNIC as default only once Ajit Khaparde
2018-09-22  4:55         ` [PATCH v2 11/12] net/bnxt: set VLAN strip mode before default vnic cfg Ajit Khaparde
2018-09-25 11:34           ` Ferruh Yigit
2018-09-22  4:55         ` [PATCH v2 12/12] net/bnxt: remove excess log messages Ajit Khaparde
2018-09-25 11:35           ` Ferruh Yigit
2018-09-25 11:37         ` [PATCH v2 00/12] bnxt patchset Ferruh Yigit
2018-09-29  1:59           ` [PATCH v3 00/15] " Ajit Khaparde
2018-09-29  1:59             ` [PATCH v3 01/15] net/bnxt: get rid of ff pools and use VNIC info array Ajit Khaparde
2018-09-29  1:59             ` [PATCH v3 02/15] net/bnxt: fix uninitialized ptr access in transmit handler Ajit Khaparde
2018-09-29  1:59             ` [PATCH v3 03/15] net/bnxt: fix MTU setting Ajit Khaparde
2018-09-29  1:59             ` [PATCH v3 04/15] net/bnxt: update HWRM version Ajit Khaparde
2018-09-29  1:59             ` [PATCH v3 05/15] net/bnxt: update HWRM version part 2 Ajit Khaparde
2018-09-29  1:59             ` [PATCH v3 06/15] net/bnxt: update HWRM version part 3 Ajit Khaparde
2018-09-29  1:59             ` [PATCH v3 07/15] net/bnxt: add support for extended port counters Ajit Khaparde
2018-09-29  1:59             ` [PATCH v3 08/15] net/bnxt: add support to enable new mailbox channel Ajit Khaparde
2018-09-29  2:00             ` [PATCH v3 09/15] net/bnxt: add support for trusted VF Ajit Khaparde
2018-09-29  2:00             ` Ajit Khaparde [this message]
2018-09-29  2:00             ` [PATCH v3 11/15] net/bnxt: set MAC filtering as outer for non tunnel frames Ajit Khaparde
2018-09-29  2:00             ` [PATCH v3 12/15] net/bnxt: set a VNIC as default only once Ajit Khaparde
2018-09-29  2:00             ` [PATCH v3 13/15] net/bnxt: set VLAN strip mode before default VNIC cfg Ajit Khaparde
2018-09-29  2:00             ` [PATCH v3 14/15] net/bnxt: remove excess log messages Ajit Khaparde
2018-09-29  2:00             ` [PATCH v3 15/15] net/bnxt: reduce the polling interval for valid bit Ajit Khaparde
2018-10-02  8:25             ` [PATCH v3 00/15] bnxt patchset Ferruh Yigit
2018-10-02 16:44               ` Ajit Khaparde
2018-10-03  9:48             ` Ferruh Yigit
2018-09-01  4:32 ` [PATCH 2/7] net/bnxt: fix uninitialized ptr access in transmit handler Ajit Khaparde
2018-09-19  9:23   ` Ferruh Yigit
2018-09-01  4:32 ` [PATCH 3/7] net/bnxt: fix MTU setting Ajit Khaparde
2018-09-01  4:32 ` [PATCH 4/7] net/bnxt: update HWRM version Ajit Khaparde
2018-09-01  4:32 ` [PATCH 5/7] net/bnxt: add support for extended port counters Ajit Khaparde
2018-09-01  4:32 ` [PATCH 6/7] net/bnxt: add support to enable new mailbox channel Ajit Khaparde
2018-09-01  4:32 ` [PATCH 7/7] net/bnxt: add support for trusted VF Ajit Khaparde
2018-09-19  9:26 ` [PATCH 0/7] bnxt patchset Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180929020006.71505-11-ajit.khaparde@broadcom.com \
    --to=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    --cc=yongping.zhang@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.