From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH net-next] geneve: fix ttl inherit type
Date: Sat, 29 Sep 2018 17:20:33 +0800
Message-ID: <20180929092032.GI24677@leo.usersys.redhat.com>
References: <1538096998-20937-1-git-send-email-liuhangbin@gmail.com>
 <b4f9a3b2-34eb-351b-15d2-867c033d667e@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
        Stephen Hemminger <stephen@networkplumber.org>,
        Phil Sutter <phil@nwl.cc>
To: David Ahern <dsahern@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f193.google.com ([209.85.215.193]:46520 "EHLO
        mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727518AbeI2PsZ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 29 Sep 2018 11:48:25 -0400
Received: by mail-pg1-f193.google.com with SMTP id b129-v6so6103390pga.13
        for <netdev@vger.kernel.org>; Sat, 29 Sep 2018 02:20:43 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <b4f9a3b2-34eb-351b-15d2-867c033d667e@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi David Ahern,
On Fri, Sep 28, 2018 at 11:59:37AM -0600, David Ahern wrote:
> On 9/27/18 7:09 PM, Hangbin Liu wrote:
> > Phil pointed out that there is a mismatch between vxlan and geneve ttl
> > inherit. We should define it as a flag and use nla_put_flag to export this
> > opiton.
> > 
> > Fixes: 52d0d404d39dd ("geneve: add ttl inherit support")
> 
> same here .. getting an unknown commit id.

This one targets to kernel net-next tree.

But as Michal suggested. We can leave geneve ttl inherit as NLA_U8 to
be able set/unset it. I will re-consider this patch.

Thanks
Hangbin