All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: linux-usb@vger.kernel.org
Cc: Karoly Pados <pados@pados.hu>,
	Loic Poulain <loic.poulain@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan@kernel.org>
Subject: [PATCH 0/2] USB: serial: gpio line-name fix and FT232R CBUS gpio support
Date: Sun, 30 Sep 2018 14:27:01 +0200	[thread overview]
Message-ID: <20180930122703.7115-1-johan@kernel.org> (raw)

Turns out gpiolib still doesn't like having non-unique line names, so
drop the line names from the recently added FTX cbus gpio
implementation before adding support also for FT232R.

Linus, we finally got around to adding gpio support for FTDI devices;
see commit 

	ba93cc7da896 ("USB: serial: ftdi_sio: implement GPIO support for FT-X devices")
	
in my usb-next branch (and linux-next).

The gpiolib warnings and inability to use the legacy sysfs interface
prevents us from setting the line names however as someone is bound to
plugin more than one of these devices at some point. I think we
discussed this issue with the name space and hotpluggable devices a few
years ago, but looks like this topic may need to be revisited.

Thanks,
Johan


Johan Hovold (2):
  USB: serial: ftdi_sio: fix gpio name collisions
  USB: serial: ftdi_sio: add support for FT232R CBUS gpios

 drivers/usb/serial/ftdi_sio.c | 45 +++++++++++++++++++++++++++++------
 drivers/usb/serial/ftdi_sio.h |  3 ++-
 2 files changed, 40 insertions(+), 8 deletions(-)

-- 
2.19.0

             reply	other threads:[~2018-09-30 12:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-30 12:27 Johan Hovold [this message]
2018-09-30 12:27 ` [PATCH 1/2] USB: serial: ftdi_sio: fix gpio name collisions Johan Hovold
2018-09-30 12:27   ` [1/2] " Johan Hovold
2018-09-30 12:27 ` [PATCH 2/2] USB: serial: ftdi_sio: add support for FT232R CBUS gpios Johan Hovold
2018-09-30 12:27   ` [2/2] " Johan Hovold
2018-10-01  9:43 ` [PATCH 0/2] USB: serial: gpio line-name fix and FT232R CBUS gpio support Linus Walleij
2018-10-05 13:40   ` Johan Hovold
2018-10-10  9:36     ` Linus Walleij
2018-11-13  9:33       ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180930122703.7115-1-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=pados@pados.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.