From: Daan Wendelen <daanwendelen@gmail.com>
To: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
Cc: netdev@vger.kernel.org, hkallweit1@gmail.com,
nic_swsd@realtek.com, davem@davemloft.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] r8169: always autoneg on resume
Date: Mon, 1 Oct 2018 00:17:51 +0200 [thread overview]
Message-ID: <20180930221751.rd7wva3zolephj6q@scappy> (raw)
In-Reply-To: <1538319728.z22jaatdgh.astroid@alex-desktop.none>
Hi Alex,
I randomly opened your patch even though I have absolutely no idea what this patch is about, but I
found a mistake in one of the comments:
On Sun, Sep 30, 2018 at 11:06:39AM -0400, Alex Xu (Hello71) wrote:
> This affects at least versions 25 and 33, so assume all cards are broken
...
> * 1GBit link after resuming from S3. For whatever reason the PHY on
> - * this chip doesn't properly start a renegotiation when soft-reset.
> + * these chips doesn't properly start a renegotiation when soft-reset.
~~~~~~~
I believe it should be "these chips don't"
With kind regards,
Daan
next prev parent reply other threads:[~2018-09-30 22:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 15:06 [PATCH net v2] r8169: always autoneg on resume Alex Xu (Hello71)
2018-09-30 22:17 ` Daan Wendelen [this message]
2018-09-30 22:30 ` Alex Xu
2018-10-01 2:39 ` Andrew Lunn
2018-10-01 3:31 ` Alex Xu
2018-10-01 5:33 ` Daan Wendelen
2018-10-03 5:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180930221751.rd7wva3zolephj6q@scappy \
--to=daanwendelen@gmail.com \
--cc=alex_y_xu@yahoo.ca \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.