From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F29C43143 for ; Mon, 1 Oct 2018 08:52:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A6E520652 for ; Mon, 1 Oct 2018 08:52:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A6E520652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728977AbeJAP3H (ORCPT ); Mon, 1 Oct 2018 11:29:07 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:56765 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbeJAP3H (ORCPT ); Mon, 1 Oct 2018 11:29:07 -0400 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1g6twA-0001Vq-VC; Mon, 01 Oct 2018 10:52:18 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1g6tw4-0004lo-FT; Mon, 01 Oct 2018 10:52:12 +0200 Date: Mon, 1 Oct 2018 10:52:12 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: jun qian Cc: Greg Kroah-Hartman , Barry song <21cnbao@gmail.com>, Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr Message-ID: <20181001085212.wu7eba4eh7koy5jx@pengutronix.de> References: <20180827144904.17226-1-hangdianqj@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180827144904.17226-1-hangdianqj@163.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Aug 27, 2018 at 07:49:04AM -0700, jun qian wrote: > Before the program enters the uart ISR, the local interrupt has been > disabled by the system, so it's not appropriate to use spin_lock_irqsave > interface in the ISR. "not appropriate" is a bit strong. It's not as optimal as it could be though, yes. The change is fine, Acked-by: Uwe Kleine-König -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |