From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] build: add drivers_install_subdir meson option Date: Mon, 1 Oct 2018 11:01:39 +0100 Message-ID: <20181001100138.GA11000@bricha3-MOBL.ger.corp.intel.com> References: <20180928175803.12955-1-bluca@debian.org> <20181001091714.GA25944@bricha3-MOBL.ger.corp.intel.com> <20181001092530.GB25944@bricha3-MOBL.ger.corp.intel.com> <1538387162.8363.41.camel@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, tredaelli@redhat.com, mvarlese@suse.de, christian.ehrhardt@canonical.com To: Luca Boccassi Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8BCE3160 for ; Mon, 1 Oct 2018 12:02:36 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1538387162.8363.41.camel@debian.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 01, 2018 at 10:46:02AM +0100, Luca Boccassi wrote: > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote: > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote: > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote: > > > > Allow users and packagers to override the default dpdk/drivers > > > > subdirectory where the PMDs get installed under $lib. > > > > > > > > Signed-off-by: Luca Boccassi > > > > --- > > > > > > I'm ok with this change, but what is the current location used by > > > distro's > > > right now? I mistakenly never checked what was done before I used > > > dpdk/drivers as a default value, and I'd like the default to match > > > the > > > common option if possible. > > > > > > /Bruce > > > > > > > Replying to my own question, I've just checked on CentOS and Debian, > > and it > > appears both are using directory "dpdk-pmds" as the subdir name. > > Therefore, > > let's just make that the default. [Does it need to be configurable in > > that > > case?] > > > > /Bruce > > If the default is the one I expect then I'm fine without having an > option (actually happier - less things to configure). > > But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last January :-) > We changed because using a single directory creates problems when > multiple different ABI versions are installed, due to the EAL autoload > from that directory. So we need a different subdirectory per ABI > revision. > > We were actually talking with Timothy a while ago to make this > consistent across our distros, and perhaps Marco can chip in as well. > > Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm not > too fussy on $something, it can be drivers or pmds or something else. > Sounds like it needs to be configurable, just in case. Acked-by: Bruce Richardson