From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH 1/4] ethdev: add SCTP Rx checksum offload support Date: Mon, 1 Oct 2018 21:29:46 +0530 Message-ID: <20181001155945.GB1570@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Andrew Rybchenko , dev@dpdk.org To: Ferruh Yigit Return-path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700072.outbound.protection.outlook.com [40.107.70.72]) by dpdk.org (Postfix) with ESMTP id 730CB1B43B for ; Mon, 1 Oct 2018 18:00:14 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Mon, 1 Oct 2018 14:46:39 +0100 > From: Ferruh Yigit > To: Jerin Jacob , Wenzhuo Lu > , Jingjing Wu , Bernard > Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Andrew Rybchenko > > CC: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload > support > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > > On 9/13/2018 2:47 PM, Jerin Jacob wrote: > > Signed-off-by: Jerin Jacob > > Overall set looks good to me, I put some comments on individual patches. > > And can you please rebase on top of latest head? Sure. Regarding space issue mentioned in other email in this thread. It looks like similar space added in other offloads. example: http://git.dpdk.org/dpdk/tree/app/test-pmd/config.c#n571 So, I expect no change in this patch other than rebase to latest head. If not, let me know. > > Thanks, > ferruh >