From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion Date: Mon, 1 Oct 2018 18:52:22 +0200 Message-ID: <20181001165222.GE11082@phenom.ffwll.local> References: <20180926194206.23517-1-hdegoede@redhat.com> <20180926194206.23517-12-hdegoede@redhat.com> <20181001075344.GR11082@phenom.ffwll.local> <501c05d9-e053-b74f-f7b5-6253797e32c4@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AA266E23F for ; Mon, 1 Oct 2018 16:52:27 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id y19-v6so3756551edd.2 for ; Mon, 01 Oct 2018 09:52:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <501c05d9-e053-b74f-f7b5-6253797e32c4@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Michael Thayer , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgMDEsIDIwMTggYXQgMTE6Mzc6MjlBTSArMDIwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBIaSwKPiAKPiBPbiAwMS0xMC0xOCAwOTo1MywgRGFuaWVsIFZldHRlciB3cm90ZToK PiA+IE9uIFdlZCwgU2VwIDI2LCAyMDE4IGF0IDA5OjQyOjAyUE0gKzAyMDAsIEhhbnMgZGUgR29l ZGUgd3JvdGU6Cj4gPiA+IEF0b21pYyBtb2Rlc2V0dGluZyBkb2VzIG5vdCB1c2UgdGhlIHRyYWRp dGlvbmFsIGRwbXMgY2FsbCBiYWNrcywgaW5zdGVhZAo+ID4gPiB3ZSBzaG91bGQgY2hlY2sgY3J0 Y19zdGF0ZS0+YWN0aXZlLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogSGFucyBkZSBHb2Vk ZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4KPiA+IAo+ID4gQXJlIHlvdSBzdXJlIHRoaXMgZG9lcyB3 aGF0IHlvdSB3YW50IGl0IHRvIGRvPyBBdG9taWMgaGVscGVycyBmdWxseSBzaHV0Cj4gPiBkb3du IHRoZSBzY3JlZW4gd2hlbiB5b3UgZG8gYSBkcG1zIG9mZiwgImp1c3QgYmxhbmtlZCIga2luZGEg ZG9lc24ndCBleGlzdAo+ID4gYXMgYSBzdGF0ZSBieSBkZWZhdWx0Lgo+IAo+IFllcyBJJ20gc3Vy ZSBJIHRlc3RlZCAieHNldCBkcG1zIGZvcmNlIG9mZiIgYW5kIGJlZm9yZSB0aGlzIHdvdWxkCj4g cmVzdWx0IGluIGluIHRoZSB2aXJ0dWFsIG1vbml0b3JzIChqdXN0IHdpbmRvd3Mgb24gdGhlIGhv c3QpIHRvIHJlc2l6ZSB0bwo+IDY0MHg0ODAgYW5kIGluIHRoYXQgNjQweDQ4MCBzdGlsbCBzaG93 IHBhcnQgb2YgdGhlIG9sZCBjb250ZW50cy4KCkhtLCB0aGlzIHNvdW5kcyBhIGJpdCBsaWtlIGEg YnVnIGluIHlvdXIgY29kZSBzb21ld2hlcmUsIG9yIGF0IGxlYXN0IG5vdAoxMDAlIGNvbnZlcnRl ZCBvdmVyIHRvIGF0b21pYy4gRnJvbSBhIGRyaXZlciBwb3YgaXQgc2hvdWxkIGJlIDEwMCUKZXF1 aXZhbGVudCBjb2RlIGJldHdlZW4gZHBtcyBvZmYgYW5kIHRoZSB4cmFuZHIgLS1vZmYuIElmIGRw bXMgc2hvd3Mgc29tZQpnYXJiYWdlIHdpdGhvdXQgdGhpcywgdGhlbiBzb21ldGhpbmcgaXMgd3Jv bmcuCgpUaGUgb25seSBkaWZmZXJlbmNlIGlzIHRoYXQgZm9yIGRwbXMgb2ZmIHRoZSBoZWxwZXJz IGRvbid0IGNhbGwKLT5jbGVhbnVwX3BsYW5lIChhbmQgdGhlbiAtPnByZXBhcmVfcGxhbmUgb24g cmUtZW5hYmxpbmcpLCBzaW5jZSB0aGUKZnJhbWVidWZmZXJzIGFyZSBzdXBwb3NlZCB0byBzdGlj ayBhcm91bmQuIEFyZSB5b3UgcGVyY2hhbmNlIGRvaW5nIHNvbWUKbW9kZXNldCBwcm9ncmFtbWlu ZyBpbiB0aGVyZT8gVGhhdCB3b3VsZCBiZSBhIGJ1ZyBpbiB0aGUgYXRvbWljCmltcGxlbWVudGF0 aW9uLgoKY3J0Y19zdGF0ZS0+YWN0aXZlIHNob3VsZCBvbmx5IGJlIGNvbnN1bHRlZCBmcm9tIGF0 b21pY19jaGVjayBjYWxsYmFja3MuCkkndmUgYWRkZWQgc29tZSBwcmV0dHkgbGVuZ3RoeSBrZXJu ZWxkb2MgZm9yIHRoaXMganVzdCByZWNlbnRseSwgdG8KZXhwbGFpbiBiZXR0ZXIgaG93IHRoaXMg aXMgc3VwcG9zZWQgdG8gd29yay4KCj4gQWZ0ZXIgdGhpcyBwYXRjaCB0aGV5IGJlY29tZSBibGFj ayBpbnN0ZWFkLgo+IAo+IE5vdGUgc29tZXdoYXQgcmVsYXRlZCwgVmlydHVhbGJveCBkb2VzIG5v dCBhbGxvdyBjbG9zaW5nIGEgd2luZG93IGZyb20KPiB3aXRoaW4gdGhlIGd1ZXN0LCBpZiB0aGUg dXNlciB3YW50cyB0byBzdG9wIHVzaW5nIGFuIChleHRyYSkgdmlydHVhbCBtb25pdG9yCj4gaXQg bmVlZHMgdG8gYmUgZGlzYWJsZWQgaW4gdGhlIFZNcyBVSS4gVHVybmluZyBvZiBhIG1vbml0b3Ig dGhyb3VnaCBlLmcuCj4gInhyYW5kciAtLW91dHB1dCBmb28gLS1vZmYiIGp1c3QgbWFrZXMgdGhl IHdpbmRvdyBibGFjay4KCk9rIHRoYXQncyBmdW5ueSwgYnV0IHNob3VsZG4ndCBiZSByZWxhdGVk IHRvIHdoYXQncyBnb2luZyBvbiBoZXJlLgotRGFuaWVsCgo+IAo+IFJlZ2FyZHMsCj4gCj4gSGFu cwo+IAo+IAo+IAo+IAo+ID4gLURhbmllbAo+ID4gCj4gPiA+IC0tLQo+ID4gPiAgIGRyaXZlcnMv c3RhZ2luZy92Ym94dmlkZW8vdmJveF9kcnYuaCAgfCAgMSAtCj4gPiA+ICAgZHJpdmVycy9zdGFn aW5nL3Zib3h2aWRlby92Ym94X21vZGUuYyB8IDI4ICsrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQo+ID4gPiAgIDIgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMo LSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvdmJveHZpZGVvL3Zi b3hfZHJ2LmggYi9kcml2ZXJzL3N0YWdpbmcvdmJveHZpZGVvL3Zib3hfZHJ2LmgKPiA+ID4gaW5k ZXggZmNjYjM4NTFkNmEzLi45Y2MyMGMxODJkZjEgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMv c3RhZ2luZy92Ym94dmlkZW8vdmJveF9kcnYuaAo+ID4gPiArKysgYi9kcml2ZXJzL3N0YWdpbmcv dmJveHZpZGVvL3Zib3hfZHJ2LmgKPiA+ID4gQEAgLTEzOSw3ICsxMzksNiBAQCBzdHJ1Y3QgdmJv eF9jb25uZWN0b3Igewo+ID4gPiAgIHN0cnVjdCB2Ym94X2NydGMgewo+ID4gPiAgIAlzdHJ1Y3Qg ZHJtX2NydGMgYmFzZTsKPiA+ID4gLQlib29sIGJsYW5rZWQ7Cj4gPiA+ICAgCWJvb2wgZGlzY29u bmVjdGVkOwo+ID4gPiAgIAl1bnNpZ25lZCBpbnQgY3J0Y19pZDsKPiA+ID4gICAJdTMyIGZiX29m ZnNldDsKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy92Ym94dmlkZW8vdmJveF9t b2RlLmMgYi9kcml2ZXJzL3N0YWdpbmcvdmJveHZpZGVvL3Zib3hfbW9kZS5jCj4gPiA+IGluZGV4 IGM0ZWMzZmE0OTc4Mi4uNDlmZjljNGE2MzAyIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL3N0 YWdpbmcvdmJveHZpZGVvL3Zib3hfbW9kZS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy92 Ym94dmlkZW8vdmJveF9tb2RlLmMKPiA+ID4gQEAgLTg0LDE0ICs4NCwxMyBAQCBzdGF0aWMgdm9p ZCB2Ym94X2RvX21vZGVzZXQoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ID4gPiAgIAl9Cj4gPiA+ ICAgCWZsYWdzID0gVkJWQV9TQ1JFRU5fRl9BQ1RJVkU7Cj4gPiA+IC0JZmxhZ3MgfD0gKGZiICYm ICF2Ym94X2NydGMtPmJsYW5rZWQpID8gMCA6IFZCVkFfU0NSRUVOX0ZfQkxBTks7Cj4gPiA+ICsJ ZmxhZ3MgfD0gKGZiICYmIGNydGMtPnN0YXRlLT5hY3RpdmUpID8gMCA6IFZCVkFfU0NSRUVOX0Zf QkxBTks7Cj4gPiA+ICAgCWZsYWdzIHw9IHZib3hfY3J0Yy0+ZGlzY29ubmVjdGVkID8gVkJWQV9T Q1JFRU5fRl9ESVNBQkxFRCA6IDA7Cj4gPiA+ICAgCWhnc21pX3Byb2Nlc3NfZGlzcGxheV9pbmZv KHZib3gtPmd1ZXN0X3Bvb2wsIHZib3hfY3J0Yy0+Y3J0Y19pZCwKPiA+ID4gICAJCQkJICAgeF9v ZmZzZXQsIHlfb2Zmc2V0LAo+ID4gPiAgIAkJCQkgICB2Ym94X2NydGMtPnggKiBicHAgLyA4ICsK PiA+ID4gICAJCQkJCQkJdmJveF9jcnRjLT55ICogcGl0Y2gsCj4gPiA+IC0JCQkJICAgcGl0Y2gs IHdpZHRoLCBoZWlnaHQsCj4gPiA+IC0JCQkJICAgdmJveF9jcnRjLT5ibGFua2VkID8gMCA6IGJw cCwgZmxhZ3MpOwo+ID4gPiArCQkJCSAgIHBpdGNoLCB3aWR0aCwgaGVpZ2h0LCBicHAsIGZsYWdz KTsKPiA+ID4gICB9Cj4gPiA+ICAgc3RhdGljIGludCB2Ym94X3NldF92aWV3KHN0cnVjdCBkcm1f Y3J0YyAqY3J0YykKPiA+ID4gQEAgLTEyOCwyNyArMTI3LDYgQEAgc3RhdGljIGludCB2Ym94X3Nl dF92aWV3KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+ID4gICAJcmV0dXJuIDA7Cj4gPiA+ICAg fQo+ID4gPiAtc3RhdGljIHZvaWQgdmJveF9jcnRjX2RwbXMoc3RydWN0IGRybV9jcnRjICpjcnRj LCBpbnQgbW9kZSkKPiA+ID4gLXsKPiA+ID4gLQlzdHJ1Y3QgdmJveF9jcnRjICp2Ym94X2NydGMg PSB0b192Ym94X2NydGMoY3J0Yyk7Cj4gPiA+IC0Jc3RydWN0IHZib3hfcHJpdmF0ZSAqdmJveCA9 IGNydGMtPmRldi0+ZGV2X3ByaXZhdGU7Cj4gPiA+IC0KPiA+ID4gLQlzd2l0Y2ggKG1vZGUpIHsK PiA+ID4gLQljYXNlIERSTV9NT0RFX0RQTVNfT046Cj4gPiA+IC0JCXZib3hfY3J0Yy0+Ymxhbmtl ZCA9IGZhbHNlOwo+ID4gPiAtCQlicmVhazsKPiA+ID4gLQljYXNlIERSTV9NT0RFX0RQTVNfU1RB TkRCWToKPiA+ID4gLQljYXNlIERSTV9NT0RFX0RQTVNfU1VTUEVORDoKPiA+ID4gLQljYXNlIERS TV9NT0RFX0RQTVNfT0ZGOgo+ID4gPiAtCQl2Ym94X2NydGMtPmJsYW5rZWQgPSB0cnVlOwo+ID4g PiAtCQlicmVhazsKPiA+ID4gLQl9Cj4gPiA+IC0KPiA+ID4gLQltdXRleF9sb2NrKCZ2Ym94LT5o d19tdXRleCk7Cj4gPiA+IC0JdmJveF9kb19tb2Rlc2V0KGNydGMpOwo+ID4gPiAtCW11dGV4X3Vu bG9jaygmdmJveC0+aHdfbXV0ZXgpOwo+ID4gPiAtfQo+ID4gPiAtCj4gPiA+ICAgLyoKPiA+ID4g ICAgKiBUcnkgdG8gbWFwIHRoZSBsYXlvdXQgb2YgdmlydHVhbCBzY3JlZW5zIHRvIHRoZSByYW5n ZSBvZiB0aGUgaW5wdXQgZGV2aWNlLgo+ID4gPiAgICAqIFJldHVybiB0cnVlIGlmIHdlIG5lZWQg dG8gcmUtc2V0IHRoZSBjcnRjIG1vZGVzIGR1ZSB0byBzY3JlZW4gb2Zmc2V0Cj4gPiA+IEBAIC0y NzYsNyArMjU0LDYgQEAgc3RhdGljIHZvaWQgdmJveF9jcnRjX2F0b21pY19mbHVzaChzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMsCj4gPiA+ICAgfQo+ID4gPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJt X2NydGNfaGVscGVyX2Z1bmNzIHZib3hfY3J0Y19oZWxwZXJfZnVuY3MgPSB7Cj4gPiA+IC0JLmRw bXMgPSB2Ym94X2NydGNfZHBtcywKPiA+ID4gICAJLmRpc2FibGUgPSB2Ym94X2NydGNfZGlzYWJs ZSwKPiA+ID4gICAJLmNvbW1pdCA9IHZib3hfY3J0Y19jb21taXQsCj4gPiA+ICAgCS5hdG9taWNf Zmx1c2ggPSB2Ym94X2NydGNfYXRvbWljX2ZsdXNoLAo+ID4gPiBAQCAtODYxLDcgKzgzOCw2IEBA IHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MgdmJveF9jb25u ZWN0b3JfaGVscGVyX2Z1bmNzID0gewo+ID4gPiAgIH07Cj4gPiA+ICAgc3RhdGljIGNvbnN0IHN0 cnVjdCBkcm1fY29ubmVjdG9yX2Z1bmNzIHZib3hfY29ubmVjdG9yX2Z1bmNzID0gewo+ID4gPiAt CS5kcG1zID0gZHJtX2hlbHBlcl9jb25uZWN0b3JfZHBtcywKPiA+ID4gICAJLmRldGVjdCA9IHZi b3hfY29ubmVjdG9yX2RldGVjdCwKPiA+ID4gICAJLmZpbGxfbW9kZXMgPSB2Ym94X2ZpbGxfbW9k ZXMsCj4gPiA+ICAgCS5kZXN0cm95ID0gdmJveF9jb25uZWN0b3JfZGVzdHJveSwKPiA+ID4gLS0g Cj4gPiA+IDIuMTkuMAo+ID4gPiAKPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiA+ID4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+ID4gPiBkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4gPiAKCi0tIApEYW5pZWwgVmV0dGVy ClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5j aApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK