From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 4/6] drm/i915/dp: Do not grab crtc modeset lock in intel_dp_detect() Date: Mon, 1 Oct 2018 23:10:06 +0300 Message-ID: <20181001201006.GP9144@intel.com> References: <20180924224528.4744-4-dhinakaran.pandiyan@intel.com> <20180926025422.2154-1-dhinakaran.pandiyan@intel.com> <20181001194828.GB12538@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6298D6E2AB for ; Mon, 1 Oct 2018 20:10:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181001194828.GB12538@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMDEsIDIwMTggYXQgMTI6NDg6MjhQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFR1ZSwgU2VwIDI1LCAyMDE4IGF0IDA3OjU0OjIyUE0gLTA3MDAsIERoaW5ha2Fy YW4gUGFuZGl5YW4gd3JvdGU6Cj4gPiBBIGNydGMgbW9kZXNldCBsb2NrIHdhcyBhZGRlZCBmb3Ig bGluayByZXRyYWluaW5nIGJ1dAo+ID4gaW50ZWxfZHBfcmV0cmFpbl9saW5rKCkga25vd3MgdG8g dGFrZSB0aGUgbmVjZXNzYXJ5IGxvY2tzIHNpbmNlCj4gPiBjb21taXQgYzg1ZDIwMGU4MzIxICgi ZHJtL2k5MTU6IE1vdmUgU1NUIERQIGxpbmsgcmV0cmFpbmluZyBpbnRvIHRoZQo+ID4gLT5wb3N0 X2hvdHBsdWcoKSBob29rIikKPiA+IHYyOiBEcm9wIEFVWCBwb3dlciBkb21haW4gcmVmZXJlbmNl IGluIHRoZSBlYXJseSByZXR1cm4gcGF0aAo+ID4gCj4gPiBGaXhlczogYzg1ZDIwMGU4MzIxICgi ZHJtL2k5MTU6IE1vdmUgU1NUIERQIGxpbmsgcmV0cmFpbmluZyBpbnRvIHRoZSAtPnBvc3RfaG90 cGx1ZygpIGhvb2siKQo+IAo+IFRoaXMgcGF0Y2ggZmFpbGVkIG9uIGNoZXJyeS1waWNrIGZvciBk cm0taW50ZWwtZml4ZXMgdGFyZ2V0aW5nIDQuMTkuCj4gCj4gSWYgaXQgc3RpbGwgbWFrZXMgc2Vu c2UgdG8gaGF2ZSBpdCB0aGVyZSBwbGVhc2UgcHJvdmlkZSBhIGJhY2twb3J0ZWQgdmVyc2lvbgo+ IHRvIGRybS1pbnRlbC1maXhlcyBvciBsZXQgbWUga25vdyBpZiBpdCBoYXMgZGVwZW5kZW5jeSBv biBvdGhlciBwYXRjaGVzPwoKVGhpcyBpcyBtb3JlIG9mIGFuIG9wdGltaXphdGlvbiB0byBub3Qg ZGlzdHVyYiBwYWdlIGZsaXBzIGFuZCB3aGF0bm90CnNvIG11Y2ggd2l0aCBkZXRlY3QuIFRoZSBk b3VibGUgbG9jayBpcyBvdGhlcndpc2UgaGFybWxlc3MgZHVlIHRvIHd3X211dGV4LgoKPiAKPiBU aGFua3MsCj4gUm9kcmlnby4KPiAKPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogRGhpbmFrYXJhbiBQYW5kaXlh biA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgMjQgKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gPiAg MSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IGluZGV4IDA5MjI5ZmM2NmRlYy4uZWYyOGNjMGYx MjJjIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gQEAgLTUwNzksOCArNTA3 OSwxNSBAQCBpbnRlbF9kcF9sb25nX3B1bHNlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5l Y3RvciwKPiA+ICAJICogU29tZSBleHRlcm5hbCBtb25pdG9ycyBkbyBub3Qgc2lnbmFsIGxvc3Mg b2YgbGluayBzeW5jaHJvbml6YXRpb24KPiA+ICAJICogd2l0aCBhbiBJUlFfSFBELCBzbyBmb3Jj ZSBhIGxpbmsgc3RhdHVzIGNoZWNrLgo+ID4gIAkgKi8KPiA+IC0JaWYgKCFpbnRlbF9kcF9pc19l ZHAoaW50ZWxfZHApKQo+ID4gLQkJaW50ZWxfZHBfcmV0cmFpbl9saW5rKGVuY29kZXIsIGN0eCk7 Cj4gPiArCWlmICghaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSkgewo+ID4gKwkJaW50IHJldDsK PiA+ICsKPiA+ICsJCXJldCA9IGludGVsX2RwX3JldHJhaW5fbGluayhlbmNvZGVyLCBjdHgpOwo+ ID4gKwkJaWYgKHJldCkgewo+ID4gKwkJCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2 LCBpbnRlbF9kcC0+YXV4X3Bvd2VyX2RvbWFpbik7Cj4gPiArCQkJcmV0dXJuIHJldDsKPiA+ICsJ CX0KPiA+ICsJfQo+ID4gIAo+ID4gIAkvKgo+ID4gIAkgKiBDbGVhcmluZyBOQUNLIGFuZCBkZWZl ciBjb3VudHMgdG8gZ2V0IHRoZWlyIGV4YWN0IHZhbHVlcwo+ID4gQEAgLTUxMzAsMTkgKzUxMzcs OCBAQCBpbnRlbF9kcF9kZXRlY3Qoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ ICAJCSAgICAgIGNvbm5lY3Rvci0+YmFzZS5pZCwgY29ubmVjdG9yLT5uYW1lKTsKPiA+ICAKPiA+ ICAJLyogSWYgZnVsbCBkZXRlY3QgaXMgbm90IHBlcmZvcm1lZCB5ZXQsIGRvIGEgZnVsbCBkZXRl Y3QgKi8KPiA+IC0JaWYgKCFpbnRlbF9kcC0+ZGV0ZWN0X2RvbmUpIHsKPiA+IC0JCXN0cnVjdCBk cm1fY3J0YyAqY3J0YzsKPiA+IC0JCWludCByZXQ7Cj4gPiAtCj4gPiAtCQljcnRjID0gY29ubmVj dG9yLT5zdGF0ZS0+Y3J0YzsKPiA+IC0JCWlmIChjcnRjKSB7Cj4gPiAtCQkJcmV0ID0gZHJtX21v ZGVzZXRfbG9jaygmY3J0Yy0+bXV0ZXgsIGN0eCk7Cj4gPiAtCQkJaWYgKHJldCkKPiA+IC0JCQkJ cmV0dXJuIHJldDsKPiA+IC0JCX0KPiA+IC0KPiA+ICsJaWYgKCFpbnRlbF9kcC0+ZGV0ZWN0X2Rv bmUpCj4gPiAgCQlzdGF0dXMgPSBpbnRlbF9kcF9sb25nX3B1bHNlKGludGVsX2RwLT5hdHRhY2hl ZF9jb25uZWN0b3IsIGN0eCk7Cj4gPiAtCX0KPiA+ICAKPiA+ICAJaW50ZWxfZHAtPmRldGVjdF9k b25lID0gZmFsc2U7Cj4gPiAgCj4gPiAtLSAKPiA+IDIuMTQuMQo+ID4gCj4gPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWls aW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBT eXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==