From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3702FC43143 for ; Tue, 2 Oct 2018 01:23:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D68BD2064A for ; Tue, 2 Oct 2018 01:23:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GjFElW5V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D68BD2064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbeJBIDo (ORCPT ); Tue, 2 Oct 2018 04:03:44 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50418 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726304AbeJBIDo (ORCPT ); Tue, 2 Oct 2018 04:03:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BhmQ1RU7SkoorF4O1yVXhhNZkjc8jQEjYybwQYhCQkI=; b=GjFElW5VTgIy5bUZJyINa57vv TCK3LEH1qCLF5sC7YooWGD1j8PlPfCBut00H2mgB6nNyqRLgGFVD0jMN/Orra5fpmqPqw+HBYsL6/ 7Jhdy2rt+IlZH0SQ6nwpX4ElLkrlolg/6pLAGpcNp1gaQkvdn7OzChkuW4wMWDtUAHOYtuZGP6aTl qBBYZG28SCCGfzARBba33BtDHgDKpIEYiQLcLh+jQj4YronLxi3K2Qwrudh+JBnKaXd6N6JOo1BIy /bCjemPE20yboFpuB/R9vc+lAWXWaoU11YERIul6O/thw5jjOUYT7iIXZZ13itMgMx439WGbtLo7R rWuywuQBQ==; Received: from [191.33.184.123] (helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1g79Ow-0007Hc-Mm; Tue, 02 Oct 2018 01:23:02 +0000 Date: Mon, 1 Oct 2018 22:22:57 -0300 From: Mauro Carvalho Chehab To: "Luck, Tony" Cc: Borislav Petkov , Russ Anderson , Greg KH , Justin Ernst , russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Aristeu Rozanski Filho Subject: Re: [PATCH] EDAC: Don't add devices under /sys/bus/edac Message-ID: <20181001222257.45e4fd59@coco.lan> In-Reply-To: <20181001224313.GA9487@agluck-desk> References: <20180926130340.6b22918b@coco.lan> <20180926161749.GI5584@zn.tnic> <20180926181035.GA1132@agluck-desk> <20180926182317.patqjso7nzw2oxiz@hpe.com> <20180926230257.GA5666@agluck-desk> <20180927045244.GA30912@zn.tnic> <20180927214400.GA2249@agluck-desk> <20180927220355.GF19687@zn.tnic> <20180927221054.580220e5@coco.lan> <20181001124754.GD7269@zn.tnic> <20181001224313.GA9487@agluck-desk> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, 1 Oct 2018 15:43:13 -0700 "Luck, Tony" escreveu: > Nobody(*) uses them. Dropping this will allow us to make the total > number of memory controllers configurable (as we won't have to > worry about duplicated device names under this directory). > > (*) https://marc.info/?l=linux-edac&m=153809709903987&w=2 > > Signed-off-by: Tony Luck > --- > > Boris: Apply this, then your earlier patch to get rid of the > hard coded limit on the number of memory controllers: > https://marc.info/?l=linux-edac&m=153797567628947&w=2 > the combination works on my 4 socket machine. Perhaps HPE > can test on their superdome. > For both this and the referred patch: Acked-by: Mauro Carvalho Chehab > drivers/edac/edac_mc_sysfs.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c > index 20374b8248f0..4c1bee59c2e6 100644 > --- a/drivers/edac/edac_mc_sysfs.c > +++ b/drivers/edac/edac_mc_sysfs.c > @@ -405,7 +405,6 @@ static int edac_create_csrow_object(struct mem_ctl_info *mci, > struct csrow_info *csrow, int index) > { > csrow->dev.type = &csrow_attr_type; > - csrow->dev.bus = mci->bus; > csrow->dev.groups = csrow_dev_groups; > device_initialize(&csrow->dev); > csrow->dev.parent = &mci->dev; > @@ -636,7 +635,6 @@ static int edac_create_dimm_object(struct mem_ctl_info *mci, > dimm->mci = mci; > > dimm->dev.type = &dimm_attr_type; > - dimm->dev.bus = mci->bus; > device_initialize(&dimm->dev); > > dimm->dev.parent = &mci->dev; > @@ -940,7 +938,6 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci, > device_initialize(&mci->dev); > > mci->dev.parent = mci_pdev; > - mci->dev.bus = mci->bus; > mci->dev.groups = groups; > dev_set_name(&mci->dev, "mc%d", mci->mc_idx); > dev_set_drvdata(&mci->dev, mci); Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: EDAC: Don't add devices under /sys/bus/edac From: Mauro Carvalho Chehab Message-Id: <20181001222257.45e4fd59@coco.lan> Date: Mon, 1 Oct 2018 22:22:57 -0300 To: "Luck, Tony" Cc: Borislav Petkov , Russ Anderson , Greg KH , Justin Ernst , russ.anderson@hpe.com, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Aristeu Rozanski Filho List-ID: RW0gTW9uLCAxIE9jdCAyMDE4IDE1OjQzOjEzIC0wNzAwCiJMdWNrLCBUb255IiA8dG9ueS5sdWNr QGludGVsLmNvbT4gZXNjcmV2ZXU6Cgo+IE5vYm9keSgqKSB1c2VzIHRoZW0uICBEcm9wcGluZyB0 aGlzIHdpbGwgYWxsb3cgdXMgdG8gbWFrZSB0aGUgdG90YWwKPiBudW1iZXIgb2YgbWVtb3J5IGNv bnRyb2xsZXJzIGNvbmZpZ3VyYWJsZSAoYXMgd2Ugd29uJ3QgaGF2ZSB0bwo+IHdvcnJ5IGFib3V0 IGR1cGxpY2F0ZWQgZGV2aWNlIG5hbWVzIHVuZGVyIHRoaXMgZGlyZWN0b3J5KS4KPiAKPiAoKikg aHR0cHM6Ly9tYXJjLmluZm8vP2w9bGludXgtZWRhYyZtPTE1MzgwOTcwOTkwMzk4NyZ3PTIKPiAK PiBTaWduZWQtb2ZmLWJ5OiBUb255IEx1Y2sgPHRvbnkubHVja0BpbnRlbC5jb20+Cj4gLS0tCj4g Cj4gQm9yaXM6IEFwcGx5IHRoaXMsIHRoZW4geW91ciBlYXJsaWVyIHBhdGNoIHRvIGdldCByaWQg b2YgdGhlCj4gaGFyZCBjb2RlZCBsaW1pdCBvbiB0aGUgbnVtYmVyIG9mIG1lbW9yeSBjb250cm9s bGVyczoKPiAgIGh0dHBzOi8vbWFyYy5pbmZvLz9sPWxpbnV4LWVkYWMmbT0xNTM3OTc1Njc2Mjg5 NDcmdz0yCj4gdGhlIGNvbWJpbmF0aW9uIHdvcmtzIG9uIG15IDQgc29ja2V0IG1hY2hpbmUuIFBl cmhhcHMgSFBFCj4gY2FuIHRlc3Qgb24gdGhlaXIgc3VwZXJkb21lLgo+IAoKRm9yIGJvdGggdGhp cyBhbmQgdGhlIHJlZmVycmVkIHBhdGNoOgoKQWNrZWQtYnk6IE1hdXJvIENhcnZhbGhvIENoZWhh YiA8bWNoZWhhYitzYW1zdW5nQGtlcm5lbC5vcmc+Cgo+ICBkcml2ZXJzL2VkYWMvZWRhY19tY19z eXNmcy5jIHwgMyAtLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZWRhYy9lZGFjX21jX3N5c2ZzLmMgYi9kcml2ZXJzL2VkYWMvZWRh Y19tY19zeXNmcy5jCj4gaW5kZXggMjAzNzRiODI0OGYwLi40YzFiZWU1OWMyZTYgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9lZGFjL2VkYWNfbWNfc3lzZnMuYwo+ICsrKyBiL2RyaXZlcnMvZWRhYy9l ZGFjX21jX3N5c2ZzLmMKPiBAQCAtNDA1LDcgKzQwNSw2IEBAIHN0YXRpYyBpbnQgZWRhY19jcmVh dGVfY3Nyb3dfb2JqZWN0KHN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSwKPiAgCQkJCSAgICBzdHJ1 Y3QgY3Nyb3dfaW5mbyAqY3Nyb3csIGludCBpbmRleCkKPiAgewo+ICAJY3Nyb3ctPmRldi50eXBl ID0gJmNzcm93X2F0dHJfdHlwZTsKPiAtCWNzcm93LT5kZXYuYnVzID0gbWNpLT5idXM7Cj4gIAlj c3Jvdy0+ZGV2Lmdyb3VwcyA9IGNzcm93X2Rldl9ncm91cHM7Cj4gIAlkZXZpY2VfaW5pdGlhbGl6 ZSgmY3Nyb3ctPmRldik7Cj4gIAljc3Jvdy0+ZGV2LnBhcmVudCA9ICZtY2ktPmRldjsKPiBAQCAt NjM2LDcgKzYzNSw2IEBAIHN0YXRpYyBpbnQgZWRhY19jcmVhdGVfZGltbV9vYmplY3Qoc3RydWN0 IG1lbV9jdGxfaW5mbyAqbWNpLAo+ICAJZGltbS0+bWNpID0gbWNpOwo+ICAKPiAgCWRpbW0tPmRl di50eXBlID0gJmRpbW1fYXR0cl90eXBlOwo+IC0JZGltbS0+ZGV2LmJ1cyA9IG1jaS0+YnVzOwo+ ICAJZGV2aWNlX2luaXRpYWxpemUoJmRpbW0tPmRldik7Cj4gIAo+ICAJZGltbS0+ZGV2LnBhcmVu dCA9ICZtY2ktPmRldjsKPiBAQCAtOTQwLDcgKzkzOCw2IEBAIGludCBlZGFjX2NyZWF0ZV9zeXNm c19tY2lfZGV2aWNlKHN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSwKPiAgCWRldmljZV9pbml0aWFs aXplKCZtY2ktPmRldik7Cj4gIAo+ICAJbWNpLT5kZXYucGFyZW50ID0gbWNpX3BkZXY7Cj4gLQlt Y2ktPmRldi5idXMgPSBtY2ktPmJ1czsKPiAgCW1jaS0+ZGV2Lmdyb3VwcyA9IGdyb3VwczsKPiAg CWRldl9zZXRfbmFtZSgmbWNpLT5kZXYsICJtYyVkIiwgbWNpLT5tY19pZHgpOwo+ICAJZGV2X3Nl dF9kcnZkYXRhKCZtY2ktPmRldiwgbWNpKTsKCgoKVGhhbmtzLApNYXVybwo=