From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/1] net: fec: fix rare tx timeout Date: Tue, 02 Oct 2018 11:28:27 -0700 (PDT) Message-ID: <20181002.112827.1288389089277001534.davem@davemloft.net> References: <20181002124932.14810-1-rickard.andersson@axis.com> <20181002124932.14810-2-rickard.andersson@axis.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: fugang.duan@nxp.com, netdev@vger.kernel.org, rickaran@axis.com To: rickard.andersson@axis.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:47886 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725951AbeJCBNK (ORCPT ); Tue, 2 Oct 2018 21:13:10 -0400 In-Reply-To: <20181002124932.14810-2-rickard.andersson@axis.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Date: Tue, 2 Oct 2018 14:49:32 +0200 > From: Rickard x Andersson > > During certain heavy network loads TX could time out > with TX ring dump. > TX is sometimes never restarted after reaching > "tx_stop_threshold" because function "fec_enet_tx_queue" > only tests the first queue. > > In addition the TX timeout callback function failed to > recover because it also operated only on the first queue. > > Signed-off-by: Rickard x Andersson Applied and queued up for -stable.