From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Mon, 1 Oct 2018 21:12:42 -0600 Subject: [U-Boot] [PATCH v2 12/17] binman: Separate out testSplBssPad() In-Reply-To: <20181002031247.93384-1-sjg@chromium.org> References: <20181002031247.93384-1-sjg@chromium.org> Message-ID: <20181002031247.93384-13-sjg@chromium.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de At present this test runs binman twice, which means that the temporary files from the first run do not get cleaned up. Split this into two tests to fix this problem. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/ftest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py index 9ef259a699b..ed787745606 100644 --- a/tools/binman/ftest.py +++ b/tools/binman/ftest.py @@ -1022,10 +1022,12 @@ class TestFunctional(unittest.TestCase): data = self._DoReadFile('47_spl_bss_pad.dts') self.assertEqual(U_BOOT_SPL_DATA + (chr(0) * 10) + U_BOOT_DATA, data) + def testSplBssPadMissing(self): + """Test that a missing symbol is detected""" with open(self.TestFile('u_boot_ucode_ptr')) as fd: TestFunctional._MakeInputFile('spl/u-boot-spl', fd.read()) with self.assertRaises(ValueError) as e: - data = self._DoReadFile('47_spl_bss_pad.dts') + self._DoReadFile('47_spl_bss_pad.dts') self.assertIn('Expected __bss_size symbol in spl/u-boot-spl', str(e.exception)) -- 2.19.0.605.g01d371f741-goog