From: Bjorn Helgaas <helgaas@kernel.org>
To: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Cc: lukas@wunner.de, linux-scsi@vger.kernel.org,
linux-pci@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Sathya Prakash <Sathya.Prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
linux-kernel@vger.kernel.org, benh@kernel.crashing.org,
ruscur@russell.cc, sbobroff@linux.ibm.com, oohall@gmail.com
Subject: Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available
Date: Tue, 2 Oct 2018 09:04:43 -0500 [thread overview]
Message-ID: <20181002140443.GA120535@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20181001204051.GD142872@bhelgaas-glaptop.roam.corp.google.com>
On Mon, Oct 01, 2018 at 03:40:51PM -0500, Bjorn Helgaas wrote:
> I think the names "pci_device_is_present()" and
> "mpt3sas_base_pci_device_is_available()" contribute to the problem
> because they make promises that can't be kept -- all we can say is
> that the device *was* present, but we know whether it is *still*
> present.
Oops, I meant "we DON'T know whether it is still present."
> I think it would be better if the interfaces were something
> like "pci_device_is_absent()" because that gives a result we can rely
> on. If that returns true, we know the device is definitely gone.
>
> Bjorn
next prev parent reply other threads:[~2018-10-02 14:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 4:22 [PATCH v4 0/6] mpt3sas: Hot-Plug Surprise removal support on IOC Suganath Prabu S
2018-09-26 4:22 ` [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available Suganath Prabu S
2018-09-26 21:32 ` Bjorn Helgaas
2018-09-27 7:03 ` Lukas Wunner
2018-09-27 18:47 ` Bjorn Helgaas
2018-09-27 19:09 ` Lukas Wunner
2018-10-01 6:57 ` Suganath Prabu Subramani
2018-10-01 20:40 ` Bjorn Helgaas
2018-10-02 14:04 ` Bjorn Helgaas [this message]
2018-10-08 6:44 ` Suganath Prabu Subramani
2018-10-12 5:47 ` Sreekanth Reddy
2018-10-12 23:43 ` Bjorn Helgaas
2018-09-26 4:22 ` [PATCH v4 2/6] mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational Suganath Prabu S
2018-09-26 21:03 ` Bjorn Helgaas
2018-09-27 10:31 ` Suganath Prabu Subramani
2018-09-26 4:22 ` [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc Suganath Prabu S
2018-09-26 21:09 ` Bjorn Helgaas
2018-10-01 7:27 ` Suganath Prabu Subramani
2018-10-01 13:40 ` Bjorn Helgaas
2018-10-08 6:47 ` Suganath Prabu Subramani
2018-09-26 21:33 ` Bjorn Helgaas
2018-09-26 4:22 ` [PATCH v4 4/6] mpt3sas: Fix Sync cache command failure during driver unload Suganath Prabu S
2018-09-26 4:22 ` [PATCH v4 5/6] mpt3sas: Fix driver modifying NVRAM/persistent data Suganath Prabu S
2018-09-26 4:22 ` [PATCH v4 6/6] mpt3sas: Bump driver version to 27.100.00.00 Suganath Prabu S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002140443.GA120535@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=Sathya.Prakash@broadcom.com \
--cc=andy.shevchenko@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=oohall@gmail.com \
--cc=ruscur@russell.cc \
--cc=sbobroff@linux.ibm.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.