All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: r8169 tx batching(?) causing performance problems
Date: Wed, 03 Oct 2018 14:43:34 -0700 (PDT)	[thread overview]
Message-ID: <20181003.144334.513463899629095170.davem@davemloft.net> (raw)
In-Reply-To: <21374.1538597980@warthog.procyon.org.uk>

From: David Howells <dhowells@redhat.com>
Date: Wed, 03 Oct 2018 21:19:40 +0100

> David Miller <davem@davemloft.net> wrote:
> 
>> Probably you are seeing some interrupt mitigation.
>> 
>> It seems there is a difference in how the interrupt mitigation is
>> programmed on for 8168 chips vs. others by default.  Most get
>> all zeros in the IntrMitigate register, whilst for 8168 chips
>> a value of 0x5151 is programmed.
> 
> I'm not sure what that means.  I can't seem to find a programmer's manual for
> the chip.

There is a comment which documents what might be the register layout
elsewhere in the driver:

	/*
	 * Undocumented corner. Supposedly:
	 * (TxTimer << 12) | (TxPackets << 8) | (RxTimer << 4) | RxPackets
	 */
	RTL_W16(tp, IntrMitigate, 0x0000);

      reply	other threads:[~2018-10-04  4:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 10:27 r8169 tx batching(?) causing performance problems David Howells
2018-10-03 15:23 ` David Howells
2018-10-03 16:31 ` David Miller
2018-10-03 20:19 ` David Howells
2018-10-03 21:43   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181003.144334.513463899629095170.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.