From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1235C00449 for ; Wed, 3 Oct 2018 11:28:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 859902098A for ; Wed, 3 Oct 2018 11:28:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 859902098A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726850AbeJCSP7 (ORCPT ); Wed, 3 Oct 2018 14:15:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:45562 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726547AbeJCSP7 (ORCPT ); Wed, 3 Oct 2018 14:15:59 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A6FE7AE83; Wed, 3 Oct 2018 11:27:59 +0000 (UTC) Date: Wed, 3 Oct 2018 13:27:58 +0200 From: Michal Hocko To: Suzuki K Poulose Cc: Anshuman Khandual , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, punit.agrawal@arm.com, will.deacon@arm.com, Steven.Price@arm.com, catalin.marinas@arm.com, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com Subject: Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration Message-ID: <20181003112758.GC4714@dhcp22.suse.cz> References: <1538482531-26883-1-git-send-email-anshuman.khandual@arm.com> <1538482531-26883-2-git-send-email-anshuman.khandual@arm.com> <835085a2-79c2-4eb5-2c10-13bb2893f611@arm.com> <789784ee-4830-753b-5d14-f5c7d90622c4@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <789784ee-4830-753b-5d14-f5c7d90622c4@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 03-10-18 12:17:52, Suzuki K Poulose wrote: [...] > I have been under the idea that all the checks at the same level could > have the same indentation. (i.e, 2 tabs in this case for each). Looks > like there is no rule about it. How about replacing it with a > switch..case ? I would simply follow the existing indentation style in that function. Is this really worth discussig, anyway? Does the proposed change makes the code harder to read? -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: mhocko@kernel.org (Michal Hocko) Date: Wed, 3 Oct 2018 13:27:58 +0200 Subject: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration In-Reply-To: <789784ee-4830-753b-5d14-f5c7d90622c4@arm.com> References: <1538482531-26883-1-git-send-email-anshuman.khandual@arm.com> <1538482531-26883-2-git-send-email-anshuman.khandual@arm.com> <835085a2-79c2-4eb5-2c10-13bb2893f611@arm.com> <789784ee-4830-753b-5d14-f5c7d90622c4@arm.com> Message-ID: <20181003112758.GC4714@dhcp22.suse.cz> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed 03-10-18 12:17:52, Suzuki K Poulose wrote: [...] > I have been under the idea that all the checks at the same level could > have the same indentation. (i.e, 2 tabs in this case for each). Looks > like there is no rule about it. How about replacing it with a > switch..case ? I would simply follow the existing indentation style in that function. Is this really worth discussig, anyway? Does the proposed change makes the code harder to read? -- Michal Hocko SUSE Labs