From: Carlos Maiolino <cmaiolino@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 1/2] xfs: Fix xqmstats offsets in /proc/fs/xfs/xqmstat
Date: Wed, 3 Oct 2018 14:35:36 +0200 [thread overview]
Message-ID: <20181003123537.30965-2-cmaiolino@redhat.com> (raw)
In-Reply-To: <20181003123537.30965-1-cmaiolino@redhat.com>
The addition of FIBT, RMAP and REFCOUNT changed the offsets into
__xfssats structure.
Although this didn't cause any direct issue, xqmstat_proc_show() relied
on the old offsets to display the xqm statistics.
Fix it.
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
fs/xfs/xfs_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c
index 4e4423153071..740ac9674848 100644
--- a/fs/xfs/xfs_stats.c
+++ b/fs/xfs/xfs_stats.c
@@ -119,7 +119,7 @@ static int xqmstat_proc_show(struct seq_file *m, void *v)
int j;
seq_printf(m, "qm");
- for (j = XFSSTAT_END_IBT_V2; j < XFSSTAT_END_XQMSTAT; j++)
+ for (j = XFSSTAT_END_REFCOUNT; j < XFSSTAT_END_XQMSTAT; j++)
seq_printf(m, " %u", counter_val(xfsstats.xs_stats, j));
seq_putc(m, '\n');
return 0;
--
2.17.1
next prev parent reply other threads:[~2018-10-03 19:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 12:35 [PATCH 0/2] xfs stats fixes Carlos Maiolino
2018-10-03 12:35 ` Carlos Maiolino [this message]
2018-10-03 12:47 ` [PATCH 1/2] xfs: Fix xqmstats offsets in /proc/fs/xfs/xqmstat Eric Sandeen
2018-10-03 13:39 ` Carlos Maiolino
2018-10-03 13:59 ` Eric Sandeen
2018-10-04 8:01 ` Carlos Maiolino
2018-10-03 15:18 ` Darrick J. Wong
2018-10-03 15:20 ` Darrick J. Wong
2018-10-03 12:35 ` [PATCH 2/2] xfs: Add new constant to mark start of xqmstat Carlos Maiolino
2018-10-03 12:51 ` Eric Sandeen
2018-10-03 14:00 ` Carlos Maiolino
2018-10-03 14:04 ` Eric Sandeen
2018-10-03 23:09 ` Dave Chinner
2018-10-10 12:37 [PATCH 0/2] xfs stats fixes - V2 Carlos Maiolino
2018-10-10 12:37 ` [PATCH 1/2] xfs: Fix xqmstats offsets in /proc/fs/xfs/xqmstat Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003123537.30965-2-cmaiolino@redhat.com \
--to=cmaiolino@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.