From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6 Date: Thu, 04 Oct 2018 21:55:07 -0700 (PDT) Message-ID: <20181004.215507.1973705600397352485.davem@davemloft.net> References: <20181005030755.31217-1-dsahern@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, weiwan@google.com, sd@queasysnail.net, xiyou.wangcong@gmail.com, dsahern@gmail.com To: dsahern@kernel.org Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:33972 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726979AbeJELwH (ORCPT ); Fri, 5 Oct 2018 07:52:07 -0400 In-Reply-To: <20181005030755.31217-1-dsahern@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Thu, 4 Oct 2018 20:07:50 -0700 > From: David Ahern > > As part of the IPv6 fib info refactoring, the intent was to make metrics > handling for ipv6 identical to ipv4. One oversight in ip6_dst_destroy > led to confusion and a couple of incomplete attempts at finding and > fixing the resulting memory leak which was ultimately resolved by > ce7ea4af0838 ("ipv6: fix memory leak on dst->_metrics"). > > Refactor metrics hanlding make the code really identical for v4 and v6, > and add a few test cases. Looks nice, series applied, thanks David.