From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:60882 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727046AbeJDNv2 (ORCPT ); Thu, 4 Oct 2018 09:51:28 -0400 Date: Thu, 4 Oct 2018 08:59:39 +0200 From: Jan Kara To: Paul Moore Cc: jack@suse.cz, rgb@redhat.com, viro@zeniv.linux.org.uk, linux-audit@redhat.com, linux-fsdevel@vger.kernel.org, amir73il@gmail.com Subject: Re: [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts Message-ID: <20181004065939.GB29482@quack2.suse.cz> References: <20180904160632.21210-1-jack@suse.cz> <20180914191328.rljpiakvk4xavrzj@madcap2.tricolour.ca> <20180917165714.GE10257@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 03-10-18 21:20:35, Paul Moore wrote: > On Mon, Sep 17, 2018 at 12:57 PM Jan Kara wrote: > > On Fri 14-09-18 15:13:28, Richard Guy Briggs wrote: > > > On 2018-09-04 18:06, Jan Kara wrote: > > > > Hello, > > > > > > Jan, > > > > > > > this is the third revision of the series that addresses problems I have > > > > identified when trying to understand how exactly is kernel/audit_tree.c using > > > > generic fsnotify framework. I hope I have understood all the interactions right > > > > but careful review is certainly welcome. > > > > > > I've tried to review it as carefully as I am able. As best I understand > > > it, this all looks reasonable and an improvement over the previous > > > state. Thanks for the hard work. > > > > > > FWIW, > > > Reviewed-by: Richard Guy Briggs > > > > Thanks for review! Paul should I send you updated patch 9 with that one > > variable renamed or will you do that small change while merging the series? > > Hi Jan, > > Thanks again for these patches and your patience; some travel, > holidays, and a job change delayed my review. However, everything > looks okay to me (minus the one problem I noted in patch 09/11). I've > added the patches to audit/working-fsnotify_fixes and I'm going to > start stressing them as soon as I get a test kernel built with the > idea of merging them into audit/next as soon as the upcoming merge > window closes. > > As far as the variable rename is concerned, that's not something I > would prefer to change during a merge, but if you or Richard wanted to > submit a renaming patch I would be okay with that in this case. If > you do submit the rename patch, please base it on top of this patchset > (or audit/working-fsnotify_fixes). Great, thanks. I will send the rename patch in a moment. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts Date: Thu, 4 Oct 2018 08:59:39 +0200 Message-ID: <20181004065939.GB29482@quack2.suse.cz> References: <20180904160632.21210-1-jack@suse.cz> <20180914191328.rljpiakvk4xavrzj@madcap2.tricolour.ca> <20180917165714.GE10257@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Paul Moore Cc: jack@suse.cz, rgb@redhat.com, amir73il@gmail.com, linux-audit@redhat.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org List-Id: linux-audit@redhat.com On Wed 03-10-18 21:20:35, Paul Moore wrote: > On Mon, Sep 17, 2018 at 12:57 PM Jan Kara wrote: > > On Fri 14-09-18 15:13:28, Richard Guy Briggs wrote: > > > On 2018-09-04 18:06, Jan Kara wrote: > > > > Hello, > > > > > > Jan, > > > > > > > this is the third revision of the series that addresses problems I have > > > > identified when trying to understand how exactly is kernel/audit_tree.c using > > > > generic fsnotify framework. I hope I have understood all the interactions right > > > > but careful review is certainly welcome. > > > > > > I've tried to review it as carefully as I am able. As best I understand > > > it, this all looks reasonable and an improvement over the previous > > > state. Thanks for the hard work. > > > > > > FWIW, > > > Reviewed-by: Richard Guy Briggs > > > > Thanks for review! Paul should I send you updated patch 9 with that one > > variable renamed or will you do that small change while merging the series? > > Hi Jan, > > Thanks again for these patches and your patience; some travel, > holidays, and a job change delayed my review. However, everything > looks okay to me (minus the one problem I noted in patch 09/11). I've > added the patches to audit/working-fsnotify_fixes and I'm going to > start stressing them as soon as I get a test kernel built with the > idea of merging them into audit/next as soon as the upcoming merge > window closes. > > As far as the variable rename is concerned, that's not something I > would prefer to change during a merge, but if you or Richard wanted to > submit a renaming patch I would be okay with that in this case. If > you do submit the rename patch, please base it on top of this patchset > (or audit/working-fsnotify_fixes). Great, thanks. I will send the rename patch in a moment. Honza -- Jan Kara SUSE Labs, CR