From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Sitnicki Subject: [PATCH net-next] socket: Tighten no-error check in bind() Date: Thu, 4 Oct 2018 11:09:40 +0200 Message-ID: <20181004090940.4002-1-jakub@cloudflare.com> To: netdev@vger.kernel.org Return-path: Received: from mail-lj1-f194.google.com ([209.85.208.194]:33451 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726949AbeJDQCD (ORCPT ); Thu, 4 Oct 2018 12:02:03 -0400 Received: by mail-lj1-f194.google.com with SMTP id z21-v6so7698137ljz.0 for ; Thu, 04 Oct 2018 02:09:43 -0700 (PDT) Received: from cloudflare.com ([176.221.114.230]) by smtp.gmail.com with ESMTPSA id p1-v6sm853844ljc.85.2018.10.04.02.09.41 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Oct 2018 02:09:41 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: move_addr_to_kernel() returns only negative values on error, or zero on success. Rewrite the error check to an idiomatic form to avoid confusing the reader. Signed-off-by: Jakub Sitnicki --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/socket.c b/net/socket.c index 01f3f8f32d6f..713dc4833d40 100644 --- a/net/socket.c +++ b/net/socket.c @@ -1475,7 +1475,7 @@ int __sys_bind(int fd, struct sockaddr __user *umyaddr, int addrlen) sock = sockfd_lookup_light(fd, &err, &fput_needed); if (sock) { err = move_addr_to_kernel(umyaddr, addrlen, &address); - if (err >= 0) { + if (!err) { err = security_socket_bind(sock, (struct sockaddr *)&address, addrlen); -- 2.17.1