From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Jie Yang <yang.jie@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Bard Liao <bardliao@realtek.com>
Subject: [PATCH 3/5] ASoC: rt274: Add fall-through annotations
Date: Thu, 4 Oct 2018 20:30:04 +0200 [thread overview]
Message-ID: <20181004183006.23983-4-tiwai@suse.de> (raw)
In-Reply-To: <20181004183006.23983-1-tiwai@suse.de>
As a preparatory patch for the upcoming -Wimplicit-fallthrough
compiler checks, add the "fall through" annotations in rt274 driver.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/codecs/rt274.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c
index d88e67341083..0ef966d56bac 100644
--- a/sound/soc/codecs/rt274.c
+++ b/sound/soc/codecs/rt274.c
@@ -755,6 +755,7 @@ static int rt274_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
break;
default:
dev_warn(component->dev, "invalid pll source, use BCLK\n");
+ /* fall through */
case RT274_PLL2_S_BCLK:
snd_soc_component_update_bits(component, RT274_PLL2_CTRL,
RT274_PLL2_SRC_MASK, RT274_PLL2_SRC_BCLK);
@@ -782,6 +783,7 @@ static int rt274_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
break;
default:
dev_warn(component->dev, "invalid freq_in, assume 4.8M\n");
+ /* fall through */
case 100:
snd_soc_component_write(component, 0x7a, 0xaab6);
snd_soc_component_write(component, 0x7b, 0x0301);
--
2.18.0
next prev parent reply other threads:[~2018-10-04 18:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 18:30 [PATCH 0/5] ASoC: Fix fall-through annotations Takashi Iwai
2018-10-04 18:30 ` [PATCH 1/5] ASoC: adau1761: Use the standard fall-through annotation Takashi Iwai
2018-10-04 18:34 ` Lars-Peter Clausen
2018-10-04 18:39 ` Takashi Iwai
2018-10-05 11:42 ` Mark Brown
2018-10-04 18:30 ` [PATCH 2/5] ASoC: pcm186x: " Takashi Iwai
2018-10-05 13:26 ` Applied "ASoC: pcm186x: Use the standard fall-through annotation" to the asoc tree Mark Brown
2018-10-04 18:30 ` Takashi Iwai [this message]
2018-10-05 13:26 ` Applied "ASoC: rt274: Add fall-through annotations" " Mark Brown
2018-10-04 18:30 ` [PATCH 4/5] ASoC: intel: skylake: Add fall-through annotation Takashi Iwai
2018-10-04 18:30 ` [PATCH 5/5] ASoC: topology: Use the standard fall-through annotations Takashi Iwai
2018-10-05 13:25 ` Applied "ASoC: topology: Use the standard fall-through annotations" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004183006.23983-4-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.