From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH rfc 2/3] nvme: enable aen also for discovery controllers
Date: Thu, 4 Oct 2018 14:23:25 -0700 [thread overview]
Message-ID: <20181004212328.30205-3-sagi@grimberg.me> (raw)
In-Reply-To: <20181004212328.30205-1-sagi@grimberg.me>
If the controller supports discovery log page change events,
we want to enable it on the host side as well.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/host/core.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index de745f94b698..efdbfc07de32 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1089,6 +1089,8 @@ static void nvme_enable_aen(struct nvme_ctrl *ctrl)
if (!supported_aens)
return;
+ queue_work(nvme_wq, &ctrl->async_event_work);
+
status = nvme_set_features(ctrl, NVME_FEAT_ASYNC_EVENT, supported_aens,
NULL, 0, &result);
if (status)
@@ -3489,10 +3491,13 @@ void nvme_start_ctrl(struct nvme_ctrl *ctrl)
if (ctrl->kato)
nvme_start_keep_alive(ctrl);
+ if (ctrl->queue_count > 1 ||
+ (ctrl->ops->flags & NVME_F_FABRICS &&
+ ctrl->opts->discovery_nqn))
+ nvme_enable_aen(ctrl);
+
if (ctrl->queue_count > 1) {
nvme_queue_scan(ctrl);
- nvme_enable_aen(ctrl);
- queue_work(nvme_wq, &ctrl->async_event_work);
nvme_start_queues(ctrl);
}
}
--
2.17.1
next prev parent reply other threads:[~2018-10-04 21:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 21:23 [PATCH rfc 0/3] add support to discovery async event notifications Sagi Grimberg
2018-10-04 21:23 ` [PATCH rfc 1/3] nvme-fabrics: allow discovery subsystems accept a kato Sagi Grimberg
2018-10-05 5:50 ` Hannes Reinecke
2018-10-04 21:23 ` Sagi Grimberg [this message]
2018-10-05 5:51 ` [PATCH rfc 2/3] nvme: enable aen also for discovery controllers Hannes Reinecke
2018-10-04 21:23 ` [PATCH rfc 3/3] nvme: fire discovery log page change events to userspace Sagi Grimberg
2018-10-05 5:51 ` Hannes Reinecke
2018-10-04 21:23 ` [PATCH 4/3 rfc nvme-cli] fabrics: support persistent connections to a discovery controller Sagi Grimberg
2018-10-04 21:23 ` [PATCH 5/3 rfc nvme-cli] fabrics: allow user to retrieve discovery log from existing " Sagi Grimberg
2018-10-05 5:50 ` [PATCH rfc 0/3] add support to discovery async event notifications Hannes Reinecke
2018-10-05 7:08 ` Sagi Grimberg
2018-10-05 7:36 ` Hannes Reinecke
2018-10-05 19:34 ` Sagi Grimberg
2018-10-16 1:11 ` Sagi Grimberg
2018-10-16 5:59 ` Hannes Reinecke
2018-10-16 17:59 ` James Smart
2018-10-17 15:29 ` Hannes Reinecke
2018-10-19 0:44 ` Sagi Grimberg
2018-10-19 16:09 ` James Smart
2018-10-17 0:38 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004212328.30205-3-sagi@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.