From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ipv6: do not leave garbage in rt->fib6_metrics Date: Fri, 05 Oct 2018 11:57:32 -0700 (PDT) Message-ID: <20181005.115732.771251816122036025.davem@davemloft.net> References: <20181005161750.179275-1-edumazet@google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, dsahern@gmail.com To: edumazet@google.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:44478 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729116AbeJFB5f (ORCPT ); Fri, 5 Oct 2018 21:57:35 -0400 In-Reply-To: <20181005161750.179275-1-edumazet@google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Fri, 5 Oct 2018 09:17:50 -0700 > In case ip_fib_metrics_init() returns an error, we better > rewrite rt->fib6_metrics with &dst_default_metrics so that > we do not crash later in ip_fib_metrics_put() > > Fixes: 767a2217533f ("net: common metrics init helper for FIB entries") > Signed-off-by: Eric Dumazet > Reported-by: syzbot Applied to net-next, thanks Eric. Subject should have said net-next instead of net btw.