From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH 2/3] crypto: add output feedback mode Date: Fri, 5 Oct 2018 10:31:38 +0800 Message-ID: <20181005023138.dg22cn4salb3p6zl@gondor.apana.org.au> References: <1537449521-16182-1-git-send-email-gilad@benyossef.com> <1537449521-16182-3-git-send-email-gilad@benyossef.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gilad Ben-Yossef , "David S. Miller" , ofir.drang@arm.com, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Linux Kernel Mailing List To: Ard Biesheuvel Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Fri, Sep 28, 2018 at 12:06:29PM +0200, Ard Biesheuvel wrote: > On 20 September 2018 at 15:18, Gilad Ben-Yossef wrote: > > Add a generic version of output feedback mode. We already have support of > > several hardware based transformations of this mode and the needed test > > vectors but we somehow missed adding a generic software one. Fix this now. > > > > Signed-off-by: Gilad Ben-Yossef > > I couldn't find any users of OFB in the kernel. Any idea who is using > it and for what? Yes this shouldn't have been accepted however the driver did go in with OFB and it's been there for a while so that's why I'm making this exception. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42AF0C64EB8 for ; Fri, 5 Oct 2018 02:31:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2A8B2064E for ; Fri, 5 Oct 2018 02:31:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2A8B2064E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727444AbeJEJ2T (ORCPT ); Fri, 5 Oct 2018 05:28:19 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:55748 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726865AbeJEJ2S (ORCPT ); Fri, 5 Oct 2018 05:28:18 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1g8Fu0-0007Kn-V8; Fri, 05 Oct 2018 10:31:41 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1g8Fty-00016g-GP; Fri, 05 Oct 2018 10:31:38 +0800 Date: Fri, 5 Oct 2018 10:31:38 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: Gilad Ben-Yossef , "David S. Miller" , ofir.drang@arm.com, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Linux Kernel Mailing List Subject: Re: [PATCH 2/3] crypto: add output feedback mode Message-ID: <20181005023138.dg22cn4salb3p6zl@gondor.apana.org.au> References: <1537449521-16182-1-git-send-email-gilad@benyossef.com> <1537449521-16182-3-git-send-email-gilad@benyossef.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2018 at 12:06:29PM +0200, Ard Biesheuvel wrote: > On 20 September 2018 at 15:18, Gilad Ben-Yossef wrote: > > Add a generic version of output feedback mode. We already have support of > > several hardware based transformations of this mode and the needed test > > vectors but we somehow missed adding a generic software one. Fix this now. > > > > Signed-off-by: Gilad Ben-Yossef > > I couldn't find any users of OFB in the kernel. Any idea who is using > it and for what? Yes this shouldn't have been accepted however the driver did go in with OFB and it's been there for a while so that's why I'm making this exception. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt