All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915: Warn if request allocation stalls
@ 2018-10-05  8:02 Chris Wilson
  2018-10-05  8:03 ` [PATCH 2/2] drm/i915: Remove the global cache shrink & rcu barrier on allocation failure Chris Wilson
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Chris Wilson @ 2018-10-05  8:02 UTC (permalink / raw)
  To: intel-gfx

Add a warning for an allocation stall to make it painfully more obvious
while debugging.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem.h     | 2 ++
 drivers/gpu/drm/i915/i915_request.c | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h
index 599c4f6eb1ea..e2db030fd75a 100644
--- a/drivers/gpu/drm/i915/i915_gem.h
+++ b/drivers/gpu/drm/i915/i915_gem.h
@@ -47,6 +47,7 @@ struct drm_i915_private;
 #define GEM_DEBUG_DECL(var) var
 #define GEM_DEBUG_EXEC(expr) expr
 #define GEM_DEBUG_BUG_ON(expr) GEM_BUG_ON(expr)
+#define GEM_DEBUG_WARN(expr...) WARN(expr)
 
 #else
 
@@ -58,6 +59,7 @@ struct drm_i915_private;
 #define GEM_DEBUG_DECL(var)
 #define GEM_DEBUG_EXEC(expr) do { } while (0)
 #define GEM_DEBUG_BUG_ON(expr)
+#define GEM_DEBUG_WARN(expr...) do { } while (0)
 #endif
 
 #if IS_ENABLED(CONFIG_DRM_I915_TRACE_GEM)
diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index abd4dacbab8e..32bf2c9868bf 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -647,6 +647,8 @@ i915_request_alloc(struct intel_engine_cs *engine, struct i915_gem_context *ctx)
 	rq = kmem_cache_alloc(i915->requests,
 			      GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_NOWARN);
 	if (unlikely(!rq)) {
+		GEM_DEBUG_DECL(ktime_t start = ktime_get());
+
 		i915_retire_requests(i915);
 
 		/* Ratelimit ourselves to prevent oom from malicious clients */
@@ -671,6 +673,10 @@ i915_request_alloc(struct intel_engine_cs *engine, struct i915_gem_context *ctx)
 			ret = -ENOMEM;
 			goto err_unreserve;
 		}
+
+		GEM_DEBUG_WARN(ktime_ms_delta(ktime_get(), start) > 500,
+			       "request allocation delayed for %lldms\n",
+			       ktime_ms_delta(ktime_get(), start));
 	}
 
 	rq->rcustate = get_state_synchronize_rcu();
-- 
2.19.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] drm/i915: Remove the global cache shrink & rcu barrier on allocation failure
  2018-10-05  8:02 [PATCH 1/2] drm/i915: Warn if request allocation stalls Chris Wilson
@ 2018-10-05  8:03 ` Chris Wilson
  2018-10-05  8:39   ` Tvrtko Ursulin
  2018-10-05  8:37 ` [PATCH 1/2] drm/i915: Warn if request allocation stalls Tvrtko Ursulin
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2018-10-05  8:03 UTC (permalink / raw)
  To: intel-gfx

Earlier, we reasoned that having idled the gpu under mempressure, that
would be a good time to trim our request slabs in order to perform the
next request allocation. We have stopped performing the global operation
on the device (no idling) and wish to make the allocation failure
handling more local, so out with the global barrier that may take a long
time.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_request.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 32bf2c9868bf..c5e40e5f0e65 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -657,17 +657,6 @@ i915_request_alloc(struct intel_engine_cs *engine, struct i915_gem_context *ctx)
 		if (rq)
 			cond_synchronize_rcu(rq->rcustate);
 
-		/*
-		 * We've forced the client to stall and catch up with whatever
-		 * backlog there might have been. As we are assuming that we
-		 * caused the mempressure, now is an opportune time to
-		 * recover as much memory from the request pool as is possible.
-		 * Having already penalized the client to stall, we spend
-		 * a little extra time to re-optimise page allocation.
-		 */
-		kmem_cache_shrink(i915->requests);
-		rcu_barrier(); /* Recover the TYPESAFE_BY_RCU pages */
-
 		rq = kmem_cache_alloc(i915->requests, GFP_KERNEL);
 		if (!rq) {
 			ret = -ENOMEM;
-- 
2.19.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] drm/i915: Warn if request allocation stalls
  2018-10-05  8:02 [PATCH 1/2] drm/i915: Warn if request allocation stalls Chris Wilson
  2018-10-05  8:03 ` [PATCH 2/2] drm/i915: Remove the global cache shrink & rcu barrier on allocation failure Chris Wilson
@ 2018-10-05  8:37 ` Tvrtko Ursulin
  2018-10-05  9:31   ` Chris Wilson
  2018-10-05  8:50 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
  2018-10-05 11:17 ` ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 1 reply; 8+ messages in thread
From: Tvrtko Ursulin @ 2018-10-05  8:37 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx


On 05/10/2018 09:02, Chris Wilson wrote:
> Add a warning for an allocation stall to make it painfully more obvious
> while debugging.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/i915_gem.h     | 2 ++
>   drivers/gpu/drm/i915/i915_request.c | 6 ++++++
>   2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h
> index 599c4f6eb1ea..e2db030fd75a 100644
> --- a/drivers/gpu/drm/i915/i915_gem.h
> +++ b/drivers/gpu/drm/i915/i915_gem.h
> @@ -47,6 +47,7 @@ struct drm_i915_private;
>   #define GEM_DEBUG_DECL(var) var
>   #define GEM_DEBUG_EXEC(expr) expr
>   #define GEM_DEBUG_BUG_ON(expr) GEM_BUG_ON(expr)
> +#define GEM_DEBUG_WARN(expr...) WARN(expr)

Reminds me of one patch which would look so good preceding this one!

>   
>   #else
>   
> @@ -58,6 +59,7 @@ struct drm_i915_private;
>   #define GEM_DEBUG_DECL(var)
>   #define GEM_DEBUG_EXEC(expr) do { } while (0)
>   #define GEM_DEBUG_BUG_ON(expr)
> +#define GEM_DEBUG_WARN(expr...) do { } while (0)
>   #endif
>   
>   #if IS_ENABLED(CONFIG_DRM_I915_TRACE_GEM)
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index abd4dacbab8e..32bf2c9868bf 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -647,6 +647,8 @@ i915_request_alloc(struct intel_engine_cs *engine, struct i915_gem_context *ctx)
>   	rq = kmem_cache_alloc(i915->requests,
>   			      GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_NOWARN);
>   	if (unlikely(!rq)) {
> +		GEM_DEBUG_DECL(ktime_t start = ktime_get());
> +
>   		i915_retire_requests(i915);
>   
>   		/* Ratelimit ourselves to prevent oom from malicious clients */
> @@ -671,6 +673,10 @@ i915_request_alloc(struct intel_engine_cs *engine, struct i915_gem_context *ctx)
>   			ret = -ENOMEM;
>   			goto err_unreserve;
>   		}
> +
> +		GEM_DEBUG_WARN(ktime_ms_delta(ktime_get(), start) > 500,
> +			       "request allocation delayed for %lldms\n",
> +			       ktime_ms_delta(ktime_get(), start));

Usefulness of the arbitrary threshold vs source code pollution?

Regards,

Tvrtko

>   	}
>   
>   	rq->rcustate = get_state_synchronize_rcu();
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] drm/i915: Remove the global cache shrink & rcu barrier on allocation failure
  2018-10-05  8:03 ` [PATCH 2/2] drm/i915: Remove the global cache shrink & rcu barrier on allocation failure Chris Wilson
@ 2018-10-05  8:39   ` Tvrtko Ursulin
  2018-10-05  9:16     ` Chris Wilson
  0 siblings, 1 reply; 8+ messages in thread
From: Tvrtko Ursulin @ 2018-10-05  8:39 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx


On 05/10/2018 09:03, Chris Wilson wrote:
> Earlier, we reasoned that having idled the gpu under mempressure, that
> would be a good time to trim our request slabs in order to perform the
> next request allocation. We have stopped performing the global operation
> on the device (no idling) and wish to make the allocation failure
> handling more local, so out with the global barrier that may take a long
> time.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_request.c | 11 -----------
>   1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index 32bf2c9868bf..c5e40e5f0e65 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -657,17 +657,6 @@ i915_request_alloc(struct intel_engine_cs *engine, struct i915_gem_context *ctx)
>   		if (rq)
>   			cond_synchronize_rcu(rq->rcustate);
>   
> -		/*
> -		 * We've forced the client to stall and catch up with whatever
> -		 * backlog there might have been. As we are assuming that we
> -		 * caused the mempressure, now is an opportune time to
> -		 * recover as much memory from the request pool as is possible.
> -		 * Having already penalized the client to stall, we spend
> -		 * a little extra time to re-optimise page allocation.
> -		 */
> -		kmem_cache_shrink(i915->requests);
> -		rcu_barrier(); /* Recover the TYPESAFE_BY_RCU pages */
> -
>   		rq = kmem_cache_alloc(i915->requests, GFP_KERNEL);
>   		if (!rq) {
>   			ret = -ENOMEM;
> 

Wish I was in space...
.
.
.
.
...so no one could hear me scream! :))

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Warn if request allocation stalls
  2018-10-05  8:02 [PATCH 1/2] drm/i915: Warn if request allocation stalls Chris Wilson
  2018-10-05  8:03 ` [PATCH 2/2] drm/i915: Remove the global cache shrink & rcu barrier on allocation failure Chris Wilson
  2018-10-05  8:37 ` [PATCH 1/2] drm/i915: Warn if request allocation stalls Tvrtko Ursulin
@ 2018-10-05  8:50 ` Patchwork
  2018-10-05 11:17 ` ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-10-05  8:50 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915: Warn if request allocation stalls
URL   : https://patchwork.freedesktop.org/series/50601/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4933 -> Patchwork_10373 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50601/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_10373 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       PASS -> DMESG-WARN (fdo#105128, fdo#107139)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_psr@sprite_plane_onoff:
      fi-bdw-samus:       NOTRUN -> FAIL (fdo#107383, fdo#107360)

    igt@pm_rpm@module-reload:
      fi-bdw-samus:       NOTRUN -> DMESG-WARN (fdo#107603)

    
  fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
  fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
  fdo#107360 https://bugs.freedesktop.org/show_bug.cgi?id=107360
  fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718


== Participating hosts (44 -> 39) ==

  Additional (2): fi-glk-j4005 fi-bdw-samus 
  Missing    (7): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-ctg-p8600 fi-byt-clapper fi-kbl-r 


== Build changes ==

    * Linux: CI_DRM_4933 -> Patchwork_10373

  CI_DRM_4933: 6b7a44d1597791524f46d7ea17620db54dffdc8c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4669: 5f40e617cd9c1e089f4a2d79c53a417d891e3e3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10373: 2c8b2257e93d225c4e95eca327aed3607c40e941 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

2c8b2257e93d drm/i915: Remove the global cache shrink & rcu barrier on allocation failure
4167aa808941 drm/i915: Warn if request allocation stalls

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10373/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] drm/i915: Remove the global cache shrink & rcu barrier on allocation failure
  2018-10-05  8:39   ` Tvrtko Ursulin
@ 2018-10-05  9:16     ` Chris Wilson
  0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-10-05  9:16 UTC (permalink / raw)
  To: Tvrtko Ursulin, intel-gfx

Quoting Tvrtko Ursulin (2018-10-05 09:39:45)
> 
> On 05/10/2018 09:03, Chris Wilson wrote:
> > Earlier, we reasoned that having idled the gpu under mempressure, that
> > would be a good time to trim our request slabs in order to perform the
> > next request allocation. We have stopped performing the global operation
> > on the device (no idling) and wish to make the allocation failure
> > handling more local, so out with the global barrier that may take a long
> > time.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> >   drivers/gpu/drm/i915/i915_request.c | 11 -----------
> >   1 file changed, 11 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> > index 32bf2c9868bf..c5e40e5f0e65 100644
> > --- a/drivers/gpu/drm/i915/i915_request.c
> > +++ b/drivers/gpu/drm/i915/i915_request.c
> > @@ -657,17 +657,6 @@ i915_request_alloc(struct intel_engine_cs *engine, struct i915_gem_context *ctx)
> >               if (rq)
> >                       cond_synchronize_rcu(rq->rcustate);
> >   
> > -             /*
> > -              * We've forced the client to stall and catch up with whatever
> > -              * backlog there might have been. As we are assuming that we
> > -              * caused the mempressure, now is an opportune time to
> > -              * recover as much memory from the request pool as is possible.
> > -              * Having already penalized the client to stall, we spend
> > -              * a little extra time to re-optimise page allocation.
> > -              */
> > -             kmem_cache_shrink(i915->requests);
> > -             rcu_barrier(); /* Recover the TYPESAFE_BY_RCU pages */
> > -
> >               rq = kmem_cache_alloc(i915->requests, GFP_KERNEL);
> >               if (!rq) {
> >                       ret = -ENOMEM;
> > 
> 
> Wish I was in space...
> .
> .
> .
> .
> ...so no one could hear me scream! :))

I did say I was going to phase it out. I still suspect we need a
cond_synchronize_rcu_expedited(), and the kmem_cache_alloc() may itself
stall for umpteen seconds. But I hope never for igt.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] drm/i915: Warn if request allocation stalls
  2018-10-05  8:37 ` [PATCH 1/2] drm/i915: Warn if request allocation stalls Tvrtko Ursulin
@ 2018-10-05  9:31   ` Chris Wilson
  0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-10-05  9:31 UTC (permalink / raw)
  To: Tvrtko Ursulin, intel-gfx

Quoting Tvrtko Ursulin (2018-10-05 09:37:37)
> 
> On 05/10/2018 09:02, Chris Wilson wrote:
> > Add a warning for an allocation stall to make it painfully more obvious
> > while debugging.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >   drivers/gpu/drm/i915/i915_gem.h     | 2 ++
> >   drivers/gpu/drm/i915/i915_request.c | 6 ++++++
> >   2 files changed, 8 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h
> > index 599c4f6eb1ea..e2db030fd75a 100644
> > --- a/drivers/gpu/drm/i915/i915_gem.h
> > +++ b/drivers/gpu/drm/i915/i915_gem.h
> > @@ -47,6 +47,7 @@ struct drm_i915_private;
> >   #define GEM_DEBUG_DECL(var) var
> >   #define GEM_DEBUG_EXEC(expr) expr
> >   #define GEM_DEBUG_BUG_ON(expr) GEM_BUG_ON(expr)
> > +#define GEM_DEBUG_WARN(expr...) WARN(expr)
> 
> Reminds me of one patch which would look so good preceding this one!
> 
> >   
> >   #else
> >   
> > @@ -58,6 +59,7 @@ struct drm_i915_private;
> >   #define GEM_DEBUG_DECL(var)
> >   #define GEM_DEBUG_EXEC(expr) do { } while (0)
> >   #define GEM_DEBUG_BUG_ON(expr)
> > +#define GEM_DEBUG_WARN(expr...) do { } while (0)
> >   #endif
> >   
> >   #if IS_ENABLED(CONFIG_DRM_I915_TRACE_GEM)
> > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> > index abd4dacbab8e..32bf2c9868bf 100644
> > --- a/drivers/gpu/drm/i915/i915_request.c
> > +++ b/drivers/gpu/drm/i915/i915_request.c
> > @@ -647,6 +647,8 @@ i915_request_alloc(struct intel_engine_cs *engine, struct i915_gem_context *ctx)
> >       rq = kmem_cache_alloc(i915->requests,
> >                             GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_NOWARN);
> >       if (unlikely(!rq)) {
> > +             GEM_DEBUG_DECL(ktime_t start = ktime_get());
> > +
> >               i915_retire_requests(i915);
> >   
> >               /* Ratelimit ourselves to prevent oom from malicious clients */
> > @@ -671,6 +673,10 @@ i915_request_alloc(struct intel_engine_cs *engine, struct i915_gem_context *ctx)
> >                       ret = -ENOMEM;
> >                       goto err_unreserve;
> >               }
> > +
> > +             GEM_DEBUG_WARN(ktime_ms_delta(ktime_get(), start) > 500,
> > +                            "request allocation delayed for %lldms\n",
> > +                            ktime_ms_delta(ktime_get(), start));
> 
> Usefulness of the arbitrary threshold vs source code pollution?

I'm just trying to prove that the hang is here, so purely for debugging
purposes.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Warn if request allocation stalls
  2018-10-05  8:02 [PATCH 1/2] drm/i915: Warn if request allocation stalls Chris Wilson
                   ` (2 preceding siblings ...)
  2018-10-05  8:50 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
@ 2018-10-05 11:17 ` Patchwork
  3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-10-05 11:17 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915: Warn if request allocation stalls
URL   : https://patchwork.freedesktop.org/series/50601/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4933_full -> Patchwork_10373_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_10373_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_10373_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_10373_full:

  === IGT changes ===

    ==== Warnings ====

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in Patchwork_10373_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106886)

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-skl:          NOTRUN -> TIMEOUT (fdo#108039)

    igt@gem_userptr_blits@readonly-unsync:
      shard-skl:          PASS -> INCOMPLETE (fdo#108074)

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
      shard-skl:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_busy@extended-pageflip-hang-newfb-render-a:
      shard-apl:          PASS -> DMESG-WARN (fdo#107956)

    igt@kms_color@pipe-a-ctm-max:
      shard-apl:          PASS -> FAIL (fdo#108147)

    igt@kms_cursor_crc@cursor-256x256-onscreen:
      shard-glk:          PASS -> FAIL (fdo#103232)

    igt@kms_cursor_crc@cursor-256x256-suspend:
      shard-skl:          PASS -> INCOMPLETE (fdo#104108)

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105363)

    igt@kms_flip@plain-flip-fb-recreate:
      shard-skl:          PASS -> FAIL (fdo#100368)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
      shard-apl:          PASS -> FAIL (fdo#103167) +3

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-skl:          NOTRUN -> DMESG-WARN (fdo#106885)

    {igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb}:
      shard-apl:          PASS -> FAIL (fdo#108145)

    {igt@kms_plane_alpha_blend@pipe-a-alpha-transparant-fb}:
      shard-skl:          NOTRUN -> FAIL (fdo#108145) +1

    {igt@kms_plane_alpha_blend@pipe-b-coverage-7efc}:
      shard-skl:          NOTRUN -> FAIL (fdo#108146)

    igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
      shard-apl:          PASS -> FAIL (fdo#103166) +3

    igt@kms_rotation_crc@exhaust-fences:
      shard-skl:          NOTRUN -> DMESG-WARN (fdo#105748)

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    igt@kms_sysfs_edid_timing:
      shard-skl:          NOTRUN -> FAIL (fdo#100047)

    
    ==== Possible fixes ====

    igt@gem_cpu_reloc@full:
      shard-skl:          INCOMPLETE (fdo#108073) -> PASS

    igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-b:
      shard-apl:          DMESG-WARN (fdo#103558, fdo#105602) -> PASS +1

    igt@kms_cursor_crc@cursor-128x128-suspend:
      shard-glk:          FAIL (fdo#103232) -> PASS +2
      shard-apl:          FAIL (fdo#103191, fdo#103232) -> PASS

    igt@kms_cursor_crc@cursor-64x64-random:
      shard-apl:          FAIL (fdo#103232) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
      shard-glk:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
      shard-apl:          FAIL (fdo#103167) -> PASS

    igt@kms_plane@plane-position-covered-pipe-b-planes:
      shard-apl:          FAIL (fdo#103166) -> PASS

    {igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb}:
      shard-glk:          FAIL (fdo#108145) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-glk:          DMESG-WARN (fdo#106538, fdo#105763) -> PASS +2

    igt@pm_rpm@pm-tiling:
      shard-skl:          INCOMPLETE (fdo#107807) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105748 https://bugs.freedesktop.org/show_bug.cgi?id=105748
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
  fdo#108073 https://bugs.freedesktop.org/show_bug.cgi?id=108073
  fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108146 https://bugs.freedesktop.org/show_bug.cgi?id=108146
  fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (6 -> 6) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4933 -> Patchwork_10373

  CI_DRM_4933: 6b7a44d1597791524f46d7ea17620db54dffdc8c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4669: 5f40e617cd9c1e089f4a2d79c53a417d891e3e3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10373: 2c8b2257e93d225c4e95eca327aed3607c40e941 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10373/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-10-05 11:17 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05  8:02 [PATCH 1/2] drm/i915: Warn if request allocation stalls Chris Wilson
2018-10-05  8:03 ` [PATCH 2/2] drm/i915: Remove the global cache shrink & rcu barrier on allocation failure Chris Wilson
2018-10-05  8:39   ` Tvrtko Ursulin
2018-10-05  9:16     ` Chris Wilson
2018-10-05  8:37 ` [PATCH 1/2] drm/i915: Warn if request allocation stalls Tvrtko Ursulin
2018-10-05  9:31   ` Chris Wilson
2018-10-05  8:50 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2018-10-05 11:17 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.