All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] b43: remove set but not used variable 'wl'
@ 2018-10-05  4:15 ` YueHaibing
  0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2018-10-05  4:15 UTC (permalink / raw)
  To: Kalle Valo, Colin Ian King
  Cc: YueHaibing, linux-wireless, b43-dev, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/broadcom/b43/main.c: In function 'b43_one_core_detach':
drivers/net/wireless/broadcom/b43/main.c:5496:17: warning:
 variable 'wl' set but not used [-Wunused-but-set-variable]
 
After commit 644aa4d62096 ("b43: remove list of IEEE 802.11 devices")
'wl' is not used any more.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/wireless/broadcom/b43/main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
index 4daa1ce..74be3c8 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -5493,13 +5493,11 @@ static int b43_wireless_core_attach(struct b43_wldev *dev)
 static void b43_one_core_detach(struct b43_bus_dev *dev)
 {
 	struct b43_wldev *wldev;
-	struct b43_wl *wl;
 
 	/* Do not cancel ieee80211-workqueue based work here.
 	 * See comment in b43_remove(). */
 
 	wldev = b43_bus_get_wldev(dev);
-	wl = wldev->wl;
 	b43_debugfs_remove_device(wldev);
 	b43_wireless_core_detach(wldev);
 	list_del(&wldev->list);


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] b43: remove set but not used variable 'wl'
@ 2018-10-05  4:15 ` YueHaibing
  0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2018-10-05  4:15 UTC (permalink / raw)
  To: Kalle Valo, Colin Ian King
  Cc: YueHaibing, linux-wireless, b43-dev, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/broadcom/b43/main.c: In function 'b43_one_core_detach':
drivers/net/wireless/broadcom/b43/main.c:5496:17: warning:
 variable 'wl' set but not used [-Wunused-but-set-variable]
 
After commit 644aa4d62096 ("b43: remove list of IEEE 802.11 devices")
'wl' is not used any more.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/wireless/broadcom/b43/main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
index 4daa1ce..74be3c8 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -5493,13 +5493,11 @@ static int b43_wireless_core_attach(struct b43_wldev *dev)
 static void b43_one_core_detach(struct b43_bus_dev *dev)
 {
 	struct b43_wldev *wldev;
-	struct b43_wl *wl;
 
 	/* Do not cancel ieee80211-workqueue based work here.
 	 * See comment in b43_remove(). */
 
 	wldev = b43_bus_get_wldev(dev);
-	wl = wldev->wl;
 	b43_debugfs_remove_device(wldev);
 	b43_wireless_core_detach(wldev);
 	list_del(&wldev->list);

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] b43: remove set but not used variable 'wl'
  2018-10-05  4:15 ` YueHaibing
@ 2018-10-05  8:38   ` Kalle Valo
  -1 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-10-05  8:38 UTC (permalink / raw)
  To: YueHaibing
  Cc: Colin Ian King, YueHaibing, linux-wireless, b43-dev, kernel-janitors

YueHaibing <yuehaibing@huawei.com> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/broadcom/b43/main.c: In function 'b43_one_core_detach':
> drivers/net/wireless/broadcom/b43/main.c:5496:17: warning:
>  variable 'wl' set but not used [-Wunused-but-set-variable]
>  
> After commit 644aa4d62096 ("b43: remove list of IEEE 802.11 devices")
> 'wl' is not used any more.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Patch applied to wireless-drivers-next.git, thanks.

a7dd5d7c2dd8 b43: remove set but not used variable 'wl'

-- 
https://patchwork.kernel.org/patch/10627361/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] b43: remove set but not used variable 'wl'
@ 2018-10-05  8:38   ` Kalle Valo
  0 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-10-05  8:38 UTC (permalink / raw)
  To: YueHaibing; +Cc: Colin Ian King, linux-wireless, b43-dev, kernel-janitors

YueHaibing <yuehaibing@huawei.com> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/broadcom/b43/main.c: In function 'b43_one_core_detach':
> drivers/net/wireless/broadcom/b43/main.c:5496:17: warning:
>  variable 'wl' set but not used [-Wunused-but-set-variable]
>  
> After commit 644aa4d62096 ("b43: remove list of IEEE 802.11 devices")
> 'wl' is not used any more.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Patch applied to wireless-drivers-next.git, thanks.

a7dd5d7c2dd8 b43: remove set but not used variable 'wl'

-- 
https://patchwork.kernel.org/patch/10627361/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] b43: remove set but not used variables 'tx_pwr_state,tmp2'
  2018-10-05  4:15 ` YueHaibing
@ 2018-12-05  7:26 ` YueHaibing
  -1 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2018-12-05  7:26 UTC (permalink / raw)
  To: Kalle Valo, Larry Finger, Priit Laes, Kees Cook, Jia-Ju Bai
  Cc: YueHaibing, linux-wireless, b43-dev, netdev, linux-kernel,
	kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_op_recalc_txpower':
drivers/net/wireless/broadcom/b43/phy_n.c:5898:7: warning:
 variable 'tx_pwr_state' set but not used [-Wunused-but-set-variable]

drivers/net/wireless/broadcom/b43/phy_n.c:6047:20: warning:
 variable 'tmp2' set but not used [-Wunused-but-set-variable]

'tx_pwr_state' never used since introduction in commit
8615eb2870f1 ("b43: N-PHY: support setting custom TX power")

'tmp2' not used any more since commit c002831a07dd ("b43: N-PHY: use helper
for checking IPA")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/wireless/broadcom/b43/phy_n.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c
index 7d30036..77d7cd5 100644
--- a/drivers/net/wireless/broadcom/b43/phy_n.c
+++ b/drivers/net/wireless/broadcom/b43/phy_n.c
@@ -5895,7 +5895,6 @@ static enum b43_txpwr_result b43_nphy_op_recalc_txpower(struct b43_wldev *dev,
 	struct ieee80211_channel *channel = dev->wl->hw->conf.chandef.chan;
 	struct b43_ppr *ppr = &nphy->tx_pwr_max_ppr;
 	u8 max; /* qdBm */
-	bool tx_pwr_state;
 
 	if (nphy->tx_pwr_last_recalc_freq == channel->center_freq &&
 	    nphy->tx_pwr_last_recalc_limit == phy->desired_txpower)
@@ -5931,7 +5930,6 @@ static enum b43_txpwr_result b43_nphy_op_recalc_txpower(struct b43_wldev *dev,
 	b43_ppr_apply_min(dev, ppr, INT_TO_Q52(8));
 
 	/* Apply */
-	tx_pwr_state = nphy->txpwrctrl;
 	b43_mac_suspend(dev);
 	b43_nphy_tx_power_ctl_setup(dev);
 	if (dev->dev->core_rev == 11 || dev->dev->core_rev == 12) {
@@ -6044,7 +6042,6 @@ static int b43_phy_initn(struct b43_wldev *dev)
 	u8 tx_pwr_state;
 	struct nphy_txgains target;
 	u16 tmp;
-	enum nl80211_band tmp2;
 	bool do_rssi_cal;
 
 	u16 clip[2];
@@ -6138,7 +6135,6 @@ static int b43_phy_initn(struct b43_wldev *dev)
 		b43_phy_write(dev, B43_NPHY_DUP40_BL, 0x9A4);
 	}
 
-	tmp2 = b43_current_band(dev->wl);
 	if (b43_nphy_ipa(dev)) {
 		b43_phy_set(dev, B43_NPHY_PAPD_EN0, 0x1);
 		b43_phy_maskset(dev, B43_NPHY_EPS_TABLE_ADJ0, 0x007F,




^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] b43: remove set but not used variables 'tx_pwr_state,tmp2'
@ 2018-12-05  7:26 ` YueHaibing
  0 siblings, 0 replies; 9+ messages in thread
From: YueHaibing @ 2018-12-05  7:26 UTC (permalink / raw)
  To: Kalle Valo, Larry Finger, Priit Laes, Kees Cook, Jia-Ju Bai
  Cc: YueHaibing, linux-wireless, b43-dev, netdev, linux-kernel,
	kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_op_recalc_txpower':
drivers/net/wireless/broadcom/b43/phy_n.c:5898:7: warning:
 variable 'tx_pwr_state' set but not used [-Wunused-but-set-variable]

drivers/net/wireless/broadcom/b43/phy_n.c:6047:20: warning:
 variable 'tmp2' set but not used [-Wunused-but-set-variable]

'tx_pwr_state' never used since introduction in commit
8615eb2870f1 ("b43: N-PHY: support setting custom TX power")

'tmp2' not used any more since commit c002831a07dd ("b43: N-PHY: use helper
for checking IPA")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/wireless/broadcom/b43/phy_n.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c
index 7d30036..77d7cd5 100644
--- a/drivers/net/wireless/broadcom/b43/phy_n.c
+++ b/drivers/net/wireless/broadcom/b43/phy_n.c
@@ -5895,7 +5895,6 @@ static enum b43_txpwr_result b43_nphy_op_recalc_txpower(struct b43_wldev *dev,
 	struct ieee80211_channel *channel = dev->wl->hw->conf.chandef.chan;
 	struct b43_ppr *ppr = &nphy->tx_pwr_max_ppr;
 	u8 max; /* qdBm */
-	bool tx_pwr_state;
 
 	if (nphy->tx_pwr_last_recalc_freq = channel->center_freq &&
 	    nphy->tx_pwr_last_recalc_limit = phy->desired_txpower)
@@ -5931,7 +5930,6 @@ static enum b43_txpwr_result b43_nphy_op_recalc_txpower(struct b43_wldev *dev,
 	b43_ppr_apply_min(dev, ppr, INT_TO_Q52(8));
 
 	/* Apply */
-	tx_pwr_state = nphy->txpwrctrl;
 	b43_mac_suspend(dev);
 	b43_nphy_tx_power_ctl_setup(dev);
 	if (dev->dev->core_rev = 11 || dev->dev->core_rev = 12) {
@@ -6044,7 +6042,6 @@ static int b43_phy_initn(struct b43_wldev *dev)
 	u8 tx_pwr_state;
 	struct nphy_txgains target;
 	u16 tmp;
-	enum nl80211_band tmp2;
 	bool do_rssi_cal;
 
 	u16 clip[2];
@@ -6138,7 +6135,6 @@ static int b43_phy_initn(struct b43_wldev *dev)
 		b43_phy_write(dev, B43_NPHY_DUP40_BL, 0x9A4);
 	}
 
-	tmp2 = b43_current_band(dev->wl);
 	if (b43_nphy_ipa(dev)) {
 		b43_phy_set(dev, B43_NPHY_PAPD_EN0, 0x1);
 		b43_phy_maskset(dev, B43_NPHY_EPS_TABLE_ADJ0, 0x007F,

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] b43: remove set but not used variables 'tx_pwr_state, tmp2'
  2018-12-05  7:26 ` YueHaibing
@ 2018-12-13 15:02   ` Kalle Valo
  -1 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-12-13 15:02 UTC (permalink / raw)
  To: YueHaibing
  Cc: Larry Finger, Priit Laes, Kees Cook, Jia-Ju Bai, YueHaibing,
	linux-wireless, b43-dev, netdev, linux-kernel, kernel-janitors

YueHaibing <yuehaibing@huawei.com> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_op_recalc_txpower':
> drivers/net/wireless/broadcom/b43/phy_n.c:5898:7: warning:
>  variable 'tx_pwr_state' set but not used [-Wunused-but-set-variable]
> 
> drivers/net/wireless/broadcom/b43/phy_n.c:6047:20: warning:
>  variable 'tmp2' set but not used [-Wunused-but-set-variable]
> 
> 'tx_pwr_state' never used since introduction in commit
> 8615eb2870f1 ("b43: N-PHY: support setting custom TX power")
> 
> 'tmp2' not used any more since commit c002831a07dd ("b43: N-PHY: use helper
> for checking IPA")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Patch applied to wireless-drivers-next.git, thanks.

662a7b078cff b43: remove set but not used variables 'tx_pwr_state,tmp2'

-- 
https://patchwork.kernel.org/patch/10713095/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] b43: remove set but not used variables 'tx_pwr_state, tmp2'
       [not found] ` <1543994766-7057-1-git-send-email-yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
@ 2018-12-13 15:02   ` Kalle Valo
  0 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-12-13 15:02 UTC (permalink / raw)
  To: YueHaibing
  Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Priit Laes, Kees Cook,
	YueHaibing, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Jia-Ju Bai,
	b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	netdev-u79uwXL29TY76Z2rM5mHXA, Larry Finger

YueHaibing <yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_op_recalc_txpower':
> drivers/net/wireless/broadcom/b43/phy_n.c:5898:7: warning:
>  variable 'tx_pwr_state' set but not used [-Wunused-but-set-variable]
> 
> drivers/net/wireless/broadcom/b43/phy_n.c:6047:20: warning:
>  variable 'tmp2' set but not used [-Wunused-but-set-variable]
> 
> 'tx_pwr_state' never used since introduction in commit
> 8615eb2870f1 ("b43: N-PHY: support setting custom TX power")
> 
> 'tmp2' not used any more since commit c002831a07dd ("b43: N-PHY: use helper
> for checking IPA")
> 
> Signed-off-by: YueHaibing <yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

Patch applied to wireless-drivers-next.git, thanks.

662a7b078cff b43: remove set but not used variables 'tx_pwr_state,tmp2'

-- 
https://patchwork.kernel.org/patch/10713095/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] b43: remove set but not used variables 'tx_pwr_state, tmp2'
@ 2018-12-13 15:02   ` Kalle Valo
  0 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-12-13 15:02 UTC (permalink / raw)
  To: YueHaibing
  Cc: Larry Finger, Priit Laes, Kees Cook, Jia-Ju Bai, linux-wireless,
	b43-dev, netdev, linux-kernel, kernel-janitors

YueHaibing <yuehaibing@huawei.com> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_op_recalc_txpower':
> drivers/net/wireless/broadcom/b43/phy_n.c:5898:7: warning:
>  variable 'tx_pwr_state' set but not used [-Wunused-but-set-variable]
> 
> drivers/net/wireless/broadcom/b43/phy_n.c:6047:20: warning:
>  variable 'tmp2' set but not used [-Wunused-but-set-variable]
> 
> 'tx_pwr_state' never used since introduction in commit
> 8615eb2870f1 ("b43: N-PHY: support setting custom TX power")
> 
> 'tmp2' not used any more since commit c002831a07dd ("b43: N-PHY: use helper
> for checking IPA")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Patch applied to wireless-drivers-next.git, thanks.

662a7b078cff b43: remove set but not used variables 'tx_pwr_state,tmp2'

-- 
https://patchwork.kernel.org/patch/10713095/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-12-13 15:02 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05  4:15 [PATCH] b43: remove set but not used variable 'wl' YueHaibing
2018-10-05  4:15 ` YueHaibing
2018-10-05  8:38 ` Kalle Valo
2018-10-05  8:38   ` Kalle Valo
2018-12-05  7:26 [PATCH] b43: remove set but not used variables 'tx_pwr_state,tmp2' YueHaibing
2018-12-05  7:26 ` YueHaibing
     [not found] ` <1543994766-7057-1-git-send-email-yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-12-13 15:02   ` [PATCH] b43: remove set but not used variables 'tx_pwr_state, tmp2' Kalle Valo
2018-12-13 15:02 ` Kalle Valo
2018-12-13 15:02   ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.