From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D089C00449 for ; Fri, 5 Oct 2018 21:59:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AFAEF21473 for ; Fri, 5 Oct 2018 21:59:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=micronovasrl.com header.i=@micronovasrl.com header.b="W13CNmK1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFAEF21473 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=micronovasrl.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728341AbeJFFAh (ORCPT ); Sat, 6 Oct 2018 01:00:37 -0400 Received: from mail.micronovasrl.com ([212.103.203.10]:45174 "EHLO mail.micronovasrl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbeJFFAg (ORCPT ); Sat, 6 Oct 2018 01:00:36 -0400 Received: from mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) by mail.micronovasrl.com (Postfix) with ESMTP id C8D0BB0081B for ; Fri, 5 Oct 2018 23:59:55 +0200 (CEST) Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=micronovasrl.com; h=references:in-reply-to:x-mailer:message-id:date:date:subject :subject:to:from:from; s=dkim; t=1538776795; x=1539640796; bh=6I LxoHv50N8w16qw34Fi8S7zwu/gJ947bOekxAMNcUc=; b=W13CNmK13Lrc0OU+4M Rr4snk15NJ7/P/QnRRYTTWLh6GaqD7y7LncrvX5ScA2XOQXjn5IGWIf+egs4qoFZ UV3ExKyK6tMju8osUyKWcIoka3ZDOSuwN/2ikv18rN6Oj+65mdWBXmzqpbcSwgF/ BTKWxYojp9TuwKPOQlO6oL1OE= X-Virus-Scanned: Debian amavisd-new at mail.micronovasrl.com Received: from mail.micronovasrl.com ([127.0.0.1]) by mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id alGUDreIOXoC for ; Fri, 5 Oct 2018 23:59:55 +0200 (CEST) Received: from ubuntu.localdomain (unknown [192.168.123.60]) by mail.micronovasrl.com (Postfix) with ESMTPSA id BB698B000F6; Fri, 5 Oct 2018 23:59:53 +0200 (CEST) From: Giulio Benetti To: Maxime Ripard Cc: David Airlie , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Giulio Benetti Subject: [PATCH v3 1/2] drm/sun4i: tcon: fix check of tcon->panel null pointer Date: Fri, 5 Oct 2018 23:59:50 +0200 Message-Id: <20181005215951.99003-1-giulio.benetti@micronovasrl.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181004195605.txvbkshvxklyzxyb@flea> References: <20181004195605.txvbkshvxklyzxyb@flea> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since tcon->panel is a pointer returned by of_drm_find_panel() need to check if it is not NULL, hence a valid pointer. IS_ERR() instead checks return error values, not NULL pointers. Substitute "if (!IS_ERR(tcon->panel))" with "if (tcon->panel)". Signed-off-by: Giulio Benetti --- Changes V1->V2: * correct same bug for all same occurences in drm/sun4i folder Changes V2->V3: * Improve commit log drivers/gpu/drm/sun4i/sun4i_lvds.c | 4 ++-- drivers/gpu/drm/sun4i/sun4i_rgb.c | 4 ++-- drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_lvds.c b/drivers/gpu/drm/sun4i/sun4i_lvds.c index af7dcb6da351..e7eb0d1e17be 100644 --- a/drivers/gpu/drm/sun4i/sun4i_lvds.c +++ b/drivers/gpu/drm/sun4i/sun4i_lvds.c @@ -75,7 +75,7 @@ static void sun4i_lvds_encoder_enable(struct drm_encoder *encoder) DRM_DEBUG_DRIVER("Enabling LVDS output\n"); - if (!IS_ERR(tcon->panel)) { + if (tcon->panel) { drm_panel_prepare(tcon->panel); drm_panel_enable(tcon->panel); } @@ -88,7 +88,7 @@ static void sun4i_lvds_encoder_disable(struct drm_encoder *encoder) DRM_DEBUG_DRIVER("Disabling LVDS output\n"); - if (!IS_ERR(tcon->panel)) { + if (tcon->panel) { drm_panel_disable(tcon->panel); drm_panel_unprepare(tcon->panel); } diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c index bf068da6b12e..f4a22689eb54 100644 --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c +++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c @@ -135,7 +135,7 @@ static void sun4i_rgb_encoder_enable(struct drm_encoder *encoder) DRM_DEBUG_DRIVER("Enabling RGB output\n"); - if (!IS_ERR(tcon->panel)) { + if (tcon->panel) { drm_panel_prepare(tcon->panel); drm_panel_enable(tcon->panel); } @@ -148,7 +148,7 @@ static void sun4i_rgb_encoder_disable(struct drm_encoder *encoder) DRM_DEBUG_DRIVER("Disabling RGB output\n"); - if (!IS_ERR(tcon->panel)) { + if (tcon->panel) { drm_panel_disable(tcon->panel); drm_panel_unprepare(tcon->panel); } diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index c78cd35a1294..e4b3bd0307ef 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -555,7 +555,7 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, * Following code is a way to avoid quirks all around TCON * and DOTCLOCK drivers. */ - if (!IS_ERR(tcon->panel)) { + if (tcon->panel) { struct drm_panel *panel = tcon->panel; struct drm_connector *connector = panel->connector; struct drm_display_info display_info = connector->display_info; -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: giulio.benetti@micronovasrl.com (Giulio Benetti) Date: Fri, 5 Oct 2018 23:59:50 +0200 Subject: [PATCH v3 1/2] drm/sun4i: tcon: fix check of tcon->panel null pointer In-Reply-To: <20181004195605.txvbkshvxklyzxyb@flea> References: <20181004195605.txvbkshvxklyzxyb@flea> Message-ID: <20181005215951.99003-1-giulio.benetti@micronovasrl.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Since tcon->panel is a pointer returned by of_drm_find_panel() need to check if it is not NULL, hence a valid pointer. IS_ERR() instead checks return error values, not NULL pointers. Substitute "if (!IS_ERR(tcon->panel))" with "if (tcon->panel)". Signed-off-by: Giulio Benetti --- Changes V1->V2: * correct same bug for all same occurences in drm/sun4i folder Changes V2->V3: * Improve commit log drivers/gpu/drm/sun4i/sun4i_lvds.c | 4 ++-- drivers/gpu/drm/sun4i/sun4i_rgb.c | 4 ++-- drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_lvds.c b/drivers/gpu/drm/sun4i/sun4i_lvds.c index af7dcb6da351..e7eb0d1e17be 100644 --- a/drivers/gpu/drm/sun4i/sun4i_lvds.c +++ b/drivers/gpu/drm/sun4i/sun4i_lvds.c @@ -75,7 +75,7 @@ static void sun4i_lvds_encoder_enable(struct drm_encoder *encoder) DRM_DEBUG_DRIVER("Enabling LVDS output\n"); - if (!IS_ERR(tcon->panel)) { + if (tcon->panel) { drm_panel_prepare(tcon->panel); drm_panel_enable(tcon->panel); } @@ -88,7 +88,7 @@ static void sun4i_lvds_encoder_disable(struct drm_encoder *encoder) DRM_DEBUG_DRIVER("Disabling LVDS output\n"); - if (!IS_ERR(tcon->panel)) { + if (tcon->panel) { drm_panel_disable(tcon->panel); drm_panel_unprepare(tcon->panel); } diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c index bf068da6b12e..f4a22689eb54 100644 --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c +++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c @@ -135,7 +135,7 @@ static void sun4i_rgb_encoder_enable(struct drm_encoder *encoder) DRM_DEBUG_DRIVER("Enabling RGB output\n"); - if (!IS_ERR(tcon->panel)) { + if (tcon->panel) { drm_panel_prepare(tcon->panel); drm_panel_enable(tcon->panel); } @@ -148,7 +148,7 @@ static void sun4i_rgb_encoder_disable(struct drm_encoder *encoder) DRM_DEBUG_DRIVER("Disabling RGB output\n"); - if (!IS_ERR(tcon->panel)) { + if (tcon->panel) { drm_panel_disable(tcon->panel); drm_panel_unprepare(tcon->panel); } diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index c78cd35a1294..e4b3bd0307ef 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -555,7 +555,7 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, * Following code is a way to avoid quirks all around TCON * and DOTCLOCK drivers. */ - if (!IS_ERR(tcon->panel)) { + if (tcon->panel) { struct drm_panel *panel = tcon->panel; struct drm_connector *connector = panel->connector; struct drm_display_info display_info = connector->display_info; -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Giulio Benetti Subject: [PATCH v3 1/2] drm/sun4i: tcon: fix check of tcon->panel null pointer Date: Fri, 5 Oct 2018 23:59:50 +0200 Message-ID: <20181005215951.99003-1-giulio.benetti@micronovasrl.com> References: <20181004195605.txvbkshvxklyzxyb@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.micronovasrl.com (mail.micronovasrl.com [212.103.203.10]) by gabe.freedesktop.org (Postfix) with ESMTP id 41CB06E8F3 for ; Fri, 5 Oct 2018 21:59:55 +0000 (UTC) Received: from mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) by mail.micronovasrl.com (Postfix) with ESMTP id 41BF8B0078B for ; Fri, 5 Oct 2018 23:59:55 +0200 (CEST) Received: from mail.micronovasrl.com ([127.0.0.1]) by mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id t83fAUT8H6HK for ; Fri, 5 Oct 2018 23:59:54 +0200 (CEST) In-Reply-To: <20181004195605.txvbkshvxklyzxyb@flea> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Giulio Benetti , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org U2luY2UgdGNvbi0+cGFuZWwgaXMgYSBwb2ludGVyIHJldHVybmVkIGJ5IG9mX2RybV9maW5kX3Bh bmVsKCkgbmVlZCB0bwpjaGVjayBpZiBpdCBpcyBub3QgTlVMTCwgaGVuY2UgYSB2YWxpZCBwb2lu dGVyLgpJU19FUlIoKSBpbnN0ZWFkIGNoZWNrcyByZXR1cm4gZXJyb3IgdmFsdWVzLCBub3QgTlVM TCBwb2ludGVycy4KClN1YnN0aXR1dGUgImlmICghSVNfRVJSKHRjb24tPnBhbmVsKSkiIHdpdGgg ImlmICh0Y29uLT5wYW5lbCkiLgoKU2lnbmVkLW9mZi1ieTogR2l1bGlvIEJlbmV0dGkgPGdpdWxp by5iZW5ldHRpQG1pY3Jvbm92YXNybC5jb20+Ci0tLQpDaGFuZ2VzIFYxLT5WMjoKKiBjb3JyZWN0 IHNhbWUgYnVnIGZvciBhbGwgc2FtZSBvY2N1cmVuY2VzIGluIGRybS9zdW40aSBmb2xkZXIKCkNo YW5nZXMgVjItPlYzOgoqIEltcHJvdmUgY29tbWl0IGxvZwoKIGRyaXZlcnMvZ3B1L2RybS9zdW40 aS9zdW40aV9sdmRzLmMgfCA0ICsrLS0KIGRyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV9yZ2Iu YyAgfCA0ICsrLS0KIGRyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV90Y29uLmMgfCAyICstCiAz IGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfbHZkcy5jIGIvZHJpdmVycy9ncHUvZHJt L3N1bjRpL3N1bjRpX2x2ZHMuYwppbmRleCBhZjdkY2I2ZGEzNTEuLmU3ZWIwZDFlMTdiZSAxMDA2 NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2x2ZHMuYworKysgYi9kcml2ZXJz L2dwdS9kcm0vc3VuNGkvc3VuNGlfbHZkcy5jCkBAIC03NSw3ICs3NSw3IEBAIHN0YXRpYyB2b2lk IHN1bjRpX2x2ZHNfZW5jb2Rlcl9lbmFibGUoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyKQog CiAJRFJNX0RFQlVHX0RSSVZFUigiRW5hYmxpbmcgTFZEUyBvdXRwdXRcbiIpOwogCi0JaWYgKCFJ U19FUlIodGNvbi0+cGFuZWwpKSB7CisJaWYgKHRjb24tPnBhbmVsKSB7CiAJCWRybV9wYW5lbF9w cmVwYXJlKHRjb24tPnBhbmVsKTsKIAkJZHJtX3BhbmVsX2VuYWJsZSh0Y29uLT5wYW5lbCk7CiAJ fQpAQCAtODgsNyArODgsNyBAQCBzdGF0aWMgdm9pZCBzdW40aV9sdmRzX2VuY29kZXJfZGlzYWJs ZShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpCiAKIAlEUk1fREVCVUdfRFJJVkVSKCJEaXNh YmxpbmcgTFZEUyBvdXRwdXRcbiIpOwogCi0JaWYgKCFJU19FUlIodGNvbi0+cGFuZWwpKSB7CisJ aWYgKHRjb24tPnBhbmVsKSB7CiAJCWRybV9wYW5lbF9kaXNhYmxlKHRjb24tPnBhbmVsKTsKIAkJ ZHJtX3BhbmVsX3VucHJlcGFyZSh0Y29uLT5wYW5lbCk7CiAJfQpkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL3N1bjRpL3N1bjRpX3JnYi5jIGIvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRp X3JnYi5jCmluZGV4IGJmMDY4ZGE2YjEyZS4uZjRhMjI2ODllYjU0IDEwMDY0NAotLS0gYS9kcml2 ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfcmdiLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL3N1bjRp L3N1bjRpX3JnYi5jCkBAIC0xMzUsNyArMTM1LDcgQEAgc3RhdGljIHZvaWQgc3VuNGlfcmdiX2Vu Y29kZXJfZW5hYmxlKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcikKIAogCURSTV9ERUJVR19E UklWRVIoIkVuYWJsaW5nIFJHQiBvdXRwdXRcbiIpOwogCi0JaWYgKCFJU19FUlIodGNvbi0+cGFu ZWwpKSB7CisJaWYgKHRjb24tPnBhbmVsKSB7CiAJCWRybV9wYW5lbF9wcmVwYXJlKHRjb24tPnBh bmVsKTsKIAkJZHJtX3BhbmVsX2VuYWJsZSh0Y29uLT5wYW5lbCk7CiAJfQpAQCAtMTQ4LDcgKzE0 OCw3IEBAIHN0YXRpYyB2b2lkIHN1bjRpX3JnYl9lbmNvZGVyX2Rpc2FibGUoc3RydWN0IGRybV9l bmNvZGVyICplbmNvZGVyKQogCiAJRFJNX0RFQlVHX0RSSVZFUigiRGlzYWJsaW5nIFJHQiBvdXRw dXRcbiIpOwogCi0JaWYgKCFJU19FUlIodGNvbi0+cGFuZWwpKSB7CisJaWYgKHRjb24tPnBhbmVs KSB7CiAJCWRybV9wYW5lbF9kaXNhYmxlKHRjb24tPnBhbmVsKTsKIAkJZHJtX3BhbmVsX3VucHJl cGFyZSh0Y29uLT5wYW5lbCk7CiAJfQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N1bjRp L3N1bjRpX3Rjb24uYyBiL2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV90Y29uLmMKaW5kZXgg Yzc4Y2QzNWExMjk0Li5lNGIzYmQwMzA3ZWYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9z dW40aS9zdW40aV90Y29uLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX3Rjb24u YwpAQCAtNTU1LDcgKzU1NSw3IEBAIHN0YXRpYyB2b2lkIHN1bjRpX3Rjb24wX21vZGVfc2V0X3Jn YihzdHJ1Y3Qgc3VuNGlfdGNvbiAqdGNvbiwKIAkgKiBGb2xsb3dpbmcgY29kZSBpcyBhIHdheSB0 byBhdm9pZCBxdWlya3MgYWxsIGFyb3VuZCBUQ09OCiAJICogYW5kIERPVENMT0NLIGRyaXZlcnMu CiAJICovCi0JaWYgKCFJU19FUlIodGNvbi0+cGFuZWwpKSB7CisJaWYgKHRjb24tPnBhbmVsKSB7 CiAJCXN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsID0gdGNvbi0+cGFuZWw7CiAJCXN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uZWN0b3IgPSBwYW5lbC0+Y29ubmVjdG9yOwogCQlzdHJ1Y3QgZHJtX2Rp c3BsYXlfaW5mbyBkaXNwbGF5X2luZm8gPSBjb25uZWN0b3ItPmRpc3BsYXlfaW5mbzsKLS0gCjIu MTcuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==