From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Fri, 5 Oct 2018 15:37:18 -0700 From: Omar Sandoval To: Jens Axboe Cc: Bart Van Assche , linux-block@vger.kernel.org, Christoph Hellwig , Ming Lei , Hannes Reinecke , Johannes Thumshirn , "Martin K . Petersen" Subject: Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started Message-ID: <20181005223718.GL25437@vader> References: <20181004173524.52712-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: List-ID: On Fri, Oct 05, 2018 at 08:18:00AM -0600, Jens Axboe wrote: > On 10/4/18 11:35 AM, Bart Van Assche wrote: > > When debugging e.g. the SCSI timeout handler it is important that > > requests that have not yet been started or that already have > > completed are also reported through debugfs. > > Thanks, I like this better - applied. BTW, what's up with the > reverse ordering on this: > > > Signed-off-by: Bart Van Assche > > Cc: Christoph Hellwig > > Cc: Ming Lei > > Cc: Hannes Reinecke > > Cc: Johannes Thumshirn > > Cc: Martin K. Petersen > > For some reason that really annoys me, and I see it in various > patches these days. IMHO the SOB should be last, with whatever > acks, reviews, CC, before that. I could've sworn that this guideline was even documented somewhere, but I can't find it now ¯\_(ツ)_/¯