From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v7 04/15] octeontx2-af: Add mailbox support infra Date: Sat, 06 Oct 2018 14:42:49 -0700 (PDT) Message-ID: <20181006.144249.1076298435915338095.davem@davemloft.net> References: <1538805993-10815-1-git-send-email-sunil.kovvuri@gmail.com> <1538805993-10815-5-git-send-email-sunil.kovvuri@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, arnd@arndb.de, linux-soc@vger.kernel.org, amakarov@marvell.com, sgoutham@marvell.com, lbartosik@marvell.com To: sunil.kovvuri@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:59422 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbeJGErp (ORCPT ); Sun, 7 Oct 2018 00:47:45 -0400 In-Reply-To: <1538805993-10815-5-git-send-email-sunil.kovvuri@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: sunil.kovvuri@gmail.com Date: Sat, 6 Oct 2018 11:36:22 +0530 > + tx_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->tx_start); > + rx_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start); Since mdev->mbase is a void pointer, you do not need these casts, nor the parenthesis, at all. Please remove them.