From: Christoph Hellwig <hch@lst.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 09/17] target/core: Always call transport_complete_callback() upon failure
Date: Sat, 06 Oct 2018 12:13:08 +0000 [thread overview]
Message-ID: <20181006121308.GD7723@lst.de> (raw)
In-Reply-To: <20180917213554.987-10-bvanassche@acm.org>
On Mon, Sep 17, 2018 at 02:35:46PM -0700, Bart Van Assche wrote:
> Call transport_complete_callback() not only if COMPARE AND WRITE fails but
> also if XDWRITEREAD fails. This makes the code more systematic.
This looks ok:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But I wonder if transport_complete_callback should really be split into
multiple more specific callbacks instead.
next prev parent reply other threads:[~2018-10-06 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 21:35 [PATCH 09/17] target/core: Always call transport_complete_callback() upon failure Bart Van Assche
2018-10-06 12:13 ` Christoph Hellwig [this message]
2018-10-07 1:34 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006121308.GD7723@lst.de \
--to=hch@lst.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.