From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] pwm: lpss: Check PWM powerstate after resume on Cherry Trail devices
Date: Sat, 6 Oct 2018 17:16:51 +0300 [thread overview]
Message-ID: <20181006141651.GW15943@smile.fi.intel.com> (raw)
In-Reply-To: <db4f6771-9ce3-9793-a2e4-b317909cd06b@redhat.com>
On Sat, Oct 06, 2018 at 10:55:41AM +0200, Hans de Goede wrote:
> On 03-10-18 11:22, Rafael J. Wysocki wrote:
> > On Monday, September 24, 2018 11:40:14 AM CEST Hans de Goede wrote:
> > Also, why don't you use acpi_device_get_power() instead of evaluating
> > _PSC directly? It should make no difference if there are no power
> > resources, should it?
> 2) acpi_device_get_power() is not exported to modules
Do we have any side effects if we just export it?
I would think exporting is better than open coding.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-10-06 14:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 17:30 [PATCH 1/2] pwm: lpss: Move struct pwm_lpss_chip definition to the header file Hans de Goede
2018-09-11 17:30 ` [PATCH 2/2] pwm: lpss: Check PWM powerstate after resume on Cherry Trail devices Hans de Goede
2018-09-24 9:02 ` Andy Shevchenko
2018-09-24 9:10 ` Hans de Goede
2018-09-24 9:18 ` Andy Shevchenko
2018-09-24 9:40 ` Hans de Goede
2018-10-03 9:22 ` Rafael J. Wysocki
2018-10-06 8:55 ` Hans de Goede
2018-10-06 14:16 ` Andy Shevchenko [this message]
2018-10-10 11:14 ` Hans de Goede
2018-10-11 12:07 ` Andy Shevchenko
2018-10-11 14:00 ` Rafael J. Wysocki
2018-10-11 14:11 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006141651.GW15943@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.