From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 17/19] net: usb: aqc111: Initialize ethtool_ops structure Date: Sat, 6 Oct 2018 19:08:46 +0200 Message-ID: <20181006170846.GD6990@lunn.ch> References: <26309478ca61ae4163acb455d62021cf6801c29a.1538734658.git.igor.russkikh@aquantia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S . Miller" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , Dmitry Bezrukov To: Igor Russkikh Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:55786 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726256AbeJGAM4 (ORCPT ); Sat, 6 Oct 2018 20:12:56 -0400 Content-Disposition: inline In-Reply-To: <26309478ca61ae4163acb455d62021cf6801c29a.1538734658.git.igor.russkikh@aquantia.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Oct 05, 2018 at 10:25:22AM +0000, Igor Russkikh wrote: > From: Dmitry Bezrukov > > Implement get_drvinfo, set/get_msglevel, get_link callbacks > > Signed-off-by: Dmitry Bezrukov > Signed-off-by: Igor Russkikh > --- > drivers/net/usb/aqc111.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c > index 9908b0a04da6..ade2b60b4811 100644 > --- a/drivers/net/usb/aqc111.c > +++ b/drivers/net/usb/aqc111.c > @@ -9,6 +9,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -18,6 +19,9 @@ > > #include "aqc111.h" > > +#define DRIVER_VERSION "1.0.0.0" Hi Igor This is been discussed a number of times before, and i expect it to be discussed again. Driver versions of useless. Please drop it. > +#define DRIVER_NAME "Aquantia AQtion USB to 5GbE" It might be nice to include the module name in here, making it easy to link the module to the driver. > + > static int __aqc111_read_cmd(struct usbnet *dev, u8 cmd, u16 value, > u16 index, u16 size, void *data, int nopm) > { > @@ -170,6 +174,24 @@ static int aq_mdio_write_cmd(struct usbnet *dev, u16 value, u16 index, > return aqc111_write_cmd(dev, AQ_PHY_CMD, value, index, size, data); > } > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [net-next,17/19] net: usb: aqc111: Initialize ethtool_ops structure From: Andrew Lunn Message-Id: <20181006170846.GD6990@lunn.ch> Date: Sat, 6 Oct 2018 19:08:46 +0200 To: Igor Russkikh Cc: "David S . Miller" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , Dmitry Bezrukov List-ID: T24gRnJpLCBPY3QgMDUsIDIwMTggYXQgMTA6MjU6MjJBTSArMDAwMCwgSWdvciBSdXNza2lraCB3 cm90ZToKPiBGcm9tOiBEbWl0cnkgQmV6cnVrb3YgPGRtaXRyeS5iZXpydWtvdkBhcXVhbnRpYS5j b20+Cj4gCj4gSW1wbGVtZW50IGdldF9kcnZpbmZvLCBzZXQvZ2V0X21zZ2xldmVsLCBnZXRfbGlu ayBjYWxsYmFja3MKPiAKPiBTaWduZWQtb2ZmLWJ5OiBEbWl0cnkgQmV6cnVrb3YgPGRtaXRyeS5i ZXpydWtvdkBhcXVhbnRpYS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSWdvciBSdXNza2lraCA8aWdv ci5ydXNza2lraEBhcXVhbnRpYS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbmV0L3VzYi9hcWMxMTEu YyB8IDMwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwg MzAgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC91c2IvYXFjMTEx LmMgYi9kcml2ZXJzL25ldC91c2IvYXFjMTExLmMKPiBpbmRleCA5OTA4YjBhMDRkYTYuLmFkZTJi NjBiNDgxMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL25ldC91c2IvYXFjMTExLmMKPiArKysgYi9k cml2ZXJzL25ldC91c2IvYXFjMTExLmMKPiBAQCAtOSw2ICs5LDcgQEAKPiAgCj4gICNpbmNsdWRl IDxsaW51eC9tb2R1bGUuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L25ldGRldmljZS5oPgo+ICsjaW5j bHVkZSA8bGludXgvZXRodG9vbC5oPgo+ICAjaW5jbHVkZSA8bGludXgvbWlpLmg+Cj4gICNpbmNs dWRlIDxsaW51eC91c2IuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2NyYzMyLmg+Cj4gQEAgLTE4LDYg KzE5LDkgQEAKPiAgCj4gICNpbmNsdWRlICJhcWMxMTEuaCIKPiAgCj4gKyNkZWZpbmUgRFJJVkVS X1ZFUlNJT04gIjEuMC4wLjAiCgpIaSBJZ29yCgpUaGlzIGlzIGJlZW4gZGlzY3Vzc2VkIGEgbnVt YmVyIG9mIHRpbWVzIGJlZm9yZSwgYW5kIGkgZXhwZWN0IGl0IHRvIGJlCmRpc2N1c3NlZCBhZ2Fp bi4gRHJpdmVyIHZlcnNpb25zIG9mIHVzZWxlc3MuIFBsZWFzZSBkcm9wIGl0LgoKPiArI2RlZmlu ZSBEUklWRVJfTkFNRSAiQXF1YW50aWEgQVF0aW9uIFVTQiB0byA1R2JFIgoKSXQgbWlnaHQgYmUg bmljZSB0byBpbmNsdWRlIHRoZSBtb2R1bGUgbmFtZSBpbiBoZXJlLCBtYWtpbmcgaXQgZWFzeSB0 bwpsaW5rIHRoZSBtb2R1bGUgdG8gdGhlIGRyaXZlci4KCj4gKwo+ICBzdGF0aWMgaW50IF9fYXFj MTExX3JlYWRfY21kKHN0cnVjdCB1c2JuZXQgKmRldiwgdTggY21kLCB1MTYgdmFsdWUsCj4gIAkJ CSAgICAgdTE2IGluZGV4LCB1MTYgc2l6ZSwgdm9pZCAqZGF0YSwgaW50IG5vcG0pCj4gIHsKPiBA QCAtMTcwLDYgKzE3NCwyNCBAQCBzdGF0aWMgaW50IGFxX21kaW9fd3JpdGVfY21kKHN0cnVjdCB1 c2JuZXQgKmRldiwgdTE2IHZhbHVlLCB1MTYgaW5kZXgsCj4gIAlyZXR1cm4gYXFjMTExX3dyaXRl X2NtZChkZXYsIEFRX1BIWV9DTUQsIHZhbHVlLCBpbmRleCwgc2l6ZSwgZGF0YSk7Cj4gIH0KPiAg CgogICBBbmRyZXcK