From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next] net: dsa: mc88e6xxx: Fix 88E6141/6341 2500mbps
 SERDES speed
Date: Sat, 6 Oct 2018 20:37:00 +0200
Message-ID: <20181006183700.GO4730@lunn.ch>
References: <20181005144227.32220-1-marek.behun@nic.cz>
 <20181005212055.GA28680@lunn.ch>
 <20181006023810.20be216e@nic.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev <netdev@vger.kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S . Miller" <davem@davemloft.net>
To: Marek Behun <marek.behun@nic.cz>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:55812 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726387AbeJGBlY (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 6 Oct 2018 21:41:24 -0400
Content-Disposition: inline
In-Reply-To: <20181006023810.20be216e@nic.cz>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sat, Oct 06, 2018 at 02:38:10AM +0200, Marek Behun wrote:
> > Hi Marek
> > 
> > I'm confused.
> > 
> > The alt bit is used for configuring 2500. You say 2500 is only
> > supported on port 5. But !port is only true for port 0?
> > 
> > 	  Andrew
> 
> On Topaz alt_bit is used only for port 0 for differentiating 100 mbps
> vs 200 mbps. The choices for SpdValue are 0 for 10 mbps, 1 for 100
> mbps or 200 mbps (if alt_bit), 2 for 1000 mbps and 3 for 2500 mbps.
> 2500 is allowed only on port 5. alt_bit is not used on Topaz for port
> 5 (serdes), therefore I used !port.

Hi Marek

The commit message could be clearer. It might be going too far, but
you could split this into three.

1) Basic framework code, with works correctly for ports 1-4.
2) The special 200Mbps for port 0
3) The special 2500Mbps for port 5.

But i would also accept a clearer commit message.

    Thanks
    Andrew