From: Sasha Levin <sashal@kernel.org>
To: Dafna Hirschfeld <dafna3@gmail.com>
Cc: isely@pobox.com, mchehab@kernel.org, helen.koike@collabora.com,
hverkuil@xs4all.nl, outreachy-kernel@googlegroups.com,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`
Date: Sat, 6 Oct 2018 19:03:59 -0400 [thread overview]
Message-ID: <20181006230359.GB32006@sasha-vm> (raw)
In-Reply-To: <20181006192138.11349-1-dafna3@gmail.com>
On Sat, Oct 06, 2018 at 10:21:38PM +0300, Dafna Hirschfeld wrote:
>Replace calls to `printk` with the appropriate `pr_*`
>macro.
Hi Dafna,
I'd encourage you to look into the dev_ family of print functions (such
as dev_info() ). They can avoid having to repeat the driver name in
every print call.
--
Thanks,
Sasha
next prev parent reply other threads:[~2018-10-07 1:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-06 19:21 [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*` Dafna Hirschfeld
2018-10-06 23:03 ` Sasha Levin [this message]
2018-10-07 8:27 ` [Outreachy kernel] " Hans Verkuil
2018-10-07 12:57 ` Helen Koike
2018-10-08 12:06 Dafna Hirschfeld
2018-10-08 13:07 ` [Outreachy kernel] " Greg KH
2018-10-08 13:29 ` Hans Verkuil
2018-10-08 13:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006230359.GB32006@sasha-vm \
--to=sashal@kernel.org \
--cc=dafna3@gmail.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=isely@pobox.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.