From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: fstests@vger.kernel.org
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
guaneryu@gmail.com, darrick.wong@oracle.com, zlang@redhat.com,
david@fromorbit.com, linux-xfs@vger.kernel.org
Subject: [PATCH 1/2] xfs/139: work with 1k block size
Date: Mon, 8 Oct 2018 11:53:02 +0530 [thread overview]
Message-ID: <20181008062303.32286-1-chandan@linux.vnet.ibm.com> (raw)
Commit 0e2b99951fa11ea8a8adf4676aef130cfeeb5250 (xfs/139: work with 64k
block size) created a test filesystem with AG size set to (8192 * block
size). When working with a 1k block sized XFS filesystem, this tries to
set the AG size to 8MiB which is less than the minimum AG size of
16MiB. Hence creation of the filesystem had actually failed.
This commit fixes the issue by setting AG size to be (16384 * block
size).
Reported-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
---
tests/xfs/139 | 4 ++--
tests/xfs/139.out | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/xfs/139 b/tests/xfs/139
index c074273..3a20ce5 100755
--- a/tests/xfs/139
+++ b/tests/xfs/139
@@ -40,14 +40,14 @@ blksz=$(_get_file_block_size $SCRATCH_MNT)
_scratch_unmount
echo "Format and mount"
-_scratch_mkfs -d agsize=$((8192 * $blksz)) > $seqres.full 2>&1
+_scratch_mkfs -d agsize=$((16384 * $blksz)) > $seqres.full 2>&1
_scratch_mount >> $seqres.full 2>&1
testdir=$SCRATCH_MNT/test-$seq
mkdir $testdir
echo "Create the original files"
-sz=$((12288 * $blksz))
+sz=$((20480 * $blksz))
_pwrite_byte 0x61 0 $sz $testdir/file1 >> $seqres.full
_cp_reflink $testdir/file1 $testdir/file2 >> $seqres.full
_scratch_cycle_mount
diff --git a/tests/xfs/139.out b/tests/xfs/139.out
index 72909bc..1005d5c 100644
--- a/tests/xfs/139.out
+++ b/tests/xfs/139.out
@@ -5,7 +5,7 @@ CoW every other block
Compare files
0 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62
*
-30000
+50000
0 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61
*
-30000
+50000
--
2.9.5
next reply other threads:[~2018-10-08 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 6:23 Chandan Rajendra [this message]
2018-10-08 6:23 ` [PATCH 2/2] xfs/140: work with 1k block size Chandan Rajendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008062303.32286-1-chandan@linux.vnet.ibm.com \
--to=chandan@linux.vnet.ibm.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.