From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition Date: Mon, 8 Oct 2018 13:54:24 +0530 Message-ID: <20181008082421.GA3554@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181004055930.GA4406@jerin> <26087815.IDbtF1NTBH@xps> <20181006081537.GB21149@jerin> <2601191342CEEE43887BDE71AB9772580102FE2EE9@IRSMSX106.ger.corp.intel.com> <601d2413-e148-73c4-e7a5-59f09bd02451@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Ananyev, Konstantin" , Thomas Monjalon , Andrew Rybchenko , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "Mcnamara, John" , "Kovacevic, Marko" , Olivier Matz , "dev@dpdk.org" , "shahafs@mellanox.com" , "didier.pallard@6wind.com" To: Ferruh Yigit Return-path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700063.outbound.protection.outlook.com [40.107.70.63]) by dpdk.org (Postfix) with ESMTP id 109DC160 for ; Mon, 8 Oct 2018 10:24:47 +0200 (CEST) Content-Disposition: inline In-Reply-To: <601d2413-e148-73c4-e7a5-59f09bd02451@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Mon, 8 Oct 2018 09:12:34 +0100 > From: Ferruh Yigit > To: "Ananyev, Konstantin" , Jerin Jacob > , Thomas Monjalon > CC: Andrew Rybchenko , "Lu, Wenzhuo" > , "Wu, Jingjing" , > "Iremonger, Bernard" , "Mcnamara, John" > , "Kovacevic, Marko" , > Olivier Matz , "dev@dpdk.org" , > "shahafs@mellanox.com" , "didier.pallard@6wind.com" > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > checksum definition > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > > On 10/6/2018 1:18 PM, Ananyev, Konstantin wrote: > > > > > >> -----Original Message----- > >> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > >> Sent: Saturday, October 6, 2018 9:16 AM > >> To: Thomas Monjalon > >> Cc: Yigit, Ferruh ; Andrew Rybchenko ; Lu, Wenzhuo ; Wu, > >> Jingjing ; Iremonger, Bernard ; Mcnamara, John ; > >> Kovacevic, Marko ; Olivier Matz ; dev@dpdk.org; shahafs@mellanox.com; > >> Ananyev, Konstantin ; didier.pallard@6wind.com > >> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition > >> > >> -----Original Message----- > >>> Date: Sat, 06 Oct 2018 00:44:52 +0200 > >>> From: Thomas Monjalon > >>> To: Ferruh Yigit , Jerin Jacob > >>> , Andrew Rybchenko > >>> > >>> Cc: Wenzhuo Lu , Jingjing Wu , > >>> Bernard Iremonger , John McNamara > >>> , Marko Kovacevic , > >>> Olivier Matz , dev@dpdk.org, shahafs@mellanox.com, > >>> "Ananyev, Konstantin" , > >>> didier.pallard@6wind.com > >>> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > >>> checksum definition > >>> > >>> > >>> 05/10/2018 22:04, Ferruh Yigit: > >>>> On 10/4/2018 6:59 AM, Jerin Jacob wrote: > >>>>> From: Andrew Rybchenko > >>>>>> On 03.10.2018 21:14, Jerin Jacob wrote: > >>>>>>> From: Andrew Rybchenko > >>>>>>>> On 03.10.2018 20:12, Jerin Jacob wrote: > >>>>>>>>> From: Jerin Jacob > >>>>>>>>>> From: Andrew Rybchenko > >>>>>>>>>>> 3. PKT_RX_L4_CKSUM_MASK description says nothing if it is inner or outer. > >>>>>>>>>>> May be it is not directly related to changeset, but I think it would be really > >>>>>>>>>>> useful to clarify it. > >>>>>>>>>> I will update the comment. > >>>>>>>>> Hi Andrew, > >>>>>>>>> > >>> > >>> However, we should re-visit the flag PKT_RX_EIP_CKSUM_BAD. > >> > >> Do we need to block this patch due to the exiting PKT_RX_EIP_CKSUM_BAD > >> definition? > >> > >> I already added the author of the PKT_RX_EIP_CKSUM_BAD flag and ethdev and mbuf > >> maintainers in this list. So what else I need make forward progress > >> on this patch? > >> > >> I think, the definition of PKT_RX_EIP_CKSUM_BAD based on HW capability. It > >> is safe to assume that ALL HW can support CKSUM BAD if the feature is > >> available and hence it is more portable. > > > > Yes, as I remember PKT_RX_EIP_CKSUM_BAD is based on DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM. > > Switching to two bit won't reduce the portability, HW supports only reporting > CKSUM_BAD can set BAD || UNKNOWN. UNKNOWN is not a bit. It is represented as 0. It spec has 2 bit, then driver need to report GOOD as well. Same applies for PKT_RX_EL4_CKSUM as well. > > And I think patch is not blocked by PKT_RX_EIP_CKSUM_BAD, it can be changed > separately, for this patch question is can we represent PKT_RX_EL4_CKSUM_* with > two bits, to have BAD/GOOD/UNKNOWN?