From: Ananya Krishna Maram <ananyakittu1997@gmail.com>
To: christian.couder@gmail.com, git@vger.kernel.org,
Johannes.Schindelin@gmx.de
Subject: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files
Date: Mon, 8 Oct 2018 17:05:05 +0000 [thread overview]
Message-ID: <20181008170505.GA13134@manohar-ssh> (raw)
Hi All,
I was searching through #leftovers and found this.
https://public-inbox.org/git/CABPp-BGVVXcbZX44er6TO-PUsfEN_6GNYJ1U5cuoN9deaA48OQ@mail.gmail.com/
This patch address the task discussed in the above link.
From: Ananya Krishan Maram <ananyakittu1997@gmail.com>
skip the #include of git-compat-util.h since all .c files include it.
Signed-off-by: Ananya Krishna Maram <ananyakittu1997@gmail.com>
---
advice.h | 1 -
commit-graph.h | 1 -
hash.h | 1 -
pkt-line.h | 1 -
t/helper/test-tool.h | 1 -
5 files changed, 5 deletions(-)
diff --git a/advice.h b/advice.h
index ab24df0fd..09148baa6 100644
--- a/advice.h
+++ b/advice.h
@@ -1,7 +1,6 @@
#ifndef ADVICE_H
#define ADVICE_H
-#include "git-compat-util.h"
extern int advice_push_update_rejected;
extern int advice_push_non_ff_current;
diff --git a/commit-graph.h b/commit-graph.h
index b05047676..0e93c2bed 100644
--- a/commit-graph.h
+++ b/commit-graph.h
@@ -1,7 +1,6 @@
#ifndef COMMIT_GRAPH_H
#define COMMIT_GRAPH_H
-#include "git-compat-util.h"
#include "repository.h"
#include "string-list.h"
#include "cache.h"
diff --git a/hash.h b/hash.h
index 7c8238bc2..9a4334c5d 100644
--- a/hash.h
+++ b/hash.h
@@ -1,7 +1,6 @@
#ifndef HASH_H
#define HASH_H
-#include "git-compat-util.h"
#if defined(SHA1_PPC)
#include "ppc/sha1.h"
diff --git a/pkt-line.h b/pkt-line.h
index 5b28d4347..fdd316494 100644
--- a/pkt-line.h
+++ b/pkt-line.h
@@ -1,7 +1,6 @@
#ifndef PKTLINE_H
#define PKTLINE_H
-#include "git-compat-util.h"
#include "strbuf.h"
/*
diff --git a/t/helper/test-tool.h b/t/helper/test-tool.h
index e07495727..24e0a1589 100644
--- a/t/helper/test-tool.h
+++ b/t/helper/test-tool.h
@@ -1,7 +1,6 @@
#ifndef __TEST_TOOL_H__
#define __TEST_TOOL_H__
-#include "git-compat-util.h"
int cmd__chmtime(int argc, const char **argv);
int cmd__config(int argc, const char **argv);
--
2.19.0.272.ga00e0029e
next reply other threads:[~2018-10-08 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 17:05 Ananya Krishna Maram [this message]
2018-10-08 17:13 ` Derrick Stolee
2018-10-09 2:16 ` Ananya Krishna Maram
2018-10-09 10:13 ` Junio C Hamano
2018-10-10 8:06 ` Johannes Schindelin
2018-10-10 8:46 ` Junio C Hamano
2018-10-10 9:13 ` Christian Couder
2018-10-10 12:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008170505.GA13134@manohar-ssh \
--to=ananyakittu1997@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--subject='Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.