All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@bootlin.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read
Date: Tue, 9 Oct 2018 09:28:08 +0200	[thread overview]
Message-ID: <20181009072808.5eynmktmkgjpi2ho@qschulz> (raw)
In-Reply-To: <30c1dcb4a8d3707238fcf0a996b9e0bf0a4a7bbc.1539036280.git.gustavo@embeddedor.com>

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi Gustavo,

On Tue, Oct 09, 2018 at 12:22:33AM +0200, Gustavo A. R. Silva wrote:
> Currently, there is an out-of-bounds read on array ctrl->phys,
> once variable i reaches the maximum array size of SERDES_MAX
> in the for loop.
> 
> Fix this by changing the condition in the for loop from
> i <= SERDES_MAX to i < SERDES_MAX.
> 

Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>

Thanks,
Quentin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-10-09  7:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 22:20 [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug Gustavo A. R. Silva
2018-10-08 22:21 ` [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1 Gustavo A. R. Silva
2018-10-09  7:27   ` Quentin Schulz
2018-10-16  8:44     ` Gustavo A. R. Silva
2018-10-17 15:09       ` Rob Herring
2018-10-17 15:19         ` Gustavo A. R. Silva
2018-10-17 15:23         ` Rob Herring
2018-10-17 15:45           ` Gustavo A. R. Silva
2018-10-08 22:22 ` [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read Gustavo A. R. Silva
2018-10-09  7:28   ` Quentin Schulz [this message]
2018-10-16  8:46     ` Gustavo A. R. Silva
2018-10-16  8:48       ` Kishon Vijay Abraham I
2018-10-17 15:37         ` Gustavo A. R. Silva
2018-11-12  8:27           ` Kishon Vijay Abraham I
2018-10-09  7:28 ` [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug Quentin Schulz
2018-10-09 14:13   ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009072808.5eynmktmkgjpi2ho@qschulz \
    --to=quentin.schulz@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=gustavo@embeddedor.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.