From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9qAR-0005fv-Jm for qemu-devel@nongnu.org; Tue, 09 Oct 2018 07:27:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9qAO-00021C-2I for qemu-devel@nongnu.org; Tue, 09 Oct 2018 07:27:11 -0400 Received: from 3.mo177.mail-out.ovh.net ([46.105.36.172]:52999) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9qAM-0001z6-4k for qemu-devel@nongnu.org; Tue, 09 Oct 2018 07:27:06 -0400 Received: from player699.ha.ovh.net (unknown [10.109.160.40]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id A7098CACC3 for ; Tue, 9 Oct 2018 13:27:03 +0200 (CEST) Date: Tue, 9 Oct 2018 13:26:57 +0200 From: Greg Kurz Message-ID: <20181009132657.5b3662f3@bahia.lab.toulouse-stg.fr.ibm.com> In-Reply-To: <1539002382-3764-1-git-send-email-thuth@redhat.com> References: <1539002382-3764-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] hw/ppc/spapr_rng: Introduce CONFIG_SPAPR_RNG switch for spapr_rng.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Mon, 8 Oct 2018 14:39:42 +0200 Thomas Huth wrote: > The spapr-rng device is suboptimal when compared to virtio-rng, so > users might want to disable it in their builds. Thus let's introduce > a proper CONFIG switch to allow us to compile QEMU without this device. > The function spapr_rng_populate_dt is required for linking, so move it > to a different location. > > Signed-off-by: Thomas Huth > --- Reviewed-by: Greg Kurz > v2: Put spapr_rng_populate_dt() into spapr.c instead of a header > > default-configs/ppc64-softmmu.mak | 1 + > hw/ppc/Makefile.objs | 3 ++- > hw/ppc/spapr.c | 23 +++++++++++++++++++++++ > hw/ppc/spapr_rng.c | 23 ----------------------- > include/hw/ppc/spapr.h | 2 -- > 5 files changed, 26 insertions(+), 26 deletions(-) > > diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak > index b94af6c..24d4717 100644 > --- a/default-configs/ppc64-softmmu.mak > +++ b/default-configs/ppc64-softmmu.mak > @@ -17,3 +17,4 @@ CONFIG_XICS=$(CONFIG_PSERIES) > CONFIG_XICS_SPAPR=$(CONFIG_PSERIES) > CONFIG_XICS_KVM=$(call land,$(CONFIG_PSERIES),$(CONFIG_KVM)) > CONFIG_MEM_HOTPLUG=y > +CONFIG_SPAPR_RNG=y > diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs > index 4ab5564..4e0c1c0 100644 > --- a/hw/ppc/Makefile.objs > +++ b/hw/ppc/Makefile.objs > @@ -3,8 +3,9 @@ obj-y += ppc.o ppc_booke.o fdt.o > # IBM pSeries (sPAPR) > obj-$(CONFIG_PSERIES) += spapr.o spapr_caps.o spapr_vio.o spapr_events.o > obj-$(CONFIG_PSERIES) += spapr_hcall.o spapr_iommu.o spapr_rtas.o > -obj-$(CONFIG_PSERIES) += spapr_pci.o spapr_rtc.o spapr_drc.o spapr_rng.o > +obj-$(CONFIG_PSERIES) += spapr_pci.o spapr_rtc.o spapr_drc.o > obj-$(CONFIG_PSERIES) += spapr_cpu_core.o spapr_ovec.o spapr_irq.o > +obj-$(CONFIG_SPAPR_RNG) += spapr_rng.o > # IBM PowerNV > obj-$(CONFIG_POWERNV) += pnv.o pnv_xscom.o pnv_core.o pnv_lpc.o pnv_psi.o pnv_occ.o pnv_bmc.o > ifeq ($(CONFIG_PCI)$(CONFIG_PSERIES)$(CONFIG_LINUX), yyy) > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 98868d8..e666872 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -610,6 +610,29 @@ static void spapr_populate_cpus_dt_node(void *fdt, sPAPRMachineState *spapr) > g_free(rev); > } > > +static int spapr_rng_populate_dt(void *fdt) > +{ > + int node; > + int ret; > + > + node = qemu_fdt_add_subnode(fdt, "/ibm,platform-facilities"); > + if (node <= 0) { > + return -1; > + } > + ret = fdt_setprop_string(fdt, node, "device_type", > + "ibm,platform-facilities"); > + ret |= fdt_setprop_cell(fdt, node, "#address-cells", 0x1); > + ret |= fdt_setprop_cell(fdt, node, "#size-cells", 0x0); > + > + node = fdt_add_subnode(fdt, node, "ibm,random-v1"); > + if (node <= 0) { > + return -1; > + } > + ret |= fdt_setprop_string(fdt, node, "compatible", "ibm,random"); > + > + return ret ? -1 : 0; > +} > + > static uint32_t spapr_pc_dimm_node(MemoryDeviceInfoList *list, ram_addr_t addr) > { > MemoryDeviceInfoList *info; > diff --git a/hw/ppc/spapr_rng.c b/hw/ppc/spapr_rng.c > index d2acd61..644bac9 100644 > --- a/hw/ppc/spapr_rng.c > +++ b/hw/ppc/spapr_rng.c > @@ -132,29 +132,6 @@ static void spapr_rng_realize(DeviceState *dev, Error **errp) > } > } > > -int spapr_rng_populate_dt(void *fdt) > -{ > - int node; > - int ret; > - > - node = qemu_fdt_add_subnode(fdt, "/ibm,platform-facilities"); > - if (node <= 0) { > - return -1; > - } > - ret = fdt_setprop_string(fdt, node, "device_type", > - "ibm,platform-facilities"); > - ret |= fdt_setprop_cell(fdt, node, "#address-cells", 0x1); > - ret |= fdt_setprop_cell(fdt, node, "#size-cells", 0x0); > - > - node = fdt_add_subnode(fdt, node, "ibm,random-v1"); > - if (node <= 0) { > - return -1; > - } > - ret |= fdt_setprop_string(fdt, node, "compatible", "ibm,random"); > - > - return ret ? -1 : 0; > -} > - > static Property spapr_rng_properties[] = { > DEFINE_PROP_BOOL("use-kvm", sPAPRRngState, use_kvm, false), > DEFINE_PROP_LINK("rng", sPAPRRngState, backend, TYPE_RNG_BACKEND, > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > index ad4d7cf..0805ad8 100644 > --- a/include/hw/ppc/spapr.h > +++ b/include/hw/ppc/spapr.h > @@ -745,8 +745,6 @@ int spapr_rtc_import_offset(sPAPRRTCState *rtc, int64_t legacy_offset); > > #define TYPE_SPAPR_RNG "spapr-rng" > > -int spapr_rng_populate_dt(void *fdt); > - > #define SPAPR_MEMORY_BLOCK_SIZE (1 << 28) /* 256MB */ > > /*