From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAB2b-0004y7-Sg for qemu-devel@nongnu.org; Wed, 10 Oct 2018 05:44:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAB2Y-0005Ad-Lx for qemu-devel@nongnu.org; Wed, 10 Oct 2018 05:44:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42550) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gAB2X-00059m-WC for qemu-devel@nongnu.org; Wed, 10 Oct 2018 05:44:26 -0400 Date: Wed, 10 Oct 2018 10:44:12 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20181010094411.GA2411@work-vm> References: <20181003114454.5662-1-marcandre.lureau@redhat.com> <20181003114454.5662-4-marcandre.lureau@redhat.com> <9fa8a684-8d5d-1644-3aee-86a196d31f8d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <9fa8a684-8d5d-1644-3aee-86a196d31f8d@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] memory-mapping: skip non-volatile memory regions in GuestPhysBlockList List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , david@redhat.com Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , qemu-devel@nongnu.org, Paolo Bonzini , Igor Mammedov , Xiao Guangrong , Juan Quintela , "Michael S. Tsirkin" * Laszlo Ersek (lersek@redhat.com) wrote: > On 10/03/18 13:44, Marc-Andr=E9 Lureau wrote: > > GuestPhysBlockList is currently used to produce dumps. Given the size > > and the typical usage of NVDIMM for storage, they are not a good idea > > to have in the dumps. We may want to have an extra dump option to > > include them. For now, skip non-volatile regions. > >=20 > > The TCG memory clear function is going to use the GuestPhysBlockList > > as well, and will thus skip NVDIMM for similar reasons. > >=20 > > Cc: lersek@redhat.com > > Signed-off-by: Marc-Andr=E9 Lureau > > --- > > memory_mapping.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > >=20 > > diff --git a/memory_mapping.c b/memory_mapping.c > > index 775466f3a8..724dd0b417 100644 > > --- a/memory_mapping.c > > +++ b/memory_mapping.c > > @@ -206,7 +206,8 @@ static void guest_phys_blocks_region_add(MemoryLi= stener *listener, > > =20 > > /* we only care about RAM */ > > if (!memory_region_is_ram(section->mr) || > > - memory_region_is_ram_device(section->mr)) { > > + memory_region_is_ram_device(section->mr) || > > + memory_region_is_nonvolatile(section->mr)) { > > return; > > } > > =20 > >=20 >=20 > I've peeked at the first two patches as well. Seems OK to me. (Famous > last words?) >=20 > Reviewed-by: Laszlo Ersek This also looks good to me; just cc'ing in David H as well though. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK