From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: nuke the intel_lvds_connector Date: Wed, 10 Oct 2018 13:26:40 +0300 Message-ID: <20181010102640.GM9144@intel.com> References: <20181009210916.19578-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24CE88991E for ; Wed, 10 Oct 2018 10:26:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181009210916.19578-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTAsIDIwMTggYXQgMTI6MDk6MTZBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gRm9yIGEgd2hpbGUgd2UgY2FycmllZCBsdmRzIGNvbm5lY3RvciBzcGVjaWZpYyBkYXRh IGluIHRoZSBsdmRzCj4gY29ubmVjdG9yLCBidXQgc2luY2UgY29tbWl0IDA1YzcyZTc3Y2NkYSAo ImRybS9pOTE1OiBOdWtlIHRoZSBMVkRTIGxpZAo+IG5vdGlmaWVyIikgd2UgaGF2ZW4ndCBuZWVk ZWQgaXQuIFJldmVydCBiYWNrIHRvIHBsYWluIGludGVsX2Nvbm5lY3Rvci4KPiAKPiBDYzogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2Zm LWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMgfCA0MiArKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDMwIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s dmRzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMKPiBpbmRleCAxZmU5NzBj Zjk5MDkuLjUxMDU4NWVkOTRiMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9sdmRzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMKPiBA QCAtNDIsMTAgKzQyLDYgQEAKPiAgI2luY2x1ZGUgPGxpbnV4L2FjcGkuaD4KPiAgCj4gIC8qIFBy aXZhdGUgc3RydWN0dXJlIGZvciB0aGUgaW50ZWdyYXRlZCBMVkRTIHN1cHBvcnQgKi8KPiAtc3Ry dWN0IGludGVsX2x2ZHNfY29ubmVjdG9yIHsKPiAtCXN0cnVjdCBpbnRlbF9jb25uZWN0b3IgYmFz ZTsKPiAtfTsKPiAtCj4gIHN0cnVjdCBpbnRlbF9sdmRzX3BwcyB7Cj4gIAkvKiAxMDB1cyB1bml0 cyAqLwo+ICAJaW50IHQxX3QyOwo+IEBAIC03MCw3ICs2Niw3IEBAIHN0cnVjdCBpbnRlbF9sdmRz X2VuY29kZXIgewo+ICAJc3RydWN0IGludGVsX2x2ZHNfcHBzIGluaXRfcHBzOwo+ICAJdTMyIGlu aXRfbHZkc192YWw7Cj4gIAo+IC0Jc3RydWN0IGludGVsX2x2ZHNfY29ubmVjdG9yICphdHRhY2hl ZF9jb25uZWN0b3I7Cj4gKwlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICphdHRhY2hlZF9jb25uZWN0 b3I7Cj4gIH07Cj4gIAo+ICBzdGF0aWMgc3RydWN0IGludGVsX2x2ZHNfZW5jb2RlciAqdG9fbHZk c19lbmNvZGVyKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcikKPiBAQCAtNzgsMTEgKzc0LDYg QEAgc3RhdGljIHN0cnVjdCBpbnRlbF9sdmRzX2VuY29kZXIgKnRvX2x2ZHNfZW5jb2RlcihzdHJ1 Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpCj4gIAlyZXR1cm4gY29udGFpbmVyX29mKGVuY29kZXIs IHN0cnVjdCBpbnRlbF9sdmRzX2VuY29kZXIsIGJhc2UuYmFzZSk7Cj4gIH0KPiAgCj4gLXN0YXRp YyBzdHJ1Y3QgaW50ZWxfbHZkc19jb25uZWN0b3IgKnRvX2x2ZHNfY29ubmVjdG9yKHN0cnVjdCBk cm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4gLXsKPiAtCXJldHVybiBjb250YWluZXJfb2YoY29u bmVjdG9yLCBzdHJ1Y3QgaW50ZWxfbHZkc19jb25uZWN0b3IsIGJhc2UuYmFzZSk7Cj4gLX0KPiAt Cj4gIGJvb2wgaW50ZWxfbHZkc19wb3J0X2VuYWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+ICAJCQkgICAgIGk5MTVfcmVnX3QgbHZkc19yZWcsIGVudW0gcGlwZSAqcGlw ZSkKPiAgewo+IEBAIC0zOTYsNyArMzg3LDcgQEAgc3RhdGljIGJvb2wgaW50ZWxfbHZkc19jb21w dXRlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqaW50ZWxfZW5jb2RlciwKPiAgCXN0cnVj dCBpbnRlbF9sdmRzX2VuY29kZXIgKmx2ZHNfZW5jb2RlciA9Cj4gIAkJdG9fbHZkc19lbmNvZGVy KCZpbnRlbF9lbmNvZGVyLT5iYXNlKTsKPiAgCXN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmludGVs X2Nvbm5lY3RvciA9Cj4gLQkJJmx2ZHNfZW5jb2Rlci0+YXR0YWNoZWRfY29ubmVjdG9yLT5iYXNl Owo+ICsJCWx2ZHNfZW5jb2Rlci0+YXR0YWNoZWRfY29ubmVjdG9yOwo+ICAJc3RydWN0IGRybV9k aXNwbGF5X21vZGUgKmFkanVzdGVkX21vZGUgPSAmcGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRf bW9kZTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0Yyhw aXBlX2NvbmZpZy0+YmFzZS5jcnRjKTsKPiAgCXVuc2lnbmVkIGludCBsdmRzX2JwcDsKPiBAQCAt NDYxLDE1ICs0NTIsMTUgQEAgaW50ZWxfbHZkc19kZXRlY3Qoc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3RvciwgYm9vbCBmb3JjZSkKPiAgICovCj4gIHN0YXRpYyBpbnQgaW50ZWxfbHZkc19n ZXRfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgewo+IC0Jc3RydWN0 IGludGVsX2x2ZHNfY29ubmVjdG9yICpsdmRzX2Nvbm5lY3RvciA9IHRvX2x2ZHNfY29ubmVjdG9y KGNvbm5lY3Rvcik7Cj4gKwlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICppbnRlbF9jb25uZWN0b3Ig PSB0b19pbnRlbF9jb25uZWN0b3IoY29ubmVjdG9yKTsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpk ZXYgPSBjb25uZWN0b3ItPmRldjsKPiAgCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlOwo+ ICAKPiAgCS8qIHVzZSBjYWNoZWQgZWRpZCBpZiB3ZSBoYXZlIG9uZSAqLwo+IC0JaWYgKCFJU19F UlJfT1JfTlVMTChsdmRzX2Nvbm5lY3Rvci0+YmFzZS5lZGlkKSkKPiAtCQlyZXR1cm4gZHJtX2Fk ZF9lZGlkX21vZGVzKGNvbm5lY3RvciwgbHZkc19jb25uZWN0b3ItPmJhc2UuZWRpZCk7Cj4gKwlp ZiAoIUlTX0VSUl9PUl9OVUxMKGludGVsX2Nvbm5lY3Rvci0+ZWRpZCkpCj4gKwkJcmV0dXJuIGRy bV9hZGRfZWRpZF9tb2Rlcyhjb25uZWN0b3IsIGludGVsX2Nvbm5lY3Rvci0+ZWRpZCk7Cj4gIAo+ IC0JbW9kZSA9IGRybV9tb2RlX2R1cGxpY2F0ZShkZXYsIGx2ZHNfY29ubmVjdG9yLT5iYXNlLnBh bmVsLmZpeGVkX21vZGUpOwo+ICsJbW9kZSA9IGRybV9tb2RlX2R1cGxpY2F0ZShkZXYsIGludGVs X2Nvbm5lY3Rvci0+cGFuZWwuZml4ZWRfbW9kZSk7Cj4gIAlpZiAobW9kZSA9PSBOVUxMKQo+ICAJ CXJldHVybiAwOwo+ICAKPiBAQCAtNzgxLDggKzc3Miw3IEBAIHN0YXRpYyBib29sIGNvbXB1dGVf aXNfZHVhbF9saW5rX2x2ZHMoc3RydWN0IGludGVsX2x2ZHNfZW5jb2RlciAqbHZkc19lbmNvZGVy KQo+ICAJCXJldHVybiBpOTE1X21vZHBhcmFtcy5sdmRzX2NoYW5uZWxfbW9kZSA9PSAyOwo+ICAK PiAgCS8qIHNpbmdsZSBjaGFubmVsIExWRFMgaXMgbGltaXRlZCB0byAxMTIgTUh6ICovCj4gLQlp ZiAobHZkc19lbmNvZGVyLT5hdHRhY2hlZF9jb25uZWN0b3ItPmJhc2UucGFuZWwuZml4ZWRfbW9k ZS0+Y2xvY2sKPiAtCSAgICA+IDExMjk5OSkKPiArCWlmIChsdmRzX2VuY29kZXItPmF0dGFjaGVk X2Nvbm5lY3Rvci0+cGFuZWwuZml4ZWRfbW9kZS0+Y2xvY2sgPiAxMTI5OTkpCj4gIAkJcmV0dXJu IHRydWU7Cj4gIAo+ICAJaWYgKGRtaV9jaGVja19zeXN0ZW0oaW50ZWxfZHVhbF9saW5rX2x2ZHMp KQo+IEBAIC04MzcsNyArODI3LDYgQEAgdm9pZCBpbnRlbF9sdmRzX2luaXQoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9ICZkZXZf cHJpdi0+ZHJtOwo+ICAJc3RydWN0IGludGVsX2x2ZHNfZW5jb2RlciAqbHZkc19lbmNvZGVyOwo+ ICAJc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXI7Cj4gLQlzdHJ1Y3QgaW50ZWxf bHZkc19jb25uZWN0b3IgKmx2ZHNfY29ubmVjdG9yOwo+ICAJc3RydWN0IGludGVsX2Nvbm5lY3Rv ciAqaW50ZWxfY29ubmVjdG9yOwo+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsK PiAgCXN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcjsKPiBAQCAtODkwLDIzICs4NzksMTYgQEAg dm9pZCBpbnRlbF9sdmRzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ ICAJaWYgKCFsdmRzX2VuY29kZXIpCj4gIAkJcmV0dXJuOwo+ICAKPiAtCWx2ZHNfY29ubmVjdG9y ID0ga3phbGxvYyhzaXplb2YoKmx2ZHNfY29ubmVjdG9yKSwgR0ZQX0tFUk5FTCk7Cj4gLQlpZiAo IWx2ZHNfY29ubmVjdG9yKSB7Cj4gLQkJa2ZyZWUobHZkc19lbmNvZGVyKTsKPiAtCQlyZXR1cm47 Cj4gLQl9Cj4gLQo+IC0JaWYgKGludGVsX2Nvbm5lY3Rvcl9pbml0KCZsdmRzX2Nvbm5lY3Rvci0+ YmFzZSkgPCAwKSB7Cj4gLQkJa2ZyZWUobHZkc19jb25uZWN0b3IpOwo+ICsJaW50ZWxfY29ubmVj dG9yID0gaW50ZWxfY29ubmVjdG9yX2FsbG9jKCk7Cj4gKwlpZiAoIWludGVsX2Nvbm5lY3Rvcikg ewo+ICAJCWtmcmVlKGx2ZHNfZW5jb2Rlcik7Cj4gIAkJcmV0dXJuOwo+ICAJfQo+ICAKPiAtCWx2 ZHNfZW5jb2Rlci0+YXR0YWNoZWRfY29ubmVjdG9yID0gbHZkc19jb25uZWN0b3I7Cj4gKwlsdmRz X2VuY29kZXItPmF0dGFjaGVkX2Nvbm5lY3RvciA9IGludGVsX2Nvbm5lY3RvcjsKPiAgCj4gIAlp bnRlbF9lbmNvZGVyID0gJmx2ZHNfZW5jb2Rlci0+YmFzZTsKPiAgCWVuY29kZXIgPSAmaW50ZWxf ZW5jb2Rlci0+YmFzZTsKPiAtCWludGVsX2Nvbm5lY3RvciA9ICZsdmRzX2Nvbm5lY3Rvci0+YmFz ZTsKPiAgCWNvbm5lY3RvciA9ICZpbnRlbF9jb25uZWN0b3ItPmJhc2U7Cj4gIAlkcm1fY29ubmVj dG9yX2luaXQoZGV2LCAmaW50ZWxfY29ubmVjdG9yLT5iYXNlLCAmaW50ZWxfbHZkc19jb25uZWN0 b3JfZnVuY3MsCj4gIAkJCSAgIERSTV9NT0RFX0NPTk5FQ1RPUl9MVkRTKTsKPiBAQCAtOTg3LDcg Kzk2OSw3IEBAIHZvaWQgaW50ZWxfbHZkc19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiAgCX0gZWxzZSB7Cj4gIAkJZWRpZCA9IEVSUl9QVFIoLUVOT0VOVCk7Cj4gIAl9 Cj4gLQlsdmRzX2Nvbm5lY3Rvci0+YmFzZS5lZGlkID0gZWRpZDsKPiArCWludGVsX2Nvbm5lY3Rv ci0+ZWRpZCA9IGVkaWQ7Cj4gIAo+ICAJbGlzdF9mb3JfZWFjaF9lbnRyeShzY2FuLCAmY29ubmVj dG9yLT5wcm9iZWRfbW9kZXMsIGhlYWQpIHsKPiAgCQlpZiAoc2Nhbi0+dHlwZSAmIERSTV9NT0RF X1RZUEVfUFJFRkVSUkVEKSB7Cj4gQEAgLTEwNTEsNiArMTAzMyw2IEBAIHZvaWQgaW50ZWxfbHZk c19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCWRybV9jb25uZWN0 b3JfY2xlYW51cChjb25uZWN0b3IpOwo+ICAJZHJtX2VuY29kZXJfY2xlYW51cChlbmNvZGVyKTsK PiAgCWtmcmVlKGx2ZHNfZW5jb2Rlcik7Cj4gLQlrZnJlZShsdmRzX2Nvbm5lY3Rvcik7Cj4gKwlp bnRlbF9jb25uZWN0b3JfZnJlZShpbnRlbF9jb25uZWN0b3IpOwoKSSB3YXMgZ29pbmcgdG8gc2F5 IHRoYXQgdGhpcyB3aWxsIGRvIGEgZG91YmxlIGZyZWUgb24gdGhlIHN0YXRlLCBidXQKZHJtX2Nv bm5lY3Rvcl9jbGVhbnVwKCkgJiBjby4gbWVtc2V0KDApIHRoZSBvYmplY3Qgc28gdGhpcyBzaG91 bGQgYmUKZmluZS4KClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgoKPiAgCXJldHVybjsKPiAgfQo+IC0tIAo+IDIuMTEuMAoKLS0gClZp bGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK