All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: rename intel_modes.c to intel_connector.c
Date: Wed, 10 Oct 2018 13:30:07 +0300	[thread overview]
Message-ID: <20181010103007.GN9144@intel.com> (raw)
In-Reply-To: <20181010075205.7713-1-jani.nikula@intel.com>

On Wed, Oct 10, 2018 at 10:52:04AM +0300, Jani Nikula wrote:
> The common denominator here seems to be connector more than
> modes. Prepare for moving more connector functions to the same place. No
> functional changes.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/Makefile                          |  2 +-
>  .../gpu/drm/i915/{intel_modes.c => intel_connector.c}  |  0
>  drivers/gpu/drm/i915/intel_drv.h                       | 18 ++++++++----------
>  3 files changed, 9 insertions(+), 11 deletions(-)
>  rename drivers/gpu/drm/i915/{intel_modes.c => intel_connector.c} (100%)
> 
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index ef1480c14e4e..48cae0eae3f9 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -113,6 +113,7 @@ i915-y += intel_audio.o \
>  	  intel_bios.o \
>  	  intel_cdclk.o \
>  	  intel_color.o \
> +	  intel_connector.o \
>  	  intel_display.o \
>  	  intel_dpio_phy.o \
>  	  intel_dpll_mgr.o \
> @@ -121,7 +122,6 @@ i915-y += intel_audio.o \
>  	  intel_frontbuffer.o \
>  	  intel_hdcp.o \
>  	  intel_hotplug.o \
> -	  intel_modes.o \
>  	  intel_overlay.o \
>  	  intel_psr.o \
>  	  intel_sideband.o \
> diff --git a/drivers/gpu/drm/i915/intel_modes.c b/drivers/gpu/drm/i915/intel_connector.c
> similarity index 100%
> rename from drivers/gpu/drm/i915/intel_modes.c
> rename to drivers/gpu/drm/i915/intel_connector.c
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index 4b8fec74ad49..bc373f82c0d2 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -1668,6 +1668,14 @@ unsigned int i9xx_plane_max_stride(struct intel_plane *plane,
>  				   u32 pixel_format, u64 modifier,
>  				   unsigned int rotation);
>  
> +/* intel_connector.c */
> +int intel_connector_update_modes(struct drm_connector *connector,
> +				 struct edid *edid);
> +int intel_ddc_get_modes(struct drm_connector *c, struct i2c_adapter *adapter);
> +void intel_attach_force_audio_property(struct drm_connector *connector);
> +void intel_attach_broadcast_rgb_property(struct drm_connector *connector);
> +void intel_attach_aspect_ratio_property(struct drm_connector *connector);
> +
>  /* intel_csr.c */
>  void intel_csr_ucode_init(struct drm_i915_private *);
>  void intel_csr_load_program(struct drm_i915_private *);
> @@ -1864,16 +1872,6 @@ void intel_lvds_init(struct drm_i915_private *dev_priv);
>  struct intel_encoder *intel_get_lvds_encoder(struct drm_device *dev);
>  bool intel_is_dual_link_lvds(struct drm_device *dev);
>  
> -
> -/* intel_modes.c */
> -int intel_connector_update_modes(struct drm_connector *connector,
> -				 struct edid *edid);
> -int intel_ddc_get_modes(struct drm_connector *c, struct i2c_adapter *adapter);
> -void intel_attach_force_audio_property(struct drm_connector *connector);
> -void intel_attach_broadcast_rgb_property(struct drm_connector *connector);
> -void intel_attach_aspect_ratio_property(struct drm_connector *connector);
> -
> -
>  /* intel_overlay.c */
>  void intel_setup_overlay(struct drm_i915_private *dev_priv);
>  void intel_cleanup_overlay(struct drm_i915_private *dev_priv);
> -- 
> 2.11.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-10-10 10:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  7:52 [PATCH 1/2] drm/i915: rename intel_modes.c to intel_connector.c Jani Nikula
2018-10-10  7:52 ` [PATCH 2/2] drm/i915: move intel connector specific functions " Jani Nikula
2018-10-10  8:46 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: rename intel_modes.c " Patchwork
2018-10-10  8:48 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-10-10  9:11 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-10-10 10:11 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-10 10:30 ` Ville Syrjälä [this message]
2018-10-10 12:19   ` [PATCH 1/2] " Jani Nikula
2018-10-10 12:11 ` ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
2018-10-10 12:48 ` ✓ Fi.CI.BAT: " Patchwork
2018-10-10 16:31 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181010103007.GN9144@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.