From: Gerd Hoffmann <kraxel@redhat.com>
To: Jonathon Jongsma <jjongsma@redhat.com>
Cc: "Lukáš Hrázký" <lhrazky@redhat.com>,
spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest
Date: Wed, 10 Oct 2018 12:37:04 +0200 [thread overview]
Message-ID: <20181010103704.jqgfp3kiaiqu4hzt@sirius.home.kraxel.org> (raw)
In-Reply-To: <1539113618.12871.122.camel@redhat.com>
Hi,
> > + * Sets the hardware (e.g. PCI) path of the graphics device
> > represented by this QXL interface instance.
>
> So, this comment suggests that the caller might be able to provide a
> path that is not a PCI path. But the implementation below (mostly the
> debug output, I suppose...) assumes a PCI path. Do we need to support
> non-PCI paths?
Certainly not for the initial revision, maybe never.
But thanks to the "pci/" prefix we should be able to add support for
other paths later in case it turns out we need it.
> > + * Returns: The actual SPICE server monitor_id associated with the
> > display
>
> So, if I remember correctly, Gerd recommended returning this value from
> the function. But I think it needs more explanation here. What exactly
> is a "monitor_id" supposed to represent? It is not used in your follow-
> up qemu patch so it's hard to tell.
IIRC the plan was to ditch the global monior_id idea and use the
(channel_id, display_id) tuple everywhere ...
cheers,
Gerd
next prev parent reply other threads:[~2018-10-10 10:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 13:10 [Qemu-devel] [RFC PATCH spice/qemu 0/2] QXL interface to set monitor ID Lukáš Hrázký
2018-10-09 13:10 ` [Qemu-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest Lukáš Hrázký
2018-10-09 19:33 ` [Qemu-devel] [Spice-devel] " Jonathon Jongsma
2018-10-10 10:37 ` Gerd Hoffmann [this message]
2018-10-11 12:55 ` Lukáš Hrázký
2018-10-11 13:20 ` Gerd Hoffmann
2018-10-11 13:31 ` Lukáš Hrázký
2018-10-11 13:45 ` Gerd Hoffmann
2018-10-10 16:36 ` Lukáš Hrázký
2018-10-11 12:27 ` Gerd Hoffmann
2018-10-11 13:07 ` Frediano Ziglio
2018-10-11 13:12 ` Lukáš Hrázký
2018-10-11 13:43 ` Gerd Hoffmann
2018-10-11 14:30 ` Lukáš Hrázký
2018-10-11 15:09 ` Gerd Hoffmann
2018-10-11 15:37 ` Lukáš Hrázký
2018-10-12 9:27 ` Gerd Hoffmann
2018-10-12 9:54 ` Lukáš Hrázký
2018-10-12 10:15 ` Frediano Ziglio
2018-10-12 10:42 ` Gerd Hoffmann
2018-10-12 10:46 ` Frediano Ziglio
2018-10-12 11:05 ` Gerd Hoffmann
2018-10-09 13:10 ` [Qemu-devel] [RFC PATCH qemu 2/2] spice: set PCI path and device display ID in QXL interface Lukáš Hrázký
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010103704.jqgfp3kiaiqu4hzt@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=jjongsma@redhat.com \
--cc=lhrazky@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.