From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [sky2 driver] 88E8056 PCI-E Gigabit Ethernet Controller not
 working after suspend
Date: Wed, 10 Oct 2018 12:09:22 -0700
Message-ID: <20181010120922.6831b0fe@xeon-e3>
References: <01fd5a94-37d5-f029-d215-ce143516ab84@bigon.be>
        <20181009130904.37cec5d0@xeon-e3>
        <aa7dd2f9-fc1a-6b59-3f9a-716dfbc4de9b@bigon.be>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: netdev@vger.kernel.org
To: Laurent Bigonville <bigon@bigon.be>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f171.google.com ([209.85.215.171]:43234 "EHLO
        mail-pg1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726911AbeJKCdB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 10 Oct 2018 22:33:01 -0400
Received: by mail-pg1-f171.google.com with SMTP id 80-v6so2942785pgh.10
        for <netdev@vger.kernel.org>; Wed, 10 Oct 2018 12:09:30 -0700 (PDT)
In-Reply-To: <aa7dd2f9-fc1a-6b59-3f9a-716dfbc4de9b@bigon.be>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 10 Oct 2018 03:16:40 +0200
Laurent Bigonville <bigon@bigon.be> wrote:

> Le 9/10/18 =C3=A0 22:09, Stephen Hemminger a =C3=A9crit=C2=A0:
> > On Tue, 9 Oct 2018 19:30:30 +0200
> > Laurent Bigonville <bigon@bigon.be> wrote:
> > =20
> >> Hello,
> >>
> >> On my desktop (Asus MB with dual Ethernet port), when waking up after
> >> suspend, the network card is not detecting the link.
> >>
> >> I have to rmmod the sky2 driver and then modprobing it again.
> >>
> >> lspci shows me:
> >>
> >> 04:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8056 PCI=
-E
> >> Gigabit Ethernet Controller (rev 12)
> >> 05:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8056 PCI=
-E
> >> Gigabit Ethernet Controller (rev 12)
> >>
> >> An idea what's wrong here?
> >>
> >> Kind regards,
> >>
> >> Laurent Bigonville
> >> =20
> > I used to have that motherboard (about 8 years ago). Long  dead by now.
> >
> > There was some issue with how the power management worked. Forgot the w=
orkaround,
> > you might have to dig in the mailing list archive. =20
>=20
> I've made some test and it seems that this was working in 4.14 and then=20
> broken in 4.15 (using the debian kernel pkg), so it was working not that=
=20
> long ago:
>=20
> The only commit I see to the sky2 driver is the following:
>=20
> commit e99e88a9d2b067465adaa9c111ada99a041bef9a
> Author: Kees Cook <keescook@chromium.org>
> Date:=C2=A0=C2=A0 Mon Oct 16 14:43:17 2017 -0700
>=20
>  =C2=A0=C2=A0=C2=A0 treewide: setup_timer() -> timer_setup()
>=20
>  =C2=A0=C2=A0=C2=A0 This converts all remaining cases of the old setup_ti=
mer() API into=20
> using
>  =C2=A0=C2=A0=C2=A0 timer_setup(), where the callback argument is the str=
ucture already
>  =C2=A0=C2=A0=C2=A0 holding the struct timer_list. These should have no b=
ehavioral changes,
>  =C2=A0=C2=A0=C2=A0 since they just change which pointer is passed into t=
he callback with
>  =C2=A0=C2=A0=C2=A0 the same available pointers after conversion. It hand=
les the following
>  =C2=A0=C2=A0=C2=A0 examples, in addition to some other variations.
>=20
>=20

Probably something in PCI power management could.=20