From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 10 Oct 2018 14:28:09 +0200 From: Jan Kara To: Johannes Thumshirn Cc: Tetsuo Handa , Jan Kara , Jens Axboe , linux-block@vger.kernel.org Subject: Re: [PATCH 0/15 v2] loop: Fix oops and possible deadlocks Message-ID: <20181010122809.GE11507@quack2.suse.cz> References: <20181010100415.26525-1-jack@suse.cz> <20181010114227.GA12977@linux-x5ow.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20181010114227.GA12977@linux-x5ow.site> List-ID: On Wed 10-10-18 13:42:27, Johannes Thumshirn wrote: > On Wed, Oct 10, 2018 at 07:19:00PM +0900, Tetsuo Handa wrote: > > On 2018/10/10 19:04, Jan Kara wrote: > > > Hi, > > > > > > this patch series fixes oops and possible deadlocks as reported by syzbot [1] > > > [2]. The second patch in the series (from Tetsuo) fixes the oops, the remaining > > > patches are cleaning up the locking in the loop driver so that we can in the > > > end reasonably easily switch to rereading partitions without holding mutex > > > protecting the loop device. > > > > > > I have lightly tested the patches by creating, deleting, and modifying loop > > > devices but if there's some more comprehensive loopback device testsuite, I > > > can try running it. Review is welcome! > > > > Testing on linux-next by syzbot will be the most comprehensive. ;-) > > Apart from that blktests has a loop category and I think it could also be > worthwhile to add the C reproducer from syzkaller to blktests. Yeah, I did run loop tests now and they ran fine. I can try converting the syzbot reproducers into something legible but it will take a while. Honza -- Jan Kara SUSE Labs, CR