All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Tom Psyborg <pozega.tomislav@gmail.com>
Cc: Daniel Golle <daniel@makrotopia.org>,
	linux-wireless@vger.kernel.org, Mathias Kresin <dev@kresin.me>,
	Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH v3 4/4] rt2800: fix registers init for MT7620
Date: Wed, 10 Oct 2018 17:40:55 +0200	[thread overview]
Message-ID: <20181010154054.GA27779@redhat.com> (raw)
In-Reply-To: <CAKR_QVJbtzpu6v4bZEz2UegWiAy1Ohooy-TciZcOeR_p+Z+yYg@mail.gmail.com>

On Wed, Oct 10, 2018 at 04:11:12PM +0200, Tom Psyborg wrote:
> case 1:
> 
> 	} else if (rt2x00_rt(rt2x00dev, RT5390) ||
> 		   rt2x00_rt(rt2x00dev, RT5392)) {
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404);
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG1, 0x00080606);
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG2, 0x00000000);
> 	} else if (rt2x00_rt(rt2x00dev, RT5592)) {
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404);
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG1, 0x00000000);
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG2, 0x00000000);
> 	} else if (rt2x00_rt(rt2x00dev, RT5350)) {
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404);
> 	} else if (rt2x00_rt(rt2x00dev, RT6352)) {
> 		rt2800_register_write(rt2x00dev, MIMO_PS_CFG, 0x00000002);
> 		rt2800_register_write(rt2x00dev, TX_PIN_CFG, 0x00150F0F);
> 		rt2800_register_write(rt2x00dev, TX_ALC_VGA3, 0x06060606);
> 		rt2800_register_write(rt2x00dev, TX0_BB_GAIN_ATTEN, 0x0);
> 		rt2800_register_write(rt2x00dev, TX1_BB_GAIN_ATTEN, 0x0);
> 		rt2800_register_write(rt2x00dev, TX0_RF_GAIN_ATTEN, 0x6C6C666C);
> 		rt2800_register_write(rt2x00dev, TX1_RF_GAIN_ATTEN, 0x6C6C666C);
> 
> does your 6352 wifi work?
> 
> case 2:
> 
> 	} else if (rt2x00_rt(rt2x00dev, RT5390) ||
> 		   rt2x00_rt(rt2x00dev, RT5392)) {
> 	} else if (rt2x00_rt(rt2x00dev, RT5592)) {
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404);
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG1, 0x00000000);
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG2, 0x00000000);
> 	} else if (rt2x00_rt(rt2x00dev, RT5350)) {
> 		rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404);
> 	} else if (rt2x00_rt(rt2x00dev, RT6352)) {
> 		rt2800_register_write(rt2x00dev, MIMO_PS_CFG, 0x00000002);
> 		rt2800_register_write(rt2x00dev, TX_PIN_CFG, 0x00150F0F);
> 		rt2800_register_write(rt2x00dev, TX_ALC_VGA3, 0x06060606);
> 		rt2800_register_write(rt2x00dev, TX0_BB_GAIN_ATTEN, 0x0);
> 		rt2800_register_write(rt2x00dev, TX1_BB_GAIN_ATTEN, 0x0);
> 		rt2800_register_write(rt2x00dev, TX0_RF_GAIN_ATTEN, 0x6C6C666C);
> 		rt2800_register_write(rt2x00dev, TX1_RF_GAIN_ATTEN, 0x6C6C666C);
> 
> does your 6352 wifi still work?

I checked 'case 2' (on my 'rt2x00' branch on top of 'openwrt-18.06'):

https://github.com/sgruszka/openwrt/commit/8abecc22605bd0221022673a3671201256cff72b

wifi still does work on my MT7620 router with above change and print
is correct.

If it does not work for you, we have to figure this out. Maybe there are
extra patches that broke things or there are some race conditions when
setting "rt =" . Hard to tell. Perhaps you could provide dmesg 
from router where is does not work ?

Thanks
Stanislaw

  reply	other threads:[~2018-10-10 15:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09 11:56 [PATCH v3 1/4] rt2x00: remove unneeded check Stanislaw Gruszka
2018-10-09 11:56 ` [PATCH v3 2/4] rt2x00: remove confusing AGC register Stanislaw Gruszka
2018-10-09 12:27   ` Daniel Golle
2018-10-09 12:47     ` Stanislaw Gruszka
2018-10-09 13:07       ` Daniel Golle
2018-10-09 13:23         ` Stanislaw Gruszka
2018-10-09 11:56 ` [PATCH v3 3/4] rt2x00: update TX_SW_CFG2 value Stanislaw Gruszka
2018-10-09 11:56 ` [PATCH v3 4/4] rt2800: fix registers init for MT7620 Stanislaw Gruszka
2018-10-09 23:27   ` Tom Psyborg
2018-10-10  7:14     ` Stanislaw Gruszka
2018-10-10 12:06       ` Daniel Golle
2018-10-10 12:45         ` Stanislaw Gruszka
2018-10-10 14:11           ` Tom Psyborg
2018-10-10 15:40             ` Stanislaw Gruszka [this message]
2018-10-10 20:03               ` Tom Psyborg
2018-10-11 10:05                 ` Stanislaw Gruszka
2018-10-11 12:39                   ` Tom Psyborg
2018-10-12  8:50                     ` Stanislaw Gruszka
2018-10-11 10:06 ` [PATCH v3 1/4] rt2x00: remove unneeded check Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181010154054.GA27779@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=daniel@makrotopia.org \
    --cc=dev@kresin.me \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=pozega.tomislav@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.