From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Kjxg=MX=vger.kernel.org=devicetree-owner@kernel.org>
Received: from mail-lf1-f65.google.com ([209.85.167.65]:44471 "EHLO
        mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727799AbeJKO4F (ORCPT
        <rfc822;devicetree@vger.kernel.org>); Thu, 11 Oct 2018 10:56:05 -0400
Received: by mail-lf1-f65.google.com with SMTP id m18-v6so5895478lfl.11
        for <devicetree@vger.kernel.org>; Thu, 11 Oct 2018 00:30:04 -0700 (PDT)
Date: Thu, 11 Oct 2018 09:30:02 +0200
From: Niklas =?iso-8859-1?Q?S=F6derlund?=
        <niklas.soderlund@ragnatech.se>
Subject: Re: [PATCH v2] arm64: dts: renesas: r8a77980: add thermal support
Message-ID: <20181011073002.GH24305@bigcity.dyn.berto.se>
References: <fb4eb097-40aa-82df-68c7-9b727c858a8b@cogentembedded.com>
 <90934111-8cc5-482d-8a78-5ccc1113e42d@cogentembedded.com>
 <20181010221142.GG24305@bigcity.dyn.berto.se>
 <CAMuHMdU5=CQPopwBspBgngLnMxTSJ3f=DsUOGT94q9fMx55HLA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMuHMdU5=CQPopwBspBgngLnMxTSJ3f=DsUOGT94q9fMx55HLA@mail.gmail.com>
Sender: devicetree-owner@vger.kernel.org
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, Simon Horman <horms@verge.net.au>, Rob Herring <robh+dt@kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Magnus Damm <magnus.damm@gmail.com>, Mark Rutland <mark.rutland@arm.com>
List-ID: <devicetree@vger.kernel.org>

Hi Geert,

On 2018-10-11 09:02:22 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
> 
> On Thu, Oct 11, 2018 at 12:11 AM Niklas S�derlund
> <niklas.soderlund@ragnatech.se> wrote:
> > On 2018-10-10 22:18:11 +0300, Sergei Shtylyov wrote:
> > > Describe THS/CIVM in the R8A77980 device trees.
> > >
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > @@ -330,6 +330,19 @@
> > >                       #power-domain-cells = <1>;
> > >               };
> > >
> > > +             tsc: thermal@e6198000 {
> > > +                     compatible = "renesas,r8a77980-thermal";
> > > +                     reg = <0 0xe6198000 0 0x100>,
> > > +                           <0 0xe61a0000 0 0x100>;
> > > +                     interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                  <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                  <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> > > +                     clocks = <&cpg CPG_MOD 522>;
> > > +                     power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> > > +                     resets = <&cpg 522>;
> > > +                     #thermal-sensor-cells = <1>;
> >
> > The status property is missing but as you told me in v1 it should not
> > matter. I will leave it for Simon to decide if he wants it to keep it
> > consistent with other SoC or if we should remove it from the other dtsi
> > files. In any case with or without the status property.
> 
> Forgot to review commit c79661eb5060e2bf ("arm64: dts: renesas: Remove
> unneeded status from thermal nodes")? ;-)

Not only that also reviewing using the context from v4.19-rc1 which of 
course is not correct for dtsi patches, thanks for enlightening me :-)

-- 
Regards,
Niklas S�derlund